* [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470
@ 2019-01-21 23:19 ` Sinan Kaya
0 siblings, 0 replies; 17+ messages in thread
From: Sinan Kaya @ 2019-01-21 23:19 UTC (permalink / raw)
To: linux-next; +Cc: linux-acpi, Sinan Kaya, Lee Jones, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly.
WARNING: unmet direct dependencies detected for I2C_DESIGNWARE_PLATFORM
Depends on [n]: I2C [=y] && HAS_IOMEM [=y] && (ACPI [=y] && COMMON_CLK [=n] || !ACPI [=y])
Selected by [y]:
- MFD_TPS68470 [=y] && HAS_IOMEM [=y] && ACPI [=y] && I2C [=y]=y
MFD_TPS68470 is an ACPI only device and selects I2C_DESIGNWARE_PLATFORM.
I2C_DESIGNWARE_PLATFORM does not have any configuration today for ACPI
support without CONFIG_PCI set.
For sake of a quick fix this introduces a new mandatory dependency to the
driver which may survive without it. Otherwise we need to revisit the
driver architecture to address this properly.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index f461460a2aeb..76f9909cf396 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1419,7 +1419,7 @@ config MFD_TPS65217
config MFD_TPS68470
bool "TI TPS68470 Power Management / LED chips"
- depends on ACPI && I2C=y
+ depends on ACPI && PCI && I2C=y
select MFD_CORE
select REGMAP_I2C
select I2C_DESIGNWARE_PLATFORM
--
2.19.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470
@ 2019-01-21 23:19 ` Sinan Kaya
0 siblings, 0 replies; 17+ messages in thread
From: Sinan Kaya @ 2019-01-21 23:19 UTC (permalink / raw)
To: linux-next; +Cc: linux-acpi, Sinan Kaya, Lee Jones, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly.
WARNING: unmet direct dependencies detected for I2C_DESIGNWARE_PLATFORM
Depends on [n]: I2C [=y] && HAS_IOMEM [=y] && (ACPI [=y] && COMMON_CLK [=n] || !ACPI [=y])
Selected by [y]:
- MFD_TPS68470 [=y] && HAS_IOMEM [=y] && ACPI [=y] && I2C [=y]=y
MFD_TPS68470 is an ACPI only device and selects I2C_DESIGNWARE_PLATFORM.
I2C_DESIGNWARE_PLATFORM does not have any configuration today for ACPI
support without CONFIG_PCI set.
For sake of a quick fix this introduces a new mandatory dependency to the
driver which may survive without it. Otherwise we need to revisit the
driver architecture to address this properly.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index f461460a2aeb..76f9909cf396 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1419,7 +1419,7 @@ config MFD_TPS65217
config MFD_TPS68470
bool "TI TPS68470 Power Management / LED chips"
- depends on ACPI && I2C=y
+ depends on ACPI && PCI && I2C=y
select MFD_CORE
select REGMAP_I2C
select I2C_DESIGNWARE_PLATFORM
--
2.19.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
2019-01-21 23:19 ` Sinan Kaya
@ 2019-01-21 23:19 ` Sinan Kaya
-1 siblings, 0 replies; 17+ messages in thread
From: Sinan Kaya @ 2019-01-21 23:19 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT,
open list:X86 ARCHITECTURE 32-BIT AND 64-BIT
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly.
PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
mentioned in the Kconfig.
Add an explicit dependency here.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 568f339595ed..0519da6f8ee4 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -199,7 +199,7 @@ config X86
select IRQ_FORCED_THREADING
select NEED_SG_DMA_LENGTH
select PCI_DOMAINS if PCI
- select PCI_LOCKLESS_CONFIG
+ select PCI_LOCKLESS_CONFIG if PCI
select PERF_EVENTS
select RTC_LIB
select RTC_MC146818_LIB
--
2.19.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
@ 2019-01-21 23:19 ` Sinan Kaya
0 siblings, 0 replies; 17+ messages in thread
From: Sinan Kaya @ 2019-01-21 23:19 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly.
PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
mentioned in the Kconfig.
Add an explicit dependency here.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 568f339595ed..0519da6f8ee4 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -199,7 +199,7 @@ config X86
select IRQ_FORCED_THREADING
select NEED_SG_DMA_LENGTH
select PCI_DOMAINS if PCI
- select PCI_LOCKLESS_CONFIG
+ select PCI_LOCKLESS_CONFIG if PCI
select PERF_EVENTS
select RTC_LIB
select RTC_MC146818_LIB
--
2.19.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
2019-01-21 23:19 ` Sinan Kaya
@ 2019-01-22 12:54 ` Borislav Petkov
-1 siblings, 0 replies; 17+ messages in thread
From: Borislav Petkov @ 2019-01-22 12:54 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, linux-acpi, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
On Mon, Jan 21, 2019 at 11:19:58PM +0000, Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly.
>
> PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
> mentioned in the Kconfig.
>
> Add an explicit dependency here.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 568f339595ed..0519da6f8ee4 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -199,7 +199,7 @@ config X86
> select IRQ_FORCED_THREADING
> select NEED_SG_DMA_LENGTH
> select PCI_DOMAINS if PCI
> - select PCI_LOCKLESS_CONFIG
> + select PCI_LOCKLESS_CONFIG if PCI
> select PERF_EVENTS
> select RTC_LIB
> select RTC_MC146818_LIB
> --
AFAICT, this is not really fixing a random config build issue but only
correcting the dependency, right?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
@ 2019-01-22 12:54 ` Borislav Petkov
0 siblings, 0 replies; 17+ messages in thread
From: Borislav Petkov @ 2019-01-22 12:54 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, linux-acpi, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
On Mon, Jan 21, 2019 at 11:19:58PM +0000, Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly.
>
> PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
> mentioned in the Kconfig.
>
> Add an explicit dependency here.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 568f339595ed..0519da6f8ee4 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -199,7 +199,7 @@ config X86
> select IRQ_FORCED_THREADING
> select NEED_SG_DMA_LENGTH
> select PCI_DOMAINS if PCI
> - select PCI_LOCKLESS_CONFIG
> + select PCI_LOCKLESS_CONFIG if PCI
> select PERF_EVENTS
> select RTC_LIB
> select RTC_MC146818_LIB
> --
AFAICT, this is not really fixing a random config build issue but only
correcting the dependency, right?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
2019-01-22 12:54 ` Borislav Petkov
@ 2019-01-22 14:39 ` Sinan Kaya
-1 siblings, 0 replies; 17+ messages in thread
From: Sinan Kaya @ 2019-01-22 14:39 UTC (permalink / raw)
To: Borislav Petkov
Cc: linux-next, linux-acpi, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
On 1/22/19, Borislav Petkov <bp@alien8.de> wrote:
> On Mon, Jan 21, 2019 at 11:19:58PM +0000, Sinan Kaya wrote:
>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>> specified directly.
>>
>> PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
>> mentioned in the Kconfig.
>>
>> Add an explicit dependency here.
>>
>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI
>> set")
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> ---
>> arch/x86/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 568f339595ed..0519da6f8ee4 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -199,7 +199,7 @@ config X86
>> select IRQ_FORCED_THREADING
>> select NEED_SG_DMA_LENGTH
>> select PCI_DOMAINS if PCI
>> - select PCI_LOCKLESS_CONFIG
>> + select PCI_LOCKLESS_CONFIG if PCI
>> select PERF_EVENTS
>> select RTC_LIB
>> select RTC_MC146818_LIB
>> --
>
> AFAICT, this is not really fixing a random config build issue but only
> correcting the dependency, right?
>
This is fixing a warning found by randconfig on this thread
'linux-next: Tree for Jan 16 (PCI config warning?)'
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
@ 2019-01-22 14:39 ` Sinan Kaya
0 siblings, 0 replies; 17+ messages in thread
From: Sinan Kaya @ 2019-01-22 14:39 UTC (permalink / raw)
To: Borislav Petkov
Cc: linux-next, linux-acpi, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
On 1/22/19, Borislav Petkov <bp@alien8.de> wrote:
> On Mon, Jan 21, 2019 at 11:19:58PM +0000, Sinan Kaya wrote:
>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>> specified directly.
>>
>> PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
>> mentioned in the Kconfig.
>>
>> Add an explicit dependency here.
>>
>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI
>> set")
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> ---
>> arch/x86/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 568f339595ed..0519da6f8ee4 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -199,7 +199,7 @@ config X86
>> select IRQ_FORCED_THREADING
>> select NEED_SG_DMA_LENGTH
>> select PCI_DOMAINS if PCI
>> - select PCI_LOCKLESS_CONFIG
>> + select PCI_LOCKLESS_CONFIG if PCI
>> select PERF_EVENTS
>> select RTC_LIB
>> select RTC_MC146818_LIB
>> --
>
> AFAICT, this is not really fixing a random config build issue but only
> correcting the dependency, right?
>
This is fixing a warning found by randconfig on this thread
'linux-next: Tree for Jan 16 (PCI config warning?)'
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [tip:x86/urgent] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
2019-01-21 23:19 ` Sinan Kaya
(?)
(?)
@ 2019-01-22 21:51 ` tip-bot for Sinan Kaya
-1 siblings, 0 replies; 17+ messages in thread
From: tip-bot for Sinan Kaya @ 2019-01-22 21:51 UTC (permalink / raw)
To: linux-tip-commits; +Cc: tglx, hpa, x86, linux-kernel, mingo, bp, okaya, mingo
Commit-ID: 625210cfa6c0c26ea422f655bf68288176f174e6
Gitweb: https://git.kernel.org/tip/625210cfa6c0c26ea422f655bf68288176f174e6
Author: Sinan Kaya <okaya@kernel.org>
AuthorDate: Mon, 21 Jan 2019 23:19:58 +0000
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Tue, 22 Jan 2019 17:06:28 +0100
x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
After commit
5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
dependencies on CONFIG_PCI that previously were satisfied implicitly
through dependencies on CONFIG_ACPI have to be specified directly.
PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
mentioned in the Kconfig so add an explicit dependency here and fix
WARNING: unmet direct dependencies detected for PCI_LOCKLESS_CONFIG
Depends on [n]: PCI [=n]
Selected by [y]:
- X86 [=y]
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-acpi@vger.kernel.org
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20190121231958.28255-2-okaya@kernel.org
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 4b4a7f32b68e..26387c7bf305 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -198,7 +198,7 @@ config X86
select IRQ_FORCED_THREADING
select NEED_SG_DMA_LENGTH
select PCI_DOMAINS if PCI
- select PCI_LOCKLESS_CONFIG
+ select PCI_LOCKLESS_CONFIG if PCI
select PERF_EVENTS
select RTC_LIB
select RTC_MC146818_LIB
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
2019-01-21 23:19 ` Sinan Kaya
@ 2019-01-24 10:51 ` Rafael J. Wysocki
-1 siblings, 0 replies; 17+ messages in thread
From: Rafael J. Wysocki @ 2019-01-24 10:51 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, linux-acpi, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
On Tuesday, January 22, 2019 12:19:58 AM CET Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly.
>
> PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
> mentioned in the Kconfig.
>
> Add an explicit dependency here.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 568f339595ed..0519da6f8ee4 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -199,7 +199,7 @@ config X86
> select IRQ_FORCED_THREADING
> select NEED_SG_DMA_LENGTH
> select PCI_DOMAINS if PCI
> - select PCI_LOCKLESS_CONFIG
> + select PCI_LOCKLESS_CONFIG if PCI
> select PERF_EVENTS
> select RTC_LIB
> select RTC_MC146818_LIB
>
Is anyone taking this or should I?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
@ 2019-01-24 10:51 ` Rafael J. Wysocki
0 siblings, 0 replies; 17+ messages in thread
From: Rafael J. Wysocki @ 2019-01-24 10:51 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, linux-acpi, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
On Tuesday, January 22, 2019 12:19:58 AM CET Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly.
>
> PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
> mentioned in the Kconfig.
>
> Add an explicit dependency here.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 568f339595ed..0519da6f8ee4 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -199,7 +199,7 @@ config X86
> select IRQ_FORCED_THREADING
> select NEED_SG_DMA_LENGTH
> select PCI_DOMAINS if PCI
> - select PCI_LOCKLESS_CONFIG
> + select PCI_LOCKLESS_CONFIG if PCI
> select PERF_EVENTS
> select RTC_LIB
> select RTC_MC146818_LIB
>
Is anyone taking this or should I?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470
2019-01-21 23:19 ` Sinan Kaya
(?)
(?)
@ 2019-01-24 10:51 ` Rafael J. Wysocki
2019-01-24 17:43 ` Sinan Kaya
-1 siblings, 1 reply; 17+ messages in thread
From: Rafael J. Wysocki @ 2019-01-24 10:51 UTC (permalink / raw)
To: Sinan Kaya; +Cc: linux-next, linux-acpi, Lee Jones, open list
On Tuesday, January 22, 2019 12:19:57 AM CET Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly.
>
> WARNING: unmet direct dependencies detected for I2C_DESIGNWARE_PLATFORM
> Depends on [n]: I2C [=y] && HAS_IOMEM [=y] && (ACPI [=y] && COMMON_CLK [=n] || !ACPI [=y])
> Selected by [y]:
> - MFD_TPS68470 [=y] && HAS_IOMEM [=y] && ACPI [=y] && I2C [=y]=y
>
> MFD_TPS68470 is an ACPI only device and selects I2C_DESIGNWARE_PLATFORM.
> I2C_DESIGNWARE_PLATFORM does not have any configuration today for ACPI
> support without CONFIG_PCI set.
>
> For sake of a quick fix this introduces a new mandatory dependency to the
> driver which may survive without it. Otherwise we need to revisit the
> driver architecture to address this properly.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index f461460a2aeb..76f9909cf396 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1419,7 +1419,7 @@ config MFD_TPS65217
>
> config MFD_TPS68470
> bool "TI TPS68470 Power Management / LED chips"
> - depends on ACPI && I2C=y
> + depends on ACPI && PCI && I2C=y
> select MFD_CORE
> select REGMAP_I2C
> select I2C_DESIGNWARE_PLATFORM
>
Is anyone taking this or should I?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
2019-01-24 10:51 ` Rafael J. Wysocki
@ 2019-01-24 17:42 ` Sinan Kaya
-1 siblings, 0 replies; 17+ messages in thread
From: Sinan Kaya @ 2019-01-24 17:42 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-next, linux-acpi, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
On 1/24/2019 5:51 AM, Rafael J. Wysocki wrote:
>>
> Is anyone taking this or should I?
>
>
>
This got applied:
https://git.kernel.org/tip/625210cfa6c0c26ea422f655bf68288176f174e6
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
@ 2019-01-24 17:42 ` Sinan Kaya
0 siblings, 0 replies; 17+ messages in thread
From: Sinan Kaya @ 2019-01-24 17:42 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-next, linux-acpi, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
On 1/24/2019 5:51 AM, Rafael J. Wysocki wrote:
>>
> Is anyone taking this or should I?
>
>
>
This got applied:
https://git.kernel.org/tip/625210cfa6c0c26ea422f655bf68288176f174e6
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470
2019-01-24 10:51 ` [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470 Rafael J. Wysocki
@ 2019-01-24 17:43 ` Sinan Kaya
2019-01-28 7:21 ` Lee Jones
0 siblings, 1 reply; 17+ messages in thread
From: Sinan Kaya @ 2019-01-24 17:43 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-next, linux-acpi, Lee Jones, open list
On 1/24/2019 5:51 AM, Rafael J. Wysocki wrote:
> Is anyone taking this or should I?
Nobody replied to this yet. I was hoping this series to go through acpi
tree like the rest of the other fixes.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470
2019-01-24 17:43 ` Sinan Kaya
@ 2019-01-28 7:21 ` Lee Jones
2019-01-30 23:55 ` Rafael J. Wysocki
0 siblings, 1 reply; 17+ messages in thread
From: Lee Jones @ 2019-01-28 7:21 UTC (permalink / raw)
To: Sinan Kaya; +Cc: Rafael J. Wysocki, linux-next, linux-acpi, open list
On Thu, 24 Jan 2019, Sinan Kaya wrote:
> On 1/24/2019 5:51 AM, Rafael J. Wysocki wrote:
> > Is anyone taking this or should I?
>
> Nobody replied to this yet. I was hoping this series to go through acpi
> tree like the rest of the other fixes.
[post-vacation reply]
That's not how these things are usually handled, but I taking into
consideration the trivialises of the patch, I don't really mind.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470
2019-01-28 7:21 ` Lee Jones
@ 2019-01-30 23:55 ` Rafael J. Wysocki
0 siblings, 0 replies; 17+ messages in thread
From: Rafael J. Wysocki @ 2019-01-30 23:55 UTC (permalink / raw)
To: Lee Jones, Sinan Kaya; +Cc: linux-next, linux-acpi, open list
On Monday, January 28, 2019 8:21:56 AM CET Lee Jones wrote:
> On Thu, 24 Jan 2019, Sinan Kaya wrote:
>
> > On 1/24/2019 5:51 AM, Rafael J. Wysocki wrote:
> > > Is anyone taking this or should I?
> >
> > Nobody replied to this yet. I was hoping this series to go through acpi
> > tree like the rest of the other fixes.
>
> [post-vacation reply]
>
> That's not how these things are usually handled, but I taking into
> consideration the trivialises of the patch, I don't really mind.
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
I've applied this one, thanks!
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2019-01-30 23:55 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-21 23:19 [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470 Sinan Kaya
2019-01-21 23:19 ` Sinan Kaya
2019-01-21 23:19 ` [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled Sinan Kaya
2019-01-21 23:19 ` Sinan Kaya
2019-01-22 12:54 ` Borislav Petkov
2019-01-22 12:54 ` Borislav Petkov
2019-01-22 14:39 ` Sinan Kaya
2019-01-22 14:39 ` Sinan Kaya
2019-01-22 21:51 ` [tip:x86/urgent] " tip-bot for Sinan Kaya
2019-01-24 10:51 ` [for next][PATCH 2/2] " Rafael J. Wysocki
2019-01-24 10:51 ` Rafael J. Wysocki
2019-01-24 17:42 ` Sinan Kaya
2019-01-24 17:42 ` Sinan Kaya
2019-01-24 10:51 ` [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470 Rafael J. Wysocki
2019-01-24 17:43 ` Sinan Kaya
2019-01-28 7:21 ` Lee Jones
2019-01-30 23:55 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.