From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v1 3/8] arm64: dts: sdm845: Add UFS PHY reset Date: Mon, 21 Jan 2019 18:25:49 -0600 Message-ID: <20190122002549.GA20481@bogus> References: <20190111230129.127037-1-evgreen@chromium.org> <20190111230129.127037-4-evgreen@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190111230129.127037-4-evgreen@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Evan Green Cc: Andy Gross , Kishon Vijay Abraham I , Can Guo , Douglas Anderson , Asutosh Das , Stephen Boyd , Vivek Gautam , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, David Brown , Mark Rutland List-Id: linux-arm-msm@vger.kernel.org On Fri, Jan 11, 2019 at 03:01:24PM -0800, Evan Green wrote: > Wire up the reset controller in the Qcom UFS controller for the PHY. > This will be used to toggle PHY reset during initialization of the PHY. > > Signed-off-by: Evan Green > --- > This commit is based atop the series at [1]. Patches 1 and 2 of that > series have landed, but 3, 4, and 5 are still outstanding. > > [1] https://lore.kernel.org/lkml/20181210192826.241350-1-evgreen@chromium.org/ > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index b29332b265d9e..029ab66405cf4 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -990,6 +990,7 @@ > phy-names = "ufsphy"; > lanes-per-direction = <2>; > power-domains = <&gcc UFS_PHY_GDSC>; > + #reset-cells = <1>; Is this documented? > > clock-names = > "core_clk", > @@ -1033,6 +1034,8 @@ > clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, > <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; > > + resets = <&ufs_mem_hc 0>; > + reset-names = "ufsphy"; > status = "disabled"; > > ufs_mem_phy_lanes: lanes@1d87400 { > -- > 2.18.1 >