All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: rkir@google.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] drivers: platform: goldfish: goldfish_sync: add a driver
Date: Tue, 22 Jan 2019 12:08:09 +0100	[thread overview]
Message-ID: <20190122110809.GB1004@kroah.com> (raw)
In-Reply-To: <20190109021112.5836-3-rkir@google.com>

On Tue, Jan 08, 2019 at 06:11:12PM -0800, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
> 
> The Goldfish sync driver is designed to provide a interface
> between the underlying host's sync device and the kernel's
> fence sync framework.
> 
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> Changes in v3:
>  - Removed WARN_ON.
> 
> Changes in v2:
>  - Added a missing include (mod_devicetable.h).
>  - Put in one batch with goldfish_address_space.c to avoid merge comflicts.
> 
>  drivers/platform/goldfish/Kconfig           |   7 +
>  drivers/platform/goldfish/Makefile          |   1 +
>  drivers/platform/goldfish/goldfish_sync.c   | 827 ++++++++++++++++++++
>  include/uapi/linux/goldfish/goldfish_sync.h |  28 +
>  4 files changed, 863 insertions(+)
>  create mode 100644 drivers/platform/goldfish/goldfish_sync.c
>  create mode 100644 include/uapi/linux/goldfish/goldfish_sync.h
> 

Please get this reviewed by the sync subsystem maintainers to ensure
that you are using the API properly, and that this really is needed.  If
it is needed, why is this a goldfish-only type device, why do not all
systems need this?

thanks,

greg k-h

      reply	other threads:[~2019-01-22 11:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09  2:11 [PATCH v3 1/3] drivers: platform: goldfish: fix the checkpatch complain in Kconfig rkir
2019-01-09  2:11 ` [PATCH v3 2/3] drivers: platform: goldfish: goldfish_address_space: add a driver rkir
2019-01-09  8:31   ` Greg KH
2019-01-10  1:41     ` Roman Kiryanov
2019-01-16  4:53       ` Roman Kiryanov
2019-01-22 11:07   ` Greg KH
2019-01-29  8:32     ` Roman Kiryanov
2019-01-29  9:37       ` Greg KH
2019-01-30 14:44       ` Greg KH
2019-01-31  3:56         ` Roman Kiryanov
2019-01-09  2:11 ` [PATCH v3 3/3] drivers: platform: goldfish: goldfish_sync: " rkir
2019-01-22 11:08   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122110809.GB1004@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkir@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.