From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled Date: Tue, 22 Jan 2019 13:54:41 +0100 Message-ID: <20190122125440.GG26587@zn.tnic> References: <20190121231958.28255-1-okaya@kernel.org> <20190121231958.28255-2-okaya@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190121231958.28255-2-okaya@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Sinan Kaya Cc: linux-next@vger.kernel.org, linux-acpi@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" List-Id: linux-acpi@vger.kernel.org On Mon, Jan 21, 2019 at 11:19:58PM +0000, Sinan Kaya wrote: > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. > > PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been > mentioned in the Kconfig. > > Add an explicit dependency here. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya > --- > arch/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 568f339595ed..0519da6f8ee4 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -199,7 +199,7 @@ config X86 > select IRQ_FORCED_THREADING > select NEED_SG_DMA_LENGTH > select PCI_DOMAINS if PCI > - select PCI_LOCKLESS_CONFIG > + select PCI_LOCKLESS_CONFIG if PCI > select PERF_EVENTS > select RTC_LIB > select RTC_MC146818_LIB > -- AFAICT, this is not really fixing a random config build issue but only correcting the dependency, right? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A8DEC282C3 for ; Tue, 22 Jan 2019 12:54:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34BD121019 for ; Tue, 22 Jan 2019 12:54:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="rq5hToXE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728434AbfAVMys (ORCPT ); Tue, 22 Jan 2019 07:54:48 -0500 Received: from mail.skyhub.de ([5.9.137.197]:34022 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728062AbfAVMys (ORCPT ); Tue, 22 Jan 2019 07:54:48 -0500 Received: from zn.tnic (p200300EC2BCBD9002C2383DF7DDD45BD.dip0.t-ipconnect.de [IPv6:2003:ec:2bcb:d900:2c23:83df:7ddd:45bd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 56B551EC027A; Tue, 22 Jan 2019 13:54:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1548161686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=pCi3+kqb12uaOpftg4WZwvnMN4rqAKdbh/2ZZ4UXcts=; b=rq5hToXEChpZw64ab+VToz/jKMCHXo2GvLrhng4xspsb+taD+I09sYu6U0AokrPi/ACjqU c1CEfRxaioeBD644n35qOheIDhAUhfbjORa6xoDQfOXvmY25RF3t6iySAXgvHhZTsTvkPT 1EmINMUAER9Pys9N7amxe3JlG3X12Mw= Date: Tue, 22 Jan 2019 13:54:41 +0100 From: Borislav Petkov To: Sinan Kaya Cc: linux-next@vger.kernel.org, linux-acpi@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled Message-ID: <20190122125440.GG26587@zn.tnic> References: <20190121231958.28255-1-okaya@kernel.org> <20190121231958.28255-2-okaya@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190121231958.28255-2-okaya@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 21, 2019 at 11:19:58PM +0000, Sinan Kaya wrote: > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. > > PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been > mentioned in the Kconfig. > > Add an explicit dependency here. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya > --- > arch/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 568f339595ed..0519da6f8ee4 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -199,7 +199,7 @@ config X86 > select IRQ_FORCED_THREADING > select NEED_SG_DMA_LENGTH > select PCI_DOMAINS if PCI > - select PCI_LOCKLESS_CONFIG > + select PCI_LOCKLESS_CONFIG if PCI > select PERF_EVENTS > select RTC_LIB > select RTC_MC146818_LIB > -- AFAICT, this is not really fixing a random config build issue but only correcting the dependency, right? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.