From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm1nB-0007fN-Ng for qemu-devel@nongnu.org; Tue, 22 Jan 2019 14:33:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm1lu-0005k5-2q for qemu-devel@nongnu.org; Tue, 22 Jan 2019 14:31:44 -0500 Date: Tue, 22 Jan 2019 15:46:17 +0100 From: Kevin Wolf Message-ID: <20190122144617.GA5220@localhost.localdomain> References: <1545149484-4929-1-git-send-email-thuth@redhat.com> <25d1e73d-ca73-9cb4-d959-8353f49f36b7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25d1e73d-ca73-9cb4-d959-8353f49f36b7@redhat.com> Subject: Re: [Qemu-devel] [QEMU PATCH] block: Remove blk_attach_dev_legacy() / legacy_dev code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-block@nongnu.org, Max Reitz , Stefano Stabellini , Anthony Perard , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, paul.durrant@citrix.com Am 22.01.2019 um 15:19 hat Thomas Huth geschrieben: > On 2018-12-18 17:11, Thomas Huth wrote: > > The last user of blk_attach_dev_legacy() is the code in xen_disk.c. > > It passes a pointer to a XenBlkDev as second parameter. XenBlkDev > > is derived from XenDevice which in turn is derived from DeviceState > > since commit 3a6c9172ac5951e ("xen: create qdev for each backend device"). > > Thus the code can also simply use blk_attach_dev() with a pointer > > to the DeviceState instead. > > So we can finally remove all code related to the "legacy_dev" flag, too, > > and turn the related "void *" in block-backend.c into "DeviceState *" > > to fix some of the remaining TODOs there. > > > > Signed-off-by: Thomas Huth > > --- > > Note: I haven't tested the Xen code since I don't have a working Xen > > installation at hand. I'd appreciate if someone could check it... > > Ping? This needs a rebase. xen_disk.c doesn't even exist any more and blk_attach_dev_legacy() is really dead code now. The work on the Xen block device is the reason why I didn't merge this patch yet. I thought I had sent a reply to that effect, but it seems I hadn't. Sorry for that! Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [Qemu-devel] [QEMU PATCH] block: Remove blk_attach_dev_legacy() / legacy_dev code Date: Tue, 22 Jan 2019 15:46:17 +0100 Message-ID: <20190122144617.GA5220@localhost.localdomain> References: <1545149484-4929-1-git-send-email-thuth@redhat.com> <25d1e73d-ca73-9cb4-d959-8353f49f36b7@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1glxJn-0006Vo-6j for xen-devel@lists.xenproject.org; Tue, 22 Jan 2019 14:46:23 +0000 Content-Disposition: inline In-Reply-To: <25d1e73d-ca73-9cb4-d959-8353f49f36b7@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Thomas Huth Cc: Stefano Stabellini , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , paul.durrant@citrix.com, Anthony Perard , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org QW0gMjIuMDEuMjAxOSB1bSAxNToxOSBoYXQgVGhvbWFzIEh1dGggZ2VzY2hyaWViZW46Cj4gT24g MjAxOC0xMi0xOCAxNzoxMSwgVGhvbWFzIEh1dGggd3JvdGU6Cj4gPiBUaGUgbGFzdCB1c2VyIG9m IGJsa19hdHRhY2hfZGV2X2xlZ2FjeSgpIGlzIHRoZSBjb2RlIGluIHhlbl9kaXNrLmMuCj4gPiBJ dCBwYXNzZXMgYSBwb2ludGVyIHRvIGEgWGVuQmxrRGV2IGFzIHNlY29uZCBwYXJhbWV0ZXIuIFhl bkJsa0Rldgo+ID4gaXMgZGVyaXZlZCBmcm9tIFhlbkRldmljZSB3aGljaCBpbiB0dXJuIGlzIGRl cml2ZWQgZnJvbSBEZXZpY2VTdGF0ZQo+ID4gc2luY2UgY29tbWl0IDNhNmM5MTcyYWM1OTUxZSAo InhlbjogY3JlYXRlIHFkZXYgZm9yIGVhY2ggYmFja2VuZCBkZXZpY2UiKS4KPiA+IFRodXMgdGhl IGNvZGUgY2FuIGFsc28gc2ltcGx5IHVzZSBibGtfYXR0YWNoX2RldigpIHdpdGggYSBwb2ludGVy Cj4gPiB0byB0aGUgRGV2aWNlU3RhdGUgaW5zdGVhZC4KPiA+IFNvIHdlIGNhbiBmaW5hbGx5IHJl bW92ZSBhbGwgY29kZSByZWxhdGVkIHRvIHRoZSAibGVnYWN5X2RldiIgZmxhZywgdG9vLAo+ID4g YW5kIHR1cm4gdGhlIHJlbGF0ZWQgInZvaWQgKiIgaW4gYmxvY2stYmFja2VuZC5jIGludG8gIkRl dmljZVN0YXRlICoiCj4gPiB0byBmaXggc29tZSBvZiB0aGUgcmVtYWluaW5nIFRPRE9zIHRoZXJl Lgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgSHV0aCA8dGh1dGhAcmVkaGF0LmNvbT4K PiA+IC0tLQo+ID4gIE5vdGU6IEkgaGF2ZW4ndCB0ZXN0ZWQgdGhlIFhlbiBjb2RlIHNpbmNlIEkg ZG9uJ3QgaGF2ZSBhIHdvcmtpbmcgWGVuCj4gPiAgaW5zdGFsbGF0aW9uIGF0IGhhbmQuIEknZCBh cHByZWNpYXRlIGlmIHNvbWVvbmUgY291bGQgY2hlY2sgaXQuLi4KPiAKPiBQaW5nPwoKVGhpcyBu ZWVkcyBhIHJlYmFzZS4geGVuX2Rpc2suYyBkb2Vzbid0IGV2ZW4gZXhpc3QgYW55IG1vcmUgYW5k CmJsa19hdHRhY2hfZGV2X2xlZ2FjeSgpIGlzIHJlYWxseSBkZWFkIGNvZGUgbm93LgoKVGhlIHdv cmsgb24gdGhlIFhlbiBibG9jayBkZXZpY2UgaXMgdGhlIHJlYXNvbiB3aHkgSSBkaWRuJ3QgbWVy Z2UgdGhpcwpwYXRjaCB5ZXQuIEkgdGhvdWdodCBJIGhhZCBzZW50IGEgcmVwbHkgdG8gdGhhdCBl ZmZlY3QsIGJ1dCBpdCBzZWVtcyBJCmhhZG4ndC4gU29ycnkgZm9yIHRoYXQhCgpLZXZpbgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1h aWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==