From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v3 06/10] dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings Date: Tue, 22 Jan 2019 18:38:33 +0100 Message-ID: <20190122183833.40077d7a@windsurf> References: <20190121112336.23489-1-miquel.raynal@bootlin.com> <20190121112336.23489-7-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190121112336.23489-7-miquel.raynal@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miquel Raynal Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Mathias Nyman , devicetree@vger.kernel.org, Antoine Tenart , Greg Kroah-Hartman , Gregory Clement , linux-usb@vger.kernel.org, Kishon Vijay Abraham I , Nadav Haklai , Rob Herring , Alan Stern , Maxime Chevallier , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Hello, On Mon, 21 Jan 2019 12:23:32 +0100, Miquel Raynal wrote: > +- compatible: Should be one of: > + * "marvell,a3700-utmi-host-phy" for the PHY connected to > + the USB2 host-only controller. > + * "marvell,a3700-utmi-otg-phy" for the PHY connected to > + the USB3 and USB2 OTG capable controller. Do we really need different compatible strings for those ? I assume the IP block is exactly the same for the two PHYs, right ? If so, we should use the same compatible string. Didn't we discuss that we can lookup from the PHY whether the USB controller it is connected to is in host mode or otg mode ? > +Example: > + > + usb2_utmi_host_phy: phy@5f000 { > + compatible = "marvell,armada-3700-utmi-host-phy"; > + reg = <0x5f000 0x800>; > + marvell,usb-misc-reg = <&usb2_syscon>; > + #phy-cells = <0>; > + }; > + > + usb2_syscon: system-controller@5f800 { > + compatible = "marvell,usb2-host-miscellaneous", "syscon"; > + reg = <0x5f800 0x800>; > + }; Those registers are contiguous to the register range of the PHY itself. What was the criteria used to decide that we need two separate DT nodes for these ? Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,06/10] dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings From: Thomas Petazzoni Message-Id: <20190122183833.40077d7a@windsurf> Date: Tue, 22 Jan 2019 18:38:33 +0100 To: Miquel Raynal Cc: Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Kishon Vijay Abraham I , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Mathias Nyman , Alan Stern , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, Antoine Tenart , Maxime Chevallier , Nadav Haklai List-ID: SGVsbG8sCgpPbiBNb24sIDIxIEphbiAyMDE5IDEyOjIzOjMyICswMTAwLCBNaXF1ZWwgUmF5bmFs IHdyb3RlOgoKPiArLSBjb21wYXRpYmxlOiBTaG91bGQgYmUgb25lIG9mOgo+ICsJICAgICAgKiAi bWFydmVsbCxhMzcwMC11dG1pLWhvc3QtcGh5IiBmb3IgdGhlIFBIWSBjb25uZWN0ZWQgdG8KPiAr CSAgICAgICAgdGhlIFVTQjIgaG9zdC1vbmx5IGNvbnRyb2xsZXIuCj4gKwkgICAgICAqICJtYXJ2 ZWxsLGEzNzAwLXV0bWktb3RnLXBoeSIgZm9yIHRoZSBQSFkgY29ubmVjdGVkIHRvCj4gKwkgICAg ICAgIHRoZSBVU0IzIGFuZCBVU0IyIE9URyBjYXBhYmxlIGNvbnRyb2xsZXIuCgpEbyB3ZSByZWFs bHkgbmVlZCBkaWZmZXJlbnQgY29tcGF0aWJsZSBzdHJpbmdzIGZvciB0aG9zZSA/IEkgYXNzdW1l IHRoZQpJUCBibG9jayBpcyBleGFjdGx5IHRoZSBzYW1lIGZvciB0aGUgdHdvIFBIWXMsIHJpZ2h0 ID8gSWYgc28sIHdlIHNob3VsZAp1c2UgdGhlIHNhbWUgY29tcGF0aWJsZSBzdHJpbmcuCgpEaWRu J3Qgd2UgZGlzY3VzcyB0aGF0IHdlIGNhbiBsb29rdXAgZnJvbSB0aGUgUEhZIHdoZXRoZXIgdGhl IFVTQgpjb250cm9sbGVyIGl0IGlzIGNvbm5lY3RlZCB0byBpcyBpbiBob3N0IG1vZGUgb3Igb3Rn IG1vZGUgPwoKPiArRXhhbXBsZToKPiArCj4gKwl1c2IyX3V0bWlfaG9zdF9waHk6IHBoeUA1ZjAw MCB7Cj4gKwkJY29tcGF0aWJsZSA9ICJtYXJ2ZWxsLGFybWFkYS0zNzAwLXV0bWktaG9zdC1waHki Owo+ICsJCXJlZyA9IDwweDVmMDAwIDB4ODAwPjsKPiArCQltYXJ2ZWxsLHVzYi1taXNjLXJlZyA9 IDwmdXNiMl9zeXNjb24+Owo+ICsJCSNwaHktY2VsbHMgPSA8MD47Cj4gKwl9Owo+ICsKPiArCXVz YjJfc3lzY29uOiBzeXN0ZW0tY29udHJvbGxlckA1ZjgwMCB7Cj4gKwkJY29tcGF0aWJsZSA9ICJt YXJ2ZWxsLHVzYjItaG9zdC1taXNjZWxsYW5lb3VzIiwgInN5c2NvbiI7Cj4gKwkJcmVnID0gPDB4 NWY4MDAgMHg4MDA+Owo+ICsJfTsKClRob3NlIHJlZ2lzdGVycyBhcmUgY29udGlndW91cyB0byB0 aGUgcmVnaXN0ZXIgcmFuZ2Ugb2YgdGhlIFBIWSBpdHNlbGYuCldoYXQgd2FzIHRoZSBjcml0ZXJp YSB1c2VkIHRvIGRlY2lkZSB0aGF0IHdlIG5lZWQgdHdvIHNlcGFyYXRlIERUIG5vZGVzCmZvciB0 aGVzZSA/CgpCZXN0IHJlZ2FyZHMsCgpUaG9tYXMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E9AC282C3 for ; Tue, 22 Jan 2019 17:39:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 152DE21019 for ; Tue, 22 Jan 2019 17:39:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CQzFKTKY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 152DE21019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fay3efnYSlK1U4IUbG1/F4pArBbvo2inHgj1WgYqYDw=; b=CQzFKTKYY2BTbc V4d7ChK27Wpr+sv5bfdQBxNEq79lxp5BqgMkRInOHBO3ah0/WHF5jnrXYaWs3QNQW89mZhs/aQULB ypFI8fjddw+9hpqUAa4NsusYBJfkX5f1xMj/gQ4F4ufX/98wmwiOwuxPGJu5IPDvleHmK9nA4B6c/ MRRlQP0cJBAF/OQboMDvoQ6437iMQ2wueFwCB7mdWZERlzcYmEdEjTA3j9Oz3BKdk4XXInZkgtK8t 5U33DF4wX8cYU3ejpAjlUvUjR2CBkzXCUJkwTCqNK5JRd0h3TX/T5q/YeHXtUVczmBGWpObY8pIBB 45zF+RMGnOMzMuYaSwAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gm01c-000542-42; Tue, 22 Jan 2019 17:39:48 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gm01Y-00053e-TG for linux-arm-kernel@lists.infradead.org; Tue, 22 Jan 2019 17:39:46 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 9601020758; Tue, 22 Jan 2019 18:39:41 +0100 (CET) Received: from windsurf (pv7105-0562400153.pck.nerim.net [62.212.110.213]) by mail.bootlin.com (Postfix) with ESMTPSA id 022BE206A6; Tue, 22 Jan 2019 18:39:39 +0100 (CET) Date: Tue, 22 Jan 2019 18:38:33 +0100 From: Thomas Petazzoni To: Miquel Raynal Subject: Re: [PATCH v3 06/10] dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings Message-ID: <20190122183833.40077d7a@windsurf> In-Reply-To: <20190121112336.23489-7-miquel.raynal@bootlin.com> References: <20190121112336.23489-1-miquel.raynal@bootlin.com> <20190121112336.23489-7-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190122_093945_094737_D35AE02C X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Mathias Nyman , devicetree@vger.kernel.org, Antoine Tenart , Greg Kroah-Hartman , Gregory Clement , linux-usb@vger.kernel.org, Kishon Vijay Abraham I , Nadav Haklai , Rob Herring , Alan Stern , Maxime Chevallier , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Mon, 21 Jan 2019 12:23:32 +0100, Miquel Raynal wrote: > +- compatible: Should be one of: > + * "marvell,a3700-utmi-host-phy" for the PHY connected to > + the USB2 host-only controller. > + * "marvell,a3700-utmi-otg-phy" for the PHY connected to > + the USB3 and USB2 OTG capable controller. Do we really need different compatible strings for those ? I assume the IP block is exactly the same for the two PHYs, right ? If so, we should use the same compatible string. Didn't we discuss that we can lookup from the PHY whether the USB controller it is connected to is in host mode or otg mode ? > +Example: > + > + usb2_utmi_host_phy: phy@5f000 { > + compatible = "marvell,armada-3700-utmi-host-phy"; > + reg = <0x5f000 0x800>; > + marvell,usb-misc-reg = <&usb2_syscon>; > + #phy-cells = <0>; > + }; > + > + usb2_syscon: system-controller@5f800 { > + compatible = "marvell,usb2-host-miscellaneous", "syscon"; > + reg = <0x5f800 0x800>; > + }; Those registers are contiguous to the register range of the PHY itself. What was the criteria used to decide that we need two separate DT nodes for these ? Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel