All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator
@ 2019-01-22 23:34 Gustavo A. R. Silva
  2019-01-23  8:33 ` Jiri Olsa
  2019-02-09 12:19 ` [tip:perf/urgent] perf tests " tip-bot for Gustavo A. R. Silva
  0 siblings, 2 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-22 23:34 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Alexander Shishkin, Jiri Olsa, Namhyung Kim
  Cc: linux-kernel, Gustavo A. R. Silva

Notice that the use of the bitwise OR operator '|' always leads to
true in this particular case, which seems a bit suspicious due to
the context in which this expression is being used.

Fix this by using bitwise AND operator '&' instead.

This bug was detected with the help of Coccinelle.

Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---

NOTE: Notice that this code has been there since 2012. So, it would
      be helpful if someone can double-check this. Thanks.

 tools/perf/tests/evsel-tp-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c
index 5f8501c68da4..5cbba70bcdd0 100644
--- a/tools/perf/tests/evsel-tp-sched.c
+++ b/tools/perf/tests/evsel-tp-sched.c
@@ -17,7 +17,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
 		return -1;
 	}
 
-	is_signed = !!(field->flags | TEP_FIELD_IS_SIGNED);
+	is_signed = !!(field->flags & TEP_FIELD_IS_SIGNED);
 	if (should_be_signed && !is_signed) {
 		pr_debug("%s: \"%s\" signedness(%d) is wrong, should be %d\n",
 			 evsel->name, name, is_signed, should_be_signed);
-- 
2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator
  2019-01-22 23:34 [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator Gustavo A. R. Silva
@ 2019-01-23  8:33 ` Jiri Olsa
  2019-01-23  8:40   ` Gustavo A. R. Silva
  2019-01-29  9:01   ` Arnaldo Carvalho de Melo
  2019-02-09 12:19 ` [tip:perf/urgent] perf tests " tip-bot for Gustavo A. R. Silva
  1 sibling, 2 replies; 6+ messages in thread
From: Jiri Olsa @ 2019-01-23  8:33 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Alexander Shishkin, Namhyung Kim, linux-kernel

On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote:
> Notice that the use of the bitwise OR operator '|' always leads to
> true in this particular case, which seems a bit suspicious due to
> the context in which this expression is being used.
> 
> Fix this by using bitwise AND operator '&' instead.
> 
> This bug was detected with the help of Coccinelle.
> 
> Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

nice catch

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka


> ---
> 
> NOTE: Notice that this code has been there since 2012. So, it would
>       be helpful if someone can double-check this. Thanks.
> 
>  tools/perf/tests/evsel-tp-sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c
> index 5f8501c68da4..5cbba70bcdd0 100644
> --- a/tools/perf/tests/evsel-tp-sched.c
> +++ b/tools/perf/tests/evsel-tp-sched.c
> @@ -17,7 +17,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
>  		return -1;
>  	}
>  
> -	is_signed = !!(field->flags | TEP_FIELD_IS_SIGNED);
> +	is_signed = !!(field->flags & TEP_FIELD_IS_SIGNED);
>  	if (should_be_signed && !is_signed) {
>  		pr_debug("%s: \"%s\" signedness(%d) is wrong, should be %d\n",
>  			 evsel->name, name, is_signed, should_be_signed);
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator
  2019-01-23  8:33 ` Jiri Olsa
@ 2019-01-23  8:40   ` Gustavo A. R. Silva
  2019-01-28 19:29     ` Gustavo A. R. Silva
  2019-01-29  9:01   ` Arnaldo Carvalho de Melo
  1 sibling, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-23  8:40 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Alexander Shishkin, Namhyung Kim, linux-kernel



On 1/23/19 2:33 AM, Jiri Olsa wrote:
> On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote:
>> Notice that the use of the bitwise OR operator '|' always leads to
>> true in this particular case, which seems a bit suspicious due to
>> the context in which this expression is being used.
>>
>> Fix this by using bitwise AND operator '&' instead.
>>
>> This bug was detected with the help of Coccinelle.
>>
>> Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> nice catch
> 

Glad to help. :)

> Acked-by: Jiri Olsa <jolsa@kernel.org>
> 

Thanks
--
Gustavo

> thanks,
> jirka
> 
> 
>> ---
>>
>> NOTE: Notice that this code has been there since 2012. So, it would
>>       be helpful if someone can double-check this. Thanks.
>>
>>  tools/perf/tests/evsel-tp-sched.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c
>> index 5f8501c68da4..5cbba70bcdd0 100644
>> --- a/tools/perf/tests/evsel-tp-sched.c
>> +++ b/tools/perf/tests/evsel-tp-sched.c
>> @@ -17,7 +17,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
>>  		return -1;
>>  	}
>>  
>> -	is_signed = !!(field->flags | TEP_FIELD_IS_SIGNED);
>> +	is_signed = !!(field->flags & TEP_FIELD_IS_SIGNED);
>>  	if (should_be_signed && !is_signed) {
>>  		pr_debug("%s: \"%s\" signedness(%d) is wrong, should be %d\n",
>>  			 evsel->name, name, is_signed, should_be_signed);
>> -- 
>> 2.20.1
>>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator
  2019-01-23  8:40   ` Gustavo A. R. Silva
@ 2019-01-28 19:29     ` Gustavo A. R. Silva
  0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-28 19:29 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Alexander Shishkin, Namhyung Kim, linux-kernel

Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

On 1/23/19 2:40 AM, Gustavo A. R. Silva wrote:
> 
> 
> On 1/23/19 2:33 AM, Jiri Olsa wrote:
>> On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote:
>>> Notice that the use of the bitwise OR operator '|' always leads to
>>> true in this particular case, which seems a bit suspicious due to
>>> the context in which this expression is being used.
>>>
>>> Fix this by using bitwise AND operator '&' instead.
>>>
>>> This bug was detected with the help of Coccinelle.
>>>
>>> Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields")
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>
>> nice catch
>>
> 
> Glad to help. :)
> 
>> Acked-by: Jiri Olsa <jolsa@kernel.org>
>>
> 
> Thanks
> --
> Gustavo
> 
>> thanks,
>> jirka
>>
>>
>>> ---
>>>
>>> NOTE: Notice that this code has been there since 2012. So, it would
>>>       be helpful if someone can double-check this. Thanks.
>>>
>>>  tools/perf/tests/evsel-tp-sched.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c
>>> index 5f8501c68da4..5cbba70bcdd0 100644
>>> --- a/tools/perf/tests/evsel-tp-sched.c
>>> +++ b/tools/perf/tests/evsel-tp-sched.c
>>> @@ -17,7 +17,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
>>>  		return -1;
>>>  	}
>>>  
>>> -	is_signed = !!(field->flags | TEP_FIELD_IS_SIGNED);
>>> +	is_signed = !!(field->flags & TEP_FIELD_IS_SIGNED);
>>>  	if (should_be_signed && !is_signed) {
>>>  		pr_debug("%s: \"%s\" signedness(%d) is wrong, should be %d\n",
>>>  			 evsel->name, name, is_signed, should_be_signed);
>>> -- 
>>> 2.20.1
>>>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator
  2019-01-23  8:33 ` Jiri Olsa
  2019-01-23  8:40   ` Gustavo A. R. Silva
@ 2019-01-29  9:01   ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-01-29  9:01 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: Gustavo A. R. Silva, Peter Zijlstra, Ingo Molnar,
	Alexander Shishkin, Namhyung Kim, linux-kernel

Em Wed, Jan 23, 2019 at 09:33:38AM +0100, Jiri Olsa escreveu:
> On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote:
> > Notice that the use of the bitwise OR operator '|' always leads to
> > true in this particular case, which seems a bit suspicious due to
> > the context in which this expression is being used.
> > 
> > Fix this by using bitwise AND operator '&' instead.
> > 
> > This bug was detected with the help of Coccinelle.
> > 
> > Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> nice catch
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Argh, applied, and looking for an old brown paper bag...

- Arnaldo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [tip:perf/urgent] perf tests evsel-tp-sched: Fix bitwise operator
  2019-01-22 23:34 [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator Gustavo A. R. Silva
  2019-01-23  8:33 ` Jiri Olsa
@ 2019-02-09 12:19 ` tip-bot for Gustavo A. R. Silva
  1 sibling, 0 replies; 6+ messages in thread
From: tip-bot for Gustavo A. R. Silva @ 2019-02-09 12:19 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, gustavo, hpa, alexander.shishkin, tglx, peterz,
	mingo, namhyung, acme, jolsa

Commit-ID:  489338a717a0dfbbd5a3fabccf172b78f0ac9015
Gitweb:     https://git.kernel.org/tip/489338a717a0dfbbd5a3fabccf172b78f0ac9015
Author:     Gustavo A. R. Silva <gustavo@embeddedor.com>
AuthorDate: Tue, 22 Jan 2019 17:34:39 -0600
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 4 Feb 2019 11:32:14 -0300

perf tests evsel-tp-sched: Fix bitwise operator

Notice that the use of the bitwise OR operator '|' always leads to true
in this particular case, which seems a bit suspicious due to the context
in which this expression is being used.

Fix this by using bitwise AND operator '&' instead.

This bug was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: stable@vger.kernel.org
Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields")
Link: http://lkml.kernel.org/r/20190122233439.GA5868@embeddedor
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/tests/evsel-tp-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c
index 5f8501c68da4..5cbba70bcdd0 100644
--- a/tools/perf/tests/evsel-tp-sched.c
+++ b/tools/perf/tests/evsel-tp-sched.c
@@ -17,7 +17,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
 		return -1;
 	}
 
-	is_signed = !!(field->flags | TEP_FIELD_IS_SIGNED);
+	is_signed = !!(field->flags & TEP_FIELD_IS_SIGNED);
 	if (should_be_signed && !is_signed) {
 		pr_debug("%s: \"%s\" signedness(%d) is wrong, should be %d\n",
 			 evsel->name, name, is_signed, should_be_signed);

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-02-09 12:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 23:34 [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator Gustavo A. R. Silva
2019-01-23  8:33 ` Jiri Olsa
2019-01-23  8:40   ` Gustavo A. R. Silva
2019-01-28 19:29     ` Gustavo A. R. Silva
2019-01-29  9:01   ` Arnaldo Carvalho de Melo
2019-02-09 12:19 ` [tip:perf/urgent] perf tests " tip-bot for Gustavo A. R. Silva

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.