From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 22 Jan 2019 18:41:50 -0500 Subject: [U-Boot] [PATCH v3 3/7] dfu: Remove dependency on HUSH parser in SPL In-Reply-To: <20190122234333.47c499e9@jawa> References: <20190117194308.29644-1-afd@ti.com> <20190117194308.29644-4-afd@ti.com> <20190122234333.47c499e9@jawa> Message-ID: <20190122234150.GV28173@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jan 22, 2019 at 11:43:33PM +0100, Lukasz Majewski wrote: > On Thu, 17 Jan 2019 13:43:04 -0600 > "Andrew F. Davis" wrote: > > > CLI support with the HUSH parser is not currently SPL safe due to it's > > use of realloc. That function is not defined for SPLs that use > > SYS_MALLOC_SIMPLE. CLI support can be built in to SPL and some > > functions do work, but use of some like run_command() will cause > > build to fail. When no SPL code calls this function build works as > > the compiler removes this unreachable code so the unresolved symbols > > are ignored. > > > > If DFU support is enabled in SPL then MMU DFU support may get brought > > in also, this code does make a call to run_command() causing build to > > fail if the HUSH parser is not built-in. To break this odd and > > unneeded dependency chain we use CONFIG_IS_ENABLED where appropriate > > to prevent calls into HUSH code from SPL. This also removes our need > > to pull in the rather unrelated source file when SPL_DFU is defined. > > > > If I remember correctly the HUSH was _required_ by TI to be able to use > DFU in SPL (and that was a rationale to add it to SPL - which IMHO was > wrong from the outset). > > What has changed that it is not needed anymore? To be fair, it was probably me-at-TI rather than TI that said it was required. At the time it was enough of a PITA to try and handle all of the cases that the dfu cli command handled via API calls instead that at least in my opinion, it wasn't worth re-whacking everything else. Times have changed it seems :) -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: