From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3CF4C282C0 for ; Wed, 23 Jan 2019 08:34:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69E4C2183F for ; Wed, 23 Jan 2019 08:34:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="UmPX/A5a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbfAWIeF (ORCPT ); Wed, 23 Jan 2019 03:34:05 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:33018 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfAWIeE (ORCPT ); Wed, 23 Jan 2019 03:34:04 -0500 Received: by mail-wm1-f67.google.com with SMTP id r24so10383218wmh.0 for ; Wed, 23 Jan 2019 00:34:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mVrM5G5oFnIIZP+aMpD+2+CPhV5r1MHZ5F6RpxQ9ZmA=; b=UmPX/A5aArwamn5xKOEd/Y+76yAwuJhaGGXiEECimo8u9dXyxm7NAGtxRmy4iZrRTv 5MvT5NY9EHFALjcsWf+MqHQuWEXu/xs9H0Gz25Nzv+qQ2amlSOtUTGGKpyqHM+dR22AN 67/mkEoKuBc1kodCwN6TUkx2cY7Dqg5YxiaoyXFexPnHaHsYk1AuV+z1tH96vdkzwRkg P4vd0VKxk/nKFkivxaC/eFUtEZAnaWfvwOxPhAj2tA9jt3Q5PuVH4OvIgK8ZnpgWKj9P Xgu9B+npU0KMyKCG0/1b38e/xVCcp5kMf2yye0NweDytNr9cm2dpS2l8SZAXdSE9j1wp mCog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mVrM5G5oFnIIZP+aMpD+2+CPhV5r1MHZ5F6RpxQ9ZmA=; b=i+mN4JHgIdSCajtJT8sgBG4orDUwQg7Dir9cul3MjIKnWdexPvU4mn7eYyeGTACF/g BAEJiLkkfZgGoYLLGocl7uavgISybQi2lH1llvIs3d+4L6H4RAmY4gcJviyFYbr9ichy o33OtGQ8QjSK/+nh0wNK9Y7lGbqmXzrb7u3Bp+ixnCQMEDpFIh8mhOVAQ4Irjpi0utI0 lh9rHLWcixQWuTOjN8zCbMoBaynJg9JcJ+IsMwGniWfwdvoER6Y6JtVPrp6vzAWcyv/n Gzlnj/J/i+/koAMzPuV6Hjb643ce+WW+9kOTL38jhdoU83E6NGButrBnfkoaGdgq1vK9 9NMw== X-Gm-Message-State: AJcUukdNodEKJQo+UXAxflylvZjXOJ+fcm7Ies6loI48H73AXbJ408z4 9ZYDcJkydwSla72Kam+o76TKHw== X-Google-Smtp-Source: ALg8bN4oaBZQHWD/+CC9t2XghfnvZrs7ZmUCKBKgQ8Gecy4LiQnCAr6/CNr3KUPC/JyE+PI9RaVRIQ== X-Received: by 2002:a1c:7c3:: with SMTP id 186mr1796332wmh.41.1548232442892; Wed, 23 Jan 2019 00:34:02 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id u10sm81393031wrr.33.2019.01.23.00.34.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Jan 2019 00:34:02 -0800 (PST) Date: Wed, 23 Jan 2019 09:25:13 +0100 From: Jiri Pirko To: Vasundhara Volam Cc: davem@davemloft.net, michael.chan@broadcom.com, jiri@mellanox.com, jakub.kicinski@netronome.com, mkubecek@suse.cz, netdev@vger.kernel.org Subject: Re: [PATCH net-next v7 1/8] devlink: Add devlink_param for port register and unregister Message-ID: <20190123082513.GA2191@nanopsycho> References: <1547795385-12354-1-git-send-email-vasundhara-v.volam@broadcom.com> <1547795385-12354-2-git-send-email-vasundhara-v.volam@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547795385-12354-2-git-send-email-vasundhara-v.volam@broadcom.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Jan 18, 2019 at 08:09:38AM CET, vasundhara-v.volam@broadcom.com wrote: >Add functions to register and unregister for the driver supported >configuration parameters table per port. > >v2->v3: >- Add a helper __devlink_params_register() with common code used by > both devlink_params_register() and devlink_port_params_register(). > [...] >+ >+static int __devlink_params_register(struct devlink *devlink, >+ struct list_head *param_list, >+ const struct devlink_param *params, >+ size_t params_count) > { > const struct devlink_param *param = params; > int i; >@@ -4490,20 +4493,11 @@ int devlink_params_register(struct devlink *devlink, > > mutex_lock(&devlink->lock); > for (i = 0; i < params_count; i++, param++) { >- if (!param || !param->name || !param->supported_cmodes) { >- err = -EINVAL; >+ err = devlink_param_verify(param); >+ if (err) > goto rollback; >- } >- if (param->generic) { >- err = devlink_param_generic_verify(param); >- if (err) >- goto rollback; >- } else { >- err = devlink_param_driver_verify(param); >- if (err) >- goto rollback; >- } >- err = devlink_param_register_one(devlink, param); >+ >+ err = devlink_param_register_one(devlink, param_list, param); > if (err) > goto rollback; > } >@@ -4515,31 +4509,57 @@ int devlink_params_register(struct devlink *devlink, > if (!i) > goto unlock; > for (param--; i > 0; i--, param--) >- devlink_param_unregister_one(devlink, param); >+ devlink_param_unregister_one(devlink, param_list, param); > unlock: > mutex_unlock(&devlink->lock); > return err; > } >-EXPORT_SYMBOL_GPL(devlink_params_register); > > /** >- * devlink_params_unregister - unregister configuration parameters >+ * devlink_params_register - register configuration parameters >+ * > * @devlink: devlink >- * @params: configuration parameters to unregister >+ * @params: configuration parameters array > * @params_count: number of parameters provided >+ * >+ * Register the configuration parameters supported by the driver. > */ >-void devlink_params_unregister(struct devlink *devlink, >- const struct devlink_param *params, >- size_t params_count) >+int devlink_params_register(struct devlink *devlink, The order of the functions should be: __devlink_params_register __devlink_params_unregister devlink_params_register devlink_params_unregister devlink_port_params_register devlink_port_params_unregister Your order is a bit confusing. Other than that: Acked-by: Jiri Pirko [...]