From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FEF1C282C0 for ; Wed, 23 Jan 2019 11:53:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0691621019 for ; Wed, 23 Jan 2019 11:53:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Yy4cN5ZB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726122AbfAWLxn (ORCPT ); Wed, 23 Jan 2019 06:53:43 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50953 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725991AbfAWLxn (ORCPT ); Wed, 23 Jan 2019 06:53:43 -0500 Received: by mail-wm1-f68.google.com with SMTP id n190so1717644wmd.0 for ; Wed, 23 Jan 2019 03:53:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qvF9+LVpcgbfLMIXc6HlCF0sFC5MKHr8h2foDxSYKPw=; b=Yy4cN5ZBaza+mC9iZGcp2yNgQeq0n1cIza0qA7lEVzI79Ex6EVHSvBR+x+Zizd+vGu JihxORpA0ihUVO4J7n1wyLupIu5XiQN2xlUV3TDkPe1ZbLd7GO6rKUqBFBV3QlRNC+ug HKlNUPFQqh0Zxs0VklQCUIHwZKyjNyzwqOBLKnDhaEx0gn9xcgYNmBbg3ksgQzlMaiL1 ICPelD5dMYMmLXmVjtvd/FOE0caGaiSHRP0NVlKCbD4E5kVDHQG77hH9Sa9YTAJMk4Ef JB0cKxykfhfjPRNqLTb5TESCsocRCmfmxU3NMLICqKqNJwwipE5E/lmMOMgQ0eA8FsSY deKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qvF9+LVpcgbfLMIXc6HlCF0sFC5MKHr8h2foDxSYKPw=; b=d64M9nv2aHFPrq9+3AmVINEUx9tKoEM4xfn24RfbuK+gviW6mjzzDEXK1AMYjBIaE4 YuJHS1g3EdFi0o3WbIZRalPxYrzQNoO6is21RgE09omPt6oLD7LHa8luDDqdnupbofnz 7Ae01AGj/KoFcLsWTTeeHS6RJ2zE9dxjdnPL19ZA2XhSBcTyXaAUkmS2GsDvGVB+ol53 yUREdquDY5WHT1HFkz9ZdMdCYRVYTAVSZgUVqXRXpwTyINvAcgmdep6ye1d6B8MZFzRn RCIPbZAEDxac4jRJ4OpYwRbuvivygTz2oMRUkCypLOROpMNvO5UL6bC4/jhlR+cn/YO2 UgBA== X-Gm-Message-State: AJcUukeyx8axo3AI2QkvFTB70RMOUmcU2EjjQhD6Gioj949I5grpYQbq /MST5WBcYOYdLJdPDftjEnjGQw== X-Google-Smtp-Source: ALg8bN57wEVqBP9Ym8Vyiitx+J8k9bcP0xhhJTamus2ivOLFwSkDQd0+bd39oQ1XwYPLpG1fsb59iw== X-Received: by 2002:a1c:a8d2:: with SMTP id r201mr2343193wme.81.1548244420873; Wed, 23 Jan 2019 03:53:40 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id z14sm72502778wrm.48.2019.01.23.03.53.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Jan 2019 03:53:40 -0800 (PST) Date: Wed, 23 Jan 2019 12:44:52 +0100 From: Jiri Pirko To: Eran Ben Elisha Cc: netdev@vger.kernel.org, Jiri Pirko , "David S. Miller" , Saeed Mahameed , Moshe Shemesh Subject: Re: [PATCH net-next 0/7] Devlink health updates Message-ID: <20190123114452.GE2191@nanopsycho> References: <1548172644-30862-1-git-send-email-eranbe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548172644-30862-1-git-send-email-eranbe@mellanox.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Jan 22, 2019 at 04:57:17PM CET, eranbe@mellanox.com wrote: >This patchset fixes some comments that were received for the devlink >health series, mostly around the devlink health buffers API. > >It offers a new devlink<->driver API for passing health dump and diagnose info. >As part of this patchset, the new API is developed and integrated into the >devlink health and mlx5e TX reporter. >Also, added some helpers together with the new API, which reduce the code >required by the driver to fill dump and diagnose significantly. > >Eventually, it also deletes the old API. > >In addition, it includes some small fixes in the devlink and mlx5e TX reporter. We are (re-)defining UAPI here. You need to present some examples of devlink tool output, both in json and stdout. Again, much more convenient to be done for the whole patchset, not this "fixup-one" :/ > > >Eran Ben Elisha (7): > devlink: Add devlink msg API > net/mlx5e: Move driver to use devlink msg API > devlink: move devlink health reporter to use devlink msg API > devlink: Delete depracated health buffers API > devlink: Remove spaces around "=" in the logger print > devlink: Fix use-after-free at reporter destroy > net/mlx5e: Add RTNL lock to TX recover flow > > .../mellanox/mlx5/core/en/reporter_tx.c | 124 +--- > include/net/devlink.h | 79 +-- > include/trace/events/devlink.h | 2 +- > include/uapi/linux/devlink.h | 14 +- > net/core/devlink.c | 633 ++++++++---------- > 5 files changed, 342 insertions(+), 510 deletions(-) > >-- >2.17.1 >