From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D309C282C0 for ; Wed, 23 Jan 2019 12:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAC2C21019 for ; Wed, 23 Jan 2019 12:34:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727349AbfAWMe6 (ORCPT ); Wed, 23 Jan 2019 07:34:58 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:55036 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726108AbfAWMe6 (ORCPT ); Wed, 23 Jan 2019 07:34:58 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 4ECAC8C4A15CD25628B0; Wed, 23 Jan 2019 20:34:55 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.408.0; Wed, 23 Jan 2019 20:34:46 +0800 From: YueHaibing To: CC: , , YueHaibing Subject: [PATCH -next] usb: ftdi-elan: Fix if == else warnings in ftdi_elan_respond_engine Date: Wed, 23 Jan 2019 20:34:42 +0800 Message-ID: <20190123123442.5256-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ./drivers/usb/misc/ftdi-elan.c:972:10-12: WARNING: possible condition with no effect (if == else) ./drivers/usb/misc/ftdi-elan.c:983:9-11: WARNING: possible condition with no effect (if == else) ./drivers/usb/misc/ftdi-elan.c:2052:11-13: WARNING: possible condition with no effect (if == else) Signed-off-by: YueHaibing --- drivers/usb/misc/ftdi-elan.c | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c index 76c718a..257efac 100644 --- a/drivers/usb/misc/ftdi-elan.c +++ b/drivers/usb/misc/ftdi-elan.c @@ -915,7 +915,6 @@ static int ftdi_elan_respond_engine(struct usb_ftdi *ftdi) int bytes_read = 0; int retry_on_empty = 1; int retry_on_timeout = 3; - int empty_packets = 0; read:{ int packet_bytes = 0; int retval = usb_bulk_msg(ftdi->udev, @@ -960,31 +959,6 @@ read:{ dev_err(&ftdi->udev->dev, "error = %d with packet_bytes = %d with total %d bytes%s\n", retval, packet_bytes, bytes_read, diag); return retval; - } else if (packet_bytes == 2) { - unsigned char s0 = ftdi->bulk_in_buffer[0]; - unsigned char s1 = ftdi->bulk_in_buffer[1]; - empty_packets += 1; - if (s0 == 0x31 && s1 == 0x60) { - if (retry_on_empty-- > 0) { - goto more; - } else - return 0; - } else if (s0 == 0x31 && s1 == 0x00) { - if (retry_on_empty-- > 0) { - goto more; - } else - return 0; - } else { - if (retry_on_empty-- > 0) { - goto more; - } else - return 0; - } - } else if (packet_bytes == 1) { - if (retry_on_empty-- > 0) { - goto more; - } else - return 0; } else { if (retry_on_empty-- > 0) { goto more; -- 2.7.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] usb: ftdi-elan: Fix if == else warnings in ftdi_elan_respond_engine From: YueHaibing Message-Id: <20190123123442.5256-1-yuehaibing@huawei.com> Date: Wed, 23 Jan 2019 20:34:42 +0800 To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, YueHaibing List-ID: Li9kcml2ZXJzL3VzYi9taXNjL2Z0ZGktZWxhbi5jOjk3MjoxMC0xMjogV0FSTklORzogcG9zc2li bGUgY29uZGl0aW9uIHdpdGggbm8gZWZmZWN0IChpZiA9PSBlbHNlKQouL2RyaXZlcnMvdXNiL21p c2MvZnRkaS1lbGFuLmM6OTgzOjktMTE6IFdBUk5JTkc6IHBvc3NpYmxlIGNvbmRpdGlvbiB3aXRo IG5vIGVmZmVjdCAoaWYgPT0gZWxzZSkKLi9kcml2ZXJzL3VzYi9taXNjL2Z0ZGktZWxhbi5jOjIw NTI6MTEtMTM6IFdBUk5JTkc6IHBvc3NpYmxlIGNvbmRpdGlvbiB3aXRoIG5vIGVmZmVjdCAoaWYg PT0gZWxzZSkKClNpZ25lZC1vZmYtYnk6IFl1ZUhhaWJpbmcgPHl1ZWhhaWJpbmdAaHVhd2VpLmNv bT4KLS0tCiBkcml2ZXJzL3VzYi9taXNjL2Z0ZGktZWxhbi5jIHwgMjYgLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9kcml2ZXJzL3VzYi9taXNjL2Z0ZGktZWxhbi5jIGIvZHJpdmVycy91c2IvbWlzYy9mdGRpLWVs YW4uYwppbmRleCA3NmM3MThhLi4yNTdlZmFjIDEwMDY0NAotLS0gYS9kcml2ZXJzL3VzYi9taXNj L2Z0ZGktZWxhbi5jCisrKyBiL2RyaXZlcnMvdXNiL21pc2MvZnRkaS1lbGFuLmMKQEAgLTkxNSw3 ICs5MTUsNiBAQCBzdGF0aWMgaW50IGZ0ZGlfZWxhbl9yZXNwb25kX2VuZ2luZShzdHJ1Y3QgdXNi X2Z0ZGkgKmZ0ZGkpCiAJaW50IGJ5dGVzX3JlYWQgPSAwOwogCWludCByZXRyeV9vbl9lbXB0eSA9 IDE7CiAJaW50IHJldHJ5X29uX3RpbWVvdXQgPSAzOwotCWludCBlbXB0eV9wYWNrZXRzID0gMDsK IHJlYWQ6ewogCQlpbnQgcGFja2V0X2J5dGVzID0gMDsKIAkJaW50IHJldHZhbCA9IHVzYl9idWxr X21zZyhmdGRpLT51ZGV2LApAQCAtOTYwLDMxICs5NTksNiBAQCByZWFkOnsKIAkJCWRldl9lcnIo JmZ0ZGktPnVkZXYtPmRldiwgImVycm9yID0gJWQgd2l0aCBwYWNrZXRfYnl0ZXMgPSAlZCB3aXRo IHRvdGFsICVkIGJ5dGVzJXNcbiIsCiAJCQkJcmV0dmFsLCBwYWNrZXRfYnl0ZXMsIGJ5dGVzX3Jl YWQsIGRpYWcpOwogCQkJcmV0dXJuIHJldHZhbDsKLQkJfSBlbHNlIGlmIChwYWNrZXRfYnl0ZXMg PT0gMikgewotCQkJdW5zaWduZWQgY2hhciBzMCA9IGZ0ZGktPmJ1bGtfaW5fYnVmZmVyWzBdOwot CQkJdW5zaWduZWQgY2hhciBzMSA9IGZ0ZGktPmJ1bGtfaW5fYnVmZmVyWzFdOwotCQkJZW1wdHlf cGFja2V0cyArPSAxOwotCQkJaWYgKHMwID09IDB4MzEgJiYgczEgPT0gMHg2MCkgewotCQkJCWlm IChyZXRyeV9vbl9lbXB0eS0tID4gMCkgewotCQkJCQlnb3RvIG1vcmU7Ci0JCQkJfSBlbHNlCi0J CQkJCXJldHVybiAwOwotCQkJfSBlbHNlIGlmIChzMCA9PSAweDMxICYmIHMxID09IDB4MDApIHsK LQkJCQlpZiAocmV0cnlfb25fZW1wdHktLSA+IDApIHsKLQkJCQkJZ290byBtb3JlOwotCQkJCX0g ZWxzZQotCQkJCQlyZXR1cm4gMDsKLQkJCX0gZWxzZSB7Ci0JCQkJaWYgKHJldHJ5X29uX2VtcHR5 LS0gPiAwKSB7Ci0JCQkJCWdvdG8gbW9yZTsKLQkJCQl9IGVsc2UKLQkJCQkJcmV0dXJuIDA7Ci0J CQl9Ci0JCX0gZWxzZSBpZiAocGFja2V0X2J5dGVzID09IDEpIHsKLQkJCWlmIChyZXRyeV9vbl9l bXB0eS0tID4gMCkgewotCQkJCWdvdG8gbW9yZTsKLQkJCX0gZWxzZQotCQkJCXJldHVybiAwOwog CQl9IGVsc2UgewogCQkJaWYgKHJldHJ5X29uX2VtcHR5LS0gPiAwKSB7CiAJCQkJZ290byBtb3Jl Owo=