From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69B6C282C0 for ; Wed, 23 Jan 2019 12:43:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FB5C21726 for ; Wed, 23 Jan 2019 12:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548247404; bh=wHBsJU4bjtWqMdJOdz1Edqz0OWSmpWdQKeUkaOm4BZw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qWTAo+orQMl4bbUGTxrwNfTHFZx3tR3O1OdAJPSfdU0ihU0ZAAbpHEvSngFC0coFO bHrDCSsTwuQEHW8G8xobOIVgUpKfR71hXcF06vZ+iY67kDPly8xP60VKPJLnd7/KeJ LRcq1rLt7p4HLFgWA2xySfVx7UMnVHkNQ54fAtM4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727198AbfAWMnW (ORCPT ); Wed, 23 Jan 2019 07:43:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:34114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbfAWMnW (ORCPT ); Wed, 23 Jan 2019 07:43:22 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 359E320870; Wed, 23 Jan 2019 12:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548247401; bh=wHBsJU4bjtWqMdJOdz1Edqz0OWSmpWdQKeUkaOm4BZw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bMb36qufiJaXDIAk8JdWeSfXEgvzIgD7ObnCDrDo8ZdBnXm898oUQNqcTz8qSratr ySMt1s46FRttyOhHjy32vuiDutTCgh2UsrMdReUtZ7tITebUCJ1M6OgNmLuyHHFKL2 5hUjm+lGjKA3x5xlMrusdd/0pgW3LmYNfnZoWaVk= Date: Wed, 23 Jan 2019 13:43:19 +0100 From: Greg KH To: YueHaibing Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH -next] usb: ftdi-elan: Fix if == else warnings in ftdi_elan_respond_engine Message-ID: <20190123124319.GB19703@kroah.com> References: <20190123123442.5256-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190123123442.5256-1-yuehaibing@huawei.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 23, 2019 at 08:34:42PM +0800, YueHaibing wrote: > ./drivers/usb/misc/ftdi-elan.c:972:10-12: WARNING: possible condition with no effect (if == else) > ./drivers/usb/misc/ftdi-elan.c:983:9-11: WARNING: possible condition with no effect (if == else) > ./drivers/usb/misc/ftdi-elan.c:2052:11-13: WARNING: possible condition with no effect (if == else) > > Signed-off-by: YueHaibing You can not just provide the output of a tool as a changelog text, sorry. Please explain what those lines mean, and why you are making the change that you are. > --- > drivers/usb/misc/ftdi-elan.c | 26 -------------------------- > 1 file changed, 26 deletions(-) > > diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c > index 76c718a..257efac 100644 > --- a/drivers/usb/misc/ftdi-elan.c > +++ b/drivers/usb/misc/ftdi-elan.c > @@ -915,7 +915,6 @@ static int ftdi_elan_respond_engine(struct usb_ftdi *ftdi) > int bytes_read = 0; > int retry_on_empty = 1; > int retry_on_timeout = 3; > - int empty_packets = 0; > read:{ > int packet_bytes = 0; > int retval = usb_bulk_msg(ftdi->udev, > @@ -960,31 +959,6 @@ read:{ > dev_err(&ftdi->udev->dev, "error = %d with packet_bytes = %d with total %d bytes%s\n", > retval, packet_bytes, bytes_read, diag); > return retval; > - } else if (packet_bytes == 2) { > - unsigned char s0 = ftdi->bulk_in_buffer[0]; > - unsigned char s1 = ftdi->bulk_in_buffer[1]; > - empty_packets += 1; > - if (s0 == 0x31 && s1 == 0x60) { > - if (retry_on_empty-- > 0) { > - goto more; > - } else > - return 0; > - } else if (s0 == 0x31 && s1 == 0x00) { > - if (retry_on_empty-- > 0) { > - goto more; > - } else > - return 0; > - } else { > - if (retry_on_empty-- > 0) { > - goto more; > - } else > - return 0; > - } > - } else if (packet_bytes == 1) { > - if (retry_on_empty-- > 0) { > - goto more; > - } else > - return 0; Are you _sure_ that these lines are not needed and that the compiler is not really seeing them? As it doesn't look that way to me, what am I missing? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] usb: ftdi-elan: Fix if == else warnings in ftdi_elan_respond_engine From: Greg Kroah-Hartman Message-Id: <20190123124319.GB19703@kroah.com> Date: Wed, 23 Jan 2019 13:43:19 +0100 To: YueHaibing Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gV2VkLCBKYW4gMjMsIDIwMTkgYXQgMDg6MzQ6NDJQTSArMDgwMCwgWXVlSGFpYmluZyB3cm90 ZToKPiAuL2RyaXZlcnMvdXNiL21pc2MvZnRkaS1lbGFuLmM6OTcyOjEwLTEyOiBXQVJOSU5HOiBw b3NzaWJsZSBjb25kaXRpb24gd2l0aCBubyBlZmZlY3QgKGlmID09IGVsc2UpCj4gLi9kcml2ZXJz L3VzYi9taXNjL2Z0ZGktZWxhbi5jOjk4Mzo5LTExOiBXQVJOSU5HOiBwb3NzaWJsZSBjb25kaXRp b24gd2l0aCBubyBlZmZlY3QgKGlmID09IGVsc2UpCj4gLi9kcml2ZXJzL3VzYi9taXNjL2Z0ZGkt ZWxhbi5jOjIwNTI6MTEtMTM6IFdBUk5JTkc6IHBvc3NpYmxlIGNvbmRpdGlvbiB3aXRoIG5vIGVm ZmVjdCAoaWYgPT0gZWxzZSkKPiAKPiBTaWduZWQtb2ZmLWJ5OiBZdWVIYWliaW5nIDx5dWVoYWli aW5nQGh1YXdlaS5jb20+CgpZb3UgY2FuIG5vdCBqdXN0IHByb3ZpZGUgdGhlIG91dHB1dCBvZiBh IHRvb2wgYXMgYSBjaGFuZ2Vsb2cgdGV4dCwKc29ycnkuCgpQbGVhc2UgZXhwbGFpbiB3aGF0IHRo b3NlIGxpbmVzIG1lYW4sIGFuZCB3aHkgeW91IGFyZSBtYWtpbmcgdGhlIGNoYW5nZQp0aGF0IHlv dSBhcmUuCgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9taXNjL2Z0ZGktZWxhbi5jIHwgMjYgLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI2IGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9taXNjL2Z0ZGktZWxhbi5jIGIvZHJpdmVycy91 c2IvbWlzYy9mdGRpLWVsYW4uYwo+IGluZGV4IDc2YzcxOGEuLjI1N2VmYWMgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy91c2IvbWlzYy9mdGRpLWVsYW4uYwo+ICsrKyBiL2RyaXZlcnMvdXNiL21pc2Mv ZnRkaS1lbGFuLmMKPiBAQCAtOTE1LDcgKzkxNSw2IEBAIHN0YXRpYyBpbnQgZnRkaV9lbGFuX3Jl c3BvbmRfZW5naW5lKHN0cnVjdCB1c2JfZnRkaSAqZnRkaSkKPiAgCWludCBieXRlc19yZWFkID0g MDsKPiAgCWludCByZXRyeV9vbl9lbXB0eSA9IDE7Cj4gIAlpbnQgcmV0cnlfb25fdGltZW91dCA9 IDM7Cj4gLQlpbnQgZW1wdHlfcGFja2V0cyA9IDA7Cj4gIHJlYWQ6ewo+ICAJCWludCBwYWNrZXRf Ynl0ZXMgPSAwOwo+ICAJCWludCByZXR2YWwgPSB1c2JfYnVsa19tc2coZnRkaS0+dWRldiwKPiBA QCAtOTYwLDMxICs5NTksNiBAQCByZWFkOnsKPiAgCQkJZGV2X2VycigmZnRkaS0+dWRldi0+ZGV2 LCAiZXJyb3IgPSAlZCB3aXRoIHBhY2tldF9ieXRlcyA9ICVkIHdpdGggdG90YWwgJWQgYnl0ZXMl c1xuIiwKPiAgCQkJCXJldHZhbCwgcGFja2V0X2J5dGVzLCBieXRlc19yZWFkLCBkaWFnKTsKPiAg CQkJcmV0dXJuIHJldHZhbDsKPiAtCQl9IGVsc2UgaWYgKHBhY2tldF9ieXRlcyA9PSAyKSB7Cj4g LQkJCXVuc2lnbmVkIGNoYXIgczAgPSBmdGRpLT5idWxrX2luX2J1ZmZlclswXTsKPiAtCQkJdW5z aWduZWQgY2hhciBzMSA9IGZ0ZGktPmJ1bGtfaW5fYnVmZmVyWzFdOwo+IC0JCQllbXB0eV9wYWNr ZXRzICs9IDE7Cj4gLQkJCWlmIChzMCA9PSAweDMxICYmIHMxID09IDB4NjApIHsKPiAtCQkJCWlm IChyZXRyeV9vbl9lbXB0eS0tID4gMCkgewo+IC0JCQkJCWdvdG8gbW9yZTsKPiAtCQkJCX0gZWxz ZQo+IC0JCQkJCXJldHVybiAwOwo+IC0JCQl9IGVsc2UgaWYgKHMwID09IDB4MzEgJiYgczEgPT0g MHgwMCkgewo+IC0JCQkJaWYgKHJldHJ5X29uX2VtcHR5LS0gPiAwKSB7Cj4gLQkJCQkJZ290byBt b3JlOwo+IC0JCQkJfSBlbHNlCj4gLQkJCQkJcmV0dXJuIDA7Cj4gLQkJCX0gZWxzZSB7Cj4gLQkJ CQlpZiAocmV0cnlfb25fZW1wdHktLSA+IDApIHsKPiAtCQkJCQlnb3RvIG1vcmU7Cj4gLQkJCQl9 IGVsc2UKPiAtCQkJCQlyZXR1cm4gMDsKPiAtCQkJfQo+IC0JCX0gZWxzZSBpZiAocGFja2V0X2J5 dGVzID09IDEpIHsKPiAtCQkJaWYgKHJldHJ5X29uX2VtcHR5LS0gPiAwKSB7Cj4gLQkJCQlnb3Rv IG1vcmU7Cj4gLQkJCX0gZWxzZQo+IC0JCQkJcmV0dXJuIDA7CgpBcmUgeW91IF9zdXJlXyB0aGF0 IHRoZXNlIGxpbmVzIGFyZSBub3QgbmVlZGVkIGFuZCB0aGF0IHRoZSBjb21waWxlciBpcwpub3Qg cmVhbGx5IHNlZWluZyB0aGVtPyAgQXMgaXQgZG9lc24ndCBsb29rIHRoYXQgd2F5IHRvIG1lLCB3 aGF0IGFtIEkKbWlzc2luZz8KCnRoYW5rcywKCmdyZWcgay1oCg==