From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33664C282C0 for ; Wed, 23 Jan 2019 21:05:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECE4221855 for ; Wed, 23 Jan 2019 21:05:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QU3zyBwO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727111AbfAWVFP (ORCPT ); Wed, 23 Jan 2019 16:05:15 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:43310 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbfAWVFP (ORCPT ); Wed, 23 Jan 2019 16:05:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QAcwJDIczfcTbYciawt98dnN4SQ0fVkI3u1oBZsQGn4=; b=QU3zyBwOOlXzLkYQjt5N9R8AA 8x7gqj54OzkZ2U9PEbEJfoX3tcF83NC+aaNYaf7he/yNImdd5P3s1biXQSuEBQLIz15BpWvh4GhSc imQ6NuE67J79grTnn9M2wdHx8lFQyH8ZfK9TdWOivceKfGGkqgRPr0VKqWZ7DpN7/lifNuns0H/nQ agthHjar08qEWisB12g//WWkaxl9cYlFpqcMmVg2/yUZ79dfDT8HCdWu8CU4LDqbDxd5mEa2VHt33 q6Us9Rbi6kvvNQADfCJnS7YEbeDSqJFVqHCLpNdGY3O/m4SHe411oDdM1CZn+NpmFAeA2L1egPLE4 6nQ7ZheBA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmPht-00082z-8q; Wed, 23 Jan 2019 21:05:09 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8C3CE20F51B1C; Wed, 23 Jan 2019 22:05:07 +0100 (CET) Date: Wed, 23 Jan 2019 22:05:07 +0100 From: Peter Zijlstra To: Mathieu Poirier Cc: acme@kernel.org, gregkh@linuxfoundation.org, mingo@redhat.com, tglx@linutronix.de, alexander.shishkin@linux.intel.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, will.deacon@arm.com, mark.rutland@arm.com, jolsa@redhat.com, namhyung@kernel.org, adrian.hunter@intel.com, ast@kernel.org, hpa@zytor.com, suzuki.poulose@arm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/7] coresight: Use event attributes for sink selection Message-ID: <20190123210507.GA17767@hirez.programming.kicks-ass.net> References: <20190115230742.13730-1-mathieu.poirier@linaro.org> <20190115230742.13730-4-mathieu.poirier@linaro.org> <20190123210333.GZ27931@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190123210333.GZ27931@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 23, 2019 at 10:03:33PM +0100, Peter Zijlstra wrote: > On Tue, Jan 15, 2019 at 04:07:38PM -0700, Mathieu Poirier wrote: > > + /* First get the selected sink from user space. */ > > + sink = coresight_get_sink_by_id(event->attr.config2); > > (I know there's a new version out, I'll go look there shortly) > > should this patch not also have something like: > > PMU_FORMAT_ATTR(sinkid, "config2:0-63"); n/m, I see it's already there. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 23 Jan 2019 22:05:07 +0100 From: Peter Zijlstra Subject: Re: [PATCH 3/7] coresight: Use event attributes for sink selection Message-ID: <20190123210507.GA17767@hirez.programming.kicks-ass.net> References: <20190115230742.13730-1-mathieu.poirier@linaro.org> <20190115230742.13730-4-mathieu.poirier@linaro.org> <20190123210333.GZ27931@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190123210333.GZ27931@hirez.programming.kicks-ass.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org List-Archive: To: Mathieu Poirier Cc: mark.rutland@arm.com, linux-s390@vger.kernel.org, suzuki.poulose@arm.com, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, heiko.carstens@de.ibm.com, adrian.hunter@intel.com, acme@kernel.org, ast@kernel.org, mingo@redhat.com, will.deacon@arm.com, hpa@zytor.com, schwidefsky@de.ibm.com, namhyung@kernel.org, tglx@linutronix.de, jolsa@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-ID: On Wed, Jan 23, 2019 at 10:03:33PM +0100, Peter Zijlstra wrote: > On Tue, Jan 15, 2019 at 04:07:38PM -0700, Mathieu Poirier wrote: > > + /* First get the selected sink from user space. */ > > + sink = coresight_get_sink_by_id(event->attr.config2); > > (I know there's a new version out, I'll go look there shortly) > > should this patch not also have something like: > > PMU_FORMAT_ATTR(sinkid, "config2:0-63"); n/m, I see it's already there. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel