From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A1C5C282C0 for ; Fri, 25 Jan 2019 06:08:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9548218B0 for ; Fri, 25 Jan 2019 06:08:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726968AbfAYGIs (ORCPT ); Fri, 25 Jan 2019 01:08:48 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38122 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbfAYGIs (ORCPT ); Fri, 25 Jan 2019 01:08:48 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6DD8214398931; Thu, 24 Jan 2019 22:08:47 -0800 (PST) Date: Thu, 24 Jan 2019 22:08:46 -0800 (PST) Message-Id: <20190124.220846.372838862694196119.davem@davemloft.net> To: jiri@resnulli.us Cc: eranbe@mellanox.com, netdev@vger.kernel.org, jiri@mellanox.com, saeedm@mellanox.com, moshe@mellanox.com Subject: Re: [PATCH net-next 0/7] Devlink health updates From: David Miller In-Reply-To: <20190122165821.GC2121@nanopsycho> References: <1548172644-30862-1-git-send-email-eranbe@mellanox.com> <20190122165821.GC2121@nanopsycho> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Jan 2019 22:08:47 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Date: Tue, 22 Jan 2019 17:58:21 +0100 > Tue, Jan 22, 2019 at 04:57:17PM CET, eranbe@mellanox.com wrote: >>This patchset fixes some comments that were received for the devlink >>health series, mostly around the devlink health buffers API. >> >>It offers a new devlink<->driver API for passing health dump and diagnose info. >>As part of this patchset, the new API is developed and integrated into the >>devlink health and mlx5e TX reporter. >>Also, added some helpers together with the new API, which reduce the code >>required by the driver to fill dump and diagnose significantly. >> >>Eventually, it also deletes the old API. >> >>In addition, it includes some small fixes in the devlink and mlx5e TX reporter. > > Okay, just leaving, going to review this tomorrow. I would much rather > review the patchset from the beginning, not this incremental patchset. > It changes a lot of things, deprecating api what was just introduced. > Review nightmare :/ > > Could we do revert, repost? For my health sakes :) Eran are you ok with the revert? I'll do it once I have Eran's confirmation.