From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF51C282C5 for ; Thu, 24 Jan 2019 08:10:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B021218A3 for ; Thu, 24 Jan 2019 08:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548317430; bh=mVuhrQqk7Q0zWlxIFBTAwmH57rC+LNUGq0bYNV+P8nY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Q178CWSN4DtfqQH9D7vRjxFpq32RAf1XfVZgY+8ZWGsUw3U+WE/Ndqj1vQnHM+uZo z8kmI+M1KeAIYbf/qfWi5Bvd5PhCYFTEyDX9Igd77eFzwkyWdjpTn2h8dqrXk3BySD sIsa9GReJUvdpAZRyY0CUdzrPhQIaPKh+Qq8naRM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727409AbfAXIK2 (ORCPT ); Thu, 24 Jan 2019 03:10:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:54386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbfAXIK2 (ORCPT ); Thu, 24 Jan 2019 03:10:28 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8738621872; Thu, 24 Jan 2019 08:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548317427; bh=mVuhrQqk7Q0zWlxIFBTAwmH57rC+LNUGq0bYNV+P8nY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZEkD/omuTC/6WRsTLYnibk+sJ8XC+aSzvbF+D1UtelBBhWFwJCz4p3BgG898PP/WK EQqKpEKsH1ZCIh3xFKyM4r1WaPA8pegt/aOxYMcbdJRPPz7va8v2Z7lHYQ/DD8I6Zc TL6esem5HPhSos0hjBMX2YhzVQlPCdBuq/WP6cMI= Date: Thu, 24 Jan 2019 09:10:24 +0100 From: Greg KH To: Kees Cook Cc: Jani Nikula , Edwin Zimmerman , dev@openvswitch.org, Ard Biesheuvel , Network Development , intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, LKML , Maling list - DRI developers , Linux-MM , linux-security-module , Kernel Hardening , intel-wired-lan@lists.osuosl.org, "linux-fsdevel@vger.kernel.org" , xen-devel , Laura Abbott , linux-kbuild , Alexander Popov Subject: Re: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches Message-ID: <20190124081024.GA1108@kroah.com> References: <20190123110349.35882-1-keescook@chromium.org> <20190123110349.35882-2-keescook@chromium.org> <20190123115829.GA31385@kroah.com> <874l9z31c5.fsf@intel.com> <000001d4b32a$845e06e0$8d1a14a0$@211mainstreet.net> <87va2f1int.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 24, 2019 at 07:55:51AM +1300, Kees Cook wrote: > On Thu, Jan 24, 2019 at 4:44 AM Jani Nikula wrote: > > > > On Wed, 23 Jan 2019, Edwin Zimmerman wrote: > > > On Wed, 23 Jan 2019, Jani Nikula wrote: > > >> On Wed, 23 Jan 2019, Greg KH wrote: > > >> > On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: > > >> >> Variables declared in a switch statement before any case statements > > >> >> cannot be initialized, so move all instances out of the switches. > > >> >> After this, future always-initialized stack variables will work > > >> >> and not throw warnings like this: > > >> >> > > >> >> fs/fcntl.c: In function ‘send_sigio_to_task’: > > >> >> fs/fcntl.c:738:13: warning: statement will never be executed [-Wswitch-unreachable] > > >> >> siginfo_t si; > > >> >> ^~ > > >> > > > >> > That's a pain, so this means we can't have any new variables in { } > > >> > scope except for at the top of a function? > > Just in case this wasn't clear: no, it's just the switch statement > before the first "case". I cannot imagine how bad it would be if we > couldn't have block-scoped variables! Heh. :) Sorry, it was not clear at first glance. So no more objection from me for this change. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:54386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbfAXIK2 (ORCPT ); Thu, 24 Jan 2019 03:10:28 -0500 Date: Thu, 24 Jan 2019 09:10:24 +0100 From: Greg KH Subject: Re: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches Message-ID: <20190124081024.GA1108@kroah.com> References: <20190123110349.35882-1-keescook@chromium.org> <20190123110349.35882-2-keescook@chromium.org> <20190123115829.GA31385@kroah.com> <874l9z31c5.fsf@intel.com> <000001d4b32a$845e06e0$8d1a14a0$@211mainstreet.net> <87va2f1int.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Kees Cook Cc: Jani Nikula , Edwin Zimmerman , dev@openvswitch.org, Ard Biesheuvel , Network Development , intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, LKML , Maling list - DRI developers , Linux-MM , linux-security-module , Kernel Hardening , intel-wired-lan@lists.osuosl.org, "linux-fsdevel@vger.kernel.org" , xen-devel , Laura Abbott , linux-kbuild , Alexander Popov On Thu, Jan 24, 2019 at 07:55:51AM +1300, Kees Cook wrote: > On Thu, Jan 24, 2019 at 4:44 AM Jani Nikula wrote: > > > > On Wed, 23 Jan 2019, Edwin Zimmerman wrote: > > > On Wed, 23 Jan 2019, Jani Nikula wrote: > > >> On Wed, 23 Jan 2019, Greg KH wrote: > > >> > On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: > > >> >> Variables declared in a switch statement before any case statements > > >> >> cannot be initialized, so move all instances out of the switches. > > >> >> After this, future always-initialized stack variables will work > > >> >> and not throw warnings like this: > > >> >> > > >> >> fs/fcntl.c: In function ‘send_sigio_to_task’: > > >> >> fs/fcntl.c:738:13: warning: statement will never be executed [-Wswitch-unreachable] > > >> >> siginfo_t si; > > >> >> ^~ > > >> > > > >> > That's a pain, so this means we can't have any new variables in { } > > >> > scope except for at the top of a function? > > Just in case this wasn't clear: no, it's just the switch statement > before the first "case". I cannot imagine how bad it would be if we > couldn't have block-scoped variables! Heh. :) Sorry, it was not clear at first glance. So no more objection from me for this change. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/3] treewide: Lift switch variables out of switches From: Greg Kroah-Hartman Message-Id: <20190124081024.GA1108@kroah.com> Date: Thu, 24 Jan 2019 09:10:24 +0100 To: Kees Cook Cc: Jani Nikula , Edwin Zimmerman , dev@openvswitch.org, Ard Biesheuvel , Network Development , intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, LKML , Maling list - DRI developers , Linux-MM , linux-security-module , Kernel Hardening , intel-wired-lan@lists.osuosl.org, "linux-fsdevel@vger.kernel.org" , xen-devel , Laura Abbott , linux-kbuild , Alexander Popov List-ID: T24gVGh1LCBKYW4gMjQsIDIwMTkgYXQgMDc6NTU6NTFBTSArMTMwMCwgS2VlcyBDb29rIHdyb3Rl Ogo+IE9uIFRodSwgSmFuIDI0LCAyMDE5IGF0IDQ6NDQgQU0gSmFuaSBOaWt1bGEgPGphbmkubmlr dWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gV2VkLCAyMyBKYW4gMjAxOSwg RWR3aW4gWmltbWVybWFuIDxlZHdpbkAyMTFtYWluc3RyZWV0Lm5ldD4gd3JvdGU6Cj4gPiA+IE9u IFdlZCwgMjMgSmFuIDIwMTksIEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5j b20+IHdyb3RlOgo+ID4gPj4gT24gV2VkLCAyMyBKYW4gMjAxOSwgR3JlZyBLSCA8Z3JlZ2toQGxp bnV4Zm91bmRhdGlvbi5vcmc+IHdyb3RlOgo+ID4gPj4gPiBPbiBXZWQsIEphbiAyMywgMjAxOSBh dCAwMzowMzo0N0FNIC0wODAwLCBLZWVzIENvb2sgd3JvdGU6Cj4gPiA+PiA+PiBWYXJpYWJsZXMg ZGVjbGFyZWQgaW4gYSBzd2l0Y2ggc3RhdGVtZW50IGJlZm9yZSBhbnkgY2FzZSBzdGF0ZW1lbnRz Cj4gPiA+PiA+PiBjYW5ub3QgYmUgaW5pdGlhbGl6ZWQsIHNvIG1vdmUgYWxsIGluc3RhbmNlcyBv dXQgb2YgdGhlIHN3aXRjaGVzLgo+ID4gPj4gPj4gQWZ0ZXIgdGhpcywgZnV0dXJlIGFsd2F5cy1p bml0aWFsaXplZCBzdGFjayB2YXJpYWJsZXMgd2lsbCB3b3JrCj4gPiA+PiA+PiBhbmQgbm90IHRo cm93IHdhcm5pbmdzIGxpa2UgdGhpczoKPiA+ID4+ID4+Cj4gPiA+PiA+PiBmcy9mY250bC5jOiBJ biBmdW5jdGlvbiDigJhzZW5kX3NpZ2lvX3RvX3Rhc2vigJk6Cj4gPiA+PiA+PiBmcy9mY250bC5j OjczODoxMzogd2FybmluZzogc3RhdGVtZW50IHdpbGwgbmV2ZXIgYmUgZXhlY3V0ZWQgWy1Xc3dp dGNoLXVucmVhY2hhYmxlXQo+ID4gPj4gPj4gICAgc2lnaW5mb190IHNpOwo+ID4gPj4gPj4gICAg ICAgICAgICAgIF5+Cj4gPiA+PiA+Cj4gPiA+PiA+IFRoYXQncyBhIHBhaW4sIHNvIHRoaXMgbWVh bnMgd2UgY2FuJ3QgaGF2ZSBhbnkgbmV3IHZhcmlhYmxlcyBpbiB7IH0KPiA+ID4+ID4gc2NvcGUg ZXhjZXB0IGZvciBhdCB0aGUgdG9wIG9mIGEgZnVuY3Rpb24/Cj4gCj4gSnVzdCBpbiBjYXNlIHRo aXMgd2Fzbid0IGNsZWFyOiBubywgaXQncyBqdXN0IHRoZSBzd2l0Y2ggc3RhdGVtZW50Cj4gYmVm b3JlIHRoZSBmaXJzdCAiY2FzZSIuIEkgY2Fubm90IGltYWdpbmUgaG93IGJhZCBpdCB3b3VsZCBi ZSBpZiB3ZQo+IGNvdWxkbid0IGhhdmUgYmxvY2stc2NvcGVkIHZhcmlhYmxlcyEgSGVoLiA6KQoK U29ycnksIGl0IHdhcyBub3QgY2xlYXIgYXQgZmlyc3QgZ2xhbmNlLiAgU28gbm8gbW9yZSBvYmpl Y3Rpb24gZnJvbSBtZQpmb3IgdGhpcyBjaGFuZ2UuCgpncmVnIGstaAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Thu, 24 Jan 2019 09:10:24 +0100 Subject: [Intel-wired-lan] [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches In-Reply-To: References: <20190123110349.35882-1-keescook@chromium.org> <20190123110349.35882-2-keescook@chromium.org> <20190123115829.GA31385@kroah.com> <874l9z31c5.fsf@intel.com> <000001d4b32a$845e06e0$8d1a14a0$@211mainstreet.net> <87va2f1int.fsf@intel.com> Message-ID: <20190124081024.GA1108@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Thu, Jan 24, 2019 at 07:55:51AM +1300, Kees Cook wrote: > On Thu, Jan 24, 2019 at 4:44 AM Jani Nikula wrote: > > > > On Wed, 23 Jan 2019, Edwin Zimmerman wrote: > > > On Wed, 23 Jan 2019, Jani Nikula wrote: > > >> On Wed, 23 Jan 2019, Greg KH wrote: > > >> > On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: > > >> >> Variables declared in a switch statement before any case statements > > >> >> cannot be initialized, so move all instances out of the switches. > > >> >> After this, future always-initialized stack variables will work > > >> >> and not throw warnings like this: > > >> >> > > >> >> fs/fcntl.c: In function ?send_sigio_to_task?: > > >> >> fs/fcntl.c:738:13: warning: statement will never be executed [-Wswitch-unreachable] > > >> >> siginfo_t si; > > >> >> ^~ > > >> > > > >> > That's a pain, so this means we can't have any new variables in { } > > >> > scope except for at the top of a function? > > Just in case this wasn't clear: no, it's just the switch statement > before the first "case". I cannot imagine how bad it would be if we > couldn't have block-scoped variables! Heh. :) Sorry, it was not clear at first glance. So no more objection from me for this change. greg k-h