From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC6DC282C3 for ; Thu, 24 Jan 2019 17:58:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6ACC2184C for ; Thu, 24 Jan 2019 17:58:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="IqbSIc5X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728952AbfAXR6O (ORCPT ); Thu, 24 Jan 2019 12:58:14 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37424 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbfAXR6N (ORCPT ); Thu, 24 Jan 2019 12:58:13 -0500 Received: by mail-pf1-f193.google.com with SMTP id y126so3364133pfb.4 for ; Thu, 24 Jan 2019 09:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UgKgBH2JVUi6gOvsZblmkwUAuP/sSEuCNVyEfyghO6s=; b=IqbSIc5XgVHHOIv5erHSDMFjnRPYddcKBgDJOFn5EHROrRciNQA+2OJwzAakBXWy2b YucLfT1eltg5oo3kQDIYJdOdtS9UPhD5V5Tp3il5uEUXMXeU8EBFzSEcW7IUBUC7G0Sy /sL2nbmFGf6TxsOnotERcrjqNYWzJzIybuBNs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UgKgBH2JVUi6gOvsZblmkwUAuP/sSEuCNVyEfyghO6s=; b=dTJK47ceHx6fhhGGVOdM2BJyLxJhsT+tqdelKiQjLxK3XDeeR/JLr6a9iEv+V5/x8o KcZ2j8O6A+DJ3e5hM1DCuK9YZKNbWBOWWN9a3Om7j07zr1D7VWhia0wOxP4d5odjbU3Q EUJ+F9SEwhq0S69ITrGdckbZvxTn/6Tu76tAYMgPJxBY506R4HRxaspVJkDHscfq4r6p 2o5FkMLAc3s2ecgt91XuCoGiQCbU3C2vL3mz/YxHGcgxVW04bV26efHedtIpgeDSSYve BYOah0XDuVW2+CjvAvZ+W35hVSjyAl7MI+RRYmr/PdiR5Csi35uvmqZSoWWmuhlmsa94 mDgA== X-Gm-Message-State: AJcUukeB/aNZp1M/35eJrxVbSLnZXjKbEnQFxW1BF+4zw8bpSSjkPDG+ KffSluD3xvZ59Lycin/8RDXjcA== X-Google-Smtp-Source: ALg8bN7nHSlmZFpQvuviUvZnz1P7PKT9UKC0lWaBRroiQOjVtYiTV1Fzj/lQCQf/atjl6fgUKgQoLw== X-Received: by 2002:a65:40c5:: with SMTP id u5mr257887pgp.46.1548352693228; Thu, 24 Jan 2019 09:58:13 -0800 (PST) Received: from localhost.localdomain ([115.97.179.75]) by smtp.gmail.com with ESMTPSA id 4sm28684826pfq.10.2019.01.24.09.58.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 09:58:12 -0800 (PST) From: Jagan Teki To: Steve Longerbeam , Mauro Carvalho Chehab , Maxime Ripard , Jacopo Mondi Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Trimarchi , linux-amarula@amarulasolutions.com, Jagan Teki Subject: [PATCH] media: ov5640: Fix set 15fps regression Date: Thu, 24 Jan 2019 23:28:01 +0530 Message-Id: <20190124175801.28018-1-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ov5640_try_frame_interval operation updates the FPS as per user input based on default ov5640_frame_rate, OV5640_30_FPS which is failed to update when user trigger 15fps. So, initialize the default ov5640_frame_rate to OV5640_15_FPS so-that it can satisfy to update all fps. Fixes: 5a3ad937bc78 ("media: ov5640: Make the return rate type more explicit") Signed-off-by: Jagan Teki --- drivers/media/i2c/ov5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 5a909abd0a2d..4081c29176c6 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -2072,7 +2072,7 @@ static int ov5640_try_frame_interval(struct ov5640_dev *sensor, u32 width, u32 height) { const struct ov5640_mode_info *mode; - enum ov5640_frame_rate rate = OV5640_30_FPS; + enum ov5640_frame_rate rate = OV5640_15_FPS; int minfps, maxfps, best_fps, fps; int i; -- 2.18.0.321.gffc6fa0e3