From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 447A8C282C3 for ; Thu, 24 Jan 2019 19:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14401218FC for ; Thu, 24 Jan 2019 19:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548357997; bh=w18d+WM3RXR+jQ1cA5pbXZLHOAzdwS0XZDFwUVYpxqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LzhxJeK1a0oOzIRafn/uIbdB1gKiEYWfxx4JivqLE3MFfO3qVswjPNcxDeFBbMMhc B3DfveER+5/XAfO7m4NbZbovblwoJ2S4RUfvP3GdBKhImLR/yfVW1AsX9bO36Xy86F BwbrEZwx7E/FciQuWDdU8nlufILMpnfl6CWdzZyo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730586AbfAXT0f (ORCPT ); Thu, 24 Jan 2019 14:26:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:52630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729813AbfAXT0d (ORCPT ); Thu, 24 Jan 2019 14:26:33 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 971DB218FC; Thu, 24 Jan 2019 19:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548357993; bh=w18d+WM3RXR+jQ1cA5pbXZLHOAzdwS0XZDFwUVYpxqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=as/3E7sILn4BkHGz7r6LZ8mmxMvhrRmsRN/JxtiT+rqjMiiY3BW/MsdmoucG1ROVY o7H84RgwhM7XycXF66E5vYWwNA4AeNECR6GLOFR2DzKqLc8PoRYdKwk8ZUPjWmA0V5 Tj1dDm50K+7ixy2B285DqqmrUw3MS4KQBsyy1PZ4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+6664500f0f18f07a5c0e@syzkaller.appspotmail.com, Stephen Smalley , Paul Moore Subject: [PATCH 4.4 060/104] selinux: fix GPF on invalid policy Date: Thu, 24 Jan 2019 20:19:49 +0100 Message-Id: <20190124190202.303918263@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124190154.968308875@linuxfoundation.org> References: <20190124190154.968308875@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stephen Smalley commit 5b0e7310a2a33c06edc7eb81ffc521af9b2c5610 upstream. levdatum->level can be NULL if we encounter an error while loading the policy during sens_read prior to initializing it. Make sure sens_destroy handles that case correctly. Reported-by: syzbot+6664500f0f18f07a5c0e@syzkaller.appspotmail.com Signed-off-by: Stephen Smalley Signed-off-by: Paul Moore Signed-off-by: Greg Kroah-Hartman --- security/selinux/ss/policydb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/security/selinux/ss/policydb.c +++ b/security/selinux/ss/policydb.c @@ -726,7 +726,8 @@ static int sens_destroy(void *key, void kfree(key); if (datum) { levdatum = datum; - ebitmap_destroy(&levdatum->level->cat); + if (levdatum->level) + ebitmap_destroy(&levdatum->level->cat); kfree(levdatum->level); } kfree(datum);