From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 128E8C282C3 for ; Thu, 24 Jan 2019 19:31:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBA74218FC for ; Thu, 24 Jan 2019 19:31:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="IgoiWyWM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731615AbfAXTb1 (ORCPT ); Thu, 24 Jan 2019 14:31:27 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:54738 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731597AbfAXTbX (ORCPT ); Thu, 24 Jan 2019 14:31:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wEAJ0kFkLus8SWjR86jUtVjtKnmPH3980ycmU88r2Ds=; b=IgoiWyWMTM174bu5+1unMsUGD4 qOfNqq2j37cY393mqOpMU6FQIUD4MlD+4H6kCvlXf+ozry7r43zAsKhAATvb+jHxPU9mVE105+DZT zHyJ/ZJX3snxtZ1FOE2kAUwrAtVERPS/XEIW9nJ/l+ooKqhlS866RncR8IdI3wGWa7Zk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gmkic-0003lE-4h; Thu, 24 Jan 2019 20:31:18 +0100 Date: Thu, 24 Jan 2019 20:31:18 +0100 From: Andrew Lunn To: Florian Fainelli Cc: Marek Behun , netdev@vger.kernel.org, David Miller Subject: Re: [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X Message-ID: <20190124193118.GA13964@lunn.ch> References: <20190124154309.24987-1-marek.behun@nic.cz> <20190124161147.GG482@lunn.ch> <20190124172916.66e15b29@nic.cz> <20190124164805.GJ482@lunn.ch> <20190124190451.40af3127@nic.cz> <20190124181159.GL482@lunn.ch> <20190124202403.0d15ec6f@nic.cz> <3c81ed78-4f0e-37b1-710c-6d96c3e76577@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c81ed78-4f0e-37b1-710c-6d96c3e76577@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > The function dsa_port_fixed_link_register_of creates this phy device, > > adjusts the link and then calls put_device(&phydev->mdio.dev); > > Does this mean that the phy device is immediately destroyed? > > Yes, we should actually migrate that code over to PHYLINK, because in > PHYLINK the fixed links don't require creating a phy_device instance. > This is something that has a potential of breaking a lot of people, so I > have not really started doing it just yet :) Hi Florian It also has the advantage of being easier to implement. In order to support 2.5G, i think we need C45 support, etc in the simulator. Avoiding that would be nice. Andrew