All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Carlo Caione <ccaione@baylibre.com>
Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: at803x: Use helpers to access MMD PHY registers
Date: Fri, 25 Jan 2019 16:00:13 +0100	[thread overview]
Message-ID: <20190125150013.GG12962@lunn.ch> (raw)
In-Reply-To: <20190125123510.20511-1-ccaione@baylibre.com>

On Fri, Jan 25, 2019 at 12:35:10PM +0000, Carlo Caione wrote:
> Libphy provides a standard set of helpers to access the MMD PHY
> registers. Use those instead of relying on custom driver-specific
> functions.

Hi Carlo

Maybe deja vu, but i thought a similar patch went by recently?

Anyway,

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

> 
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
>  drivers/net/phy/at803x.c | 16 +++-------------
>  1 file changed, 3 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index f9432d053a22..23ba76f8d950 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -39,9 +39,6 @@
>  #define AT803X_LOC_MAC_ADDR_0_15_OFFSET		0x804C
>  #define AT803X_LOC_MAC_ADDR_16_31_OFFSET	0x804B
>  #define AT803X_LOC_MAC_ADDR_32_47_OFFSET	0x804A
> -#define AT803X_MMD_ACCESS_CONTROL		0x0D
> -#define AT803X_MMD_ACCESS_CONTROL_DATA		0x0E
> -#define AT803X_FUNC_DATA			0x4003
>  #define AT803X_REG_CHIP_CONFIG			0x1f
>  #define AT803X_BT_BX_REG_SEL			0x8000
>  
> @@ -168,16 +165,9 @@ static int at803x_set_wol(struct phy_device *phydev,
>  		if (!is_valid_ether_addr(mac))
>  			return -EINVAL;
>  
> -		for (i = 0; i < 3; i++) {
> -			phy_write(phydev, AT803X_MMD_ACCESS_CONTROL,
> -				  AT803X_DEVICE_ADDR);
> -			phy_write(phydev, AT803X_MMD_ACCESS_CONTROL_DATA,
> -				  offsets[i]);
> -			phy_write(phydev, AT803X_MMD_ACCESS_CONTROL,
> -				  AT803X_FUNC_DATA);
> -			phy_write(phydev, AT803X_MMD_ACCESS_CONTROL_DATA,
> -				  mac[(i * 2) + 1] | (mac[(i * 2)] << 8));
> -		}
> +		for (i = 0; i < 3; i++)
> +			phy_write_mmd(phydev, AT803X_DEVICE_ADDR, offsets[i],
> +				      mac[(i * 2) + 1] | (mac[(i * 2)] << 8));
>  
>  		value = phy_read(phydev, AT803X_INTR_ENABLE);
>  		value |= AT803X_INTR_ENABLE_WOL;
> -- 
> 2.19.1
> 

  reply	other threads:[~2019-01-25 15:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 12:35 [PATCH] net: phy: at803x: Use helpers to access MMD PHY registers Carlo Caione
2019-01-25 15:00 ` Andrew Lunn [this message]
2019-01-25 15:03   ` Carlo Caione
2019-01-25 18:11   ` Heiner Kallweit
2019-01-25 18:51     ` Andrew Lunn
2019-01-25 18:40 ` Florian Fainelli
2019-01-27 21:27 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190125150013.GG12962@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=ccaione@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.