From: Michal Hocko <mhocko@kernel.org> To: Tejun Heo <tj@kernel.org> Cc: Johannes Weiner <hannes@cmpxchg.org>, Chris Down <chris@chrisdown.name>, Andrew Morton <akpm@linux-foundation.org>, Roman Gushchin <guro@fb.com>, Dennis Zhou <dennis@kernel.org>, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH 2/2] mm: Consider subtrees in memory.events Date: Fri, 25 Jan 2019 18:37:13 +0100 [thread overview] Message-ID: <20190125173713.GD20411@dhcp22.suse.cz> (raw) In-Reply-To: <20190125165152.GK50184@devbig004.ftw2.facebook.com> On Fri 25-01-19 08:51:52, Tejun Heo wrote: [...] > > I do see your point about consistency. But it is also important to > > consider the usability of this interface. As already mentioned, catching > > an oom event at a level where the oom doesn't happen and having hard > > time to identify that place without races is a not a straightforward API > > to use. So it might be really the case that the api is actually usable > > for its purpose. > > What if a user wants to monitor any ooms in the subtree tho, which is > a valid use case? How is that information useful without know which memcg the oom applies to? > If local event monitoring is useful and it can be, > let's add separate events which are clearly identifiable to be local. > Right now, it's confusing like hell. From a backward compatible POV it should be a new interface added. Please note that I understand that this might be confusing with the rest of the cgroup APIs but considering that this is the first time somebody is actually complaining and the interface is "production ready" for more than three years I am not really sure the situation is all that bad. -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Tejun Heo <tj@kernel.org> Cc: Johannes Weiner <hannes@cmpxchg.org>, Chris Down <chris@chrisdown.name>, Andrew Morton <akpm@linux-foundation.org>, Roman Gushchin <guro@fb.com>, Dennis Zhou <dennis@kernel.org>, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH 2/2] mm: Consider subtrees in memory.events Date: Fri, 25 Jan 2019 18:37:13 +0100 [thread overview] Message-ID: <20190125173713.GD20411@dhcp22.suse.cz> (raw) In-Reply-To: <20190125165152.GK50184@devbig004.ftw2.facebook.com> On Fri 25-01-19 08:51:52, Tejun Heo wrote: [...] > > I do see your point about consistency. But it is also important to > > consider the usability of this interface. As already mentioned, catching > > an oom event at a level where the oom doesn't happen and having hard > > time to identify that place without races is a not a straightforward API > > to use. So it might be really the case that the api is actually usable > > for its purpose. > > What if a user wants to monitor any ooms in the subtree tho, which is > a valid use case? How is that information useful without know which memcg the oom applies to? > If local event monitoring is useful and it can be, > let's add separate events which are clearly identifiable to be local. > Right now, it's confusing like hell. >From a backward compatible POV it should be a new interface added. Please note that I understand that this might be confusing with the rest of the cgroup APIs but considering that this is the first time somebody is actually complaining and the interface is "production ready" for more than three years I am not really sure the situation is all that bad. -- Michal Hocko SUSE Labs
next prev parent reply other threads:[~2019-01-25 17:37 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-23 22:31 [PATCH 2/2] mm: Consider subtrees in memory.events Chris Down 2019-01-24 0:24 ` Roman Gushchin 2019-01-24 1:03 ` Chris Down 2019-01-24 8:22 ` Michal Hocko 2019-01-24 15:21 ` Tejun Heo 2019-01-24 15:51 ` Michal Hocko 2019-01-24 16:00 ` Johannes Weiner 2019-01-24 17:01 ` Michal Hocko 2019-01-24 18:23 ` Johannes Weiner 2019-01-25 8:42 ` Michal Hocko 2019-01-25 16:51 ` Tejun Heo 2019-01-25 17:37 ` Michal Hocko [this message] 2019-01-25 17:37 ` Michal Hocko 2019-01-25 18:28 ` Tejun Heo 2019-01-28 12:51 ` Michal Hocko 2019-01-28 14:28 ` Tejun Heo 2019-01-28 14:52 ` Michal Hocko 2019-01-28 14:54 ` Tejun Heo 2019-01-28 15:18 ` Michal Hocko 2019-01-28 15:41 ` Tejun Heo 2019-01-28 17:05 ` Michal Hocko 2019-01-28 17:49 ` Tejun Heo 2019-01-29 14:43 ` Michal Hocko 2019-01-29 14:52 ` Tejun Heo 2019-01-30 16:50 ` Michal Hocko 2019-01-30 17:06 ` Tejun Heo 2019-01-30 17:41 ` Michal Hocko 2019-01-30 17:52 ` Tejun Heo 2019-01-30 18:16 ` Michal Hocko 2019-01-30 19:11 ` Shakeel Butt 2019-01-30 19:11 ` Shakeel Butt 2019-01-30 19:27 ` Johannes Weiner 2019-01-30 19:30 ` Johannes Weiner 2019-01-30 19:37 ` Shakeel Butt 2019-01-30 19:37 ` Shakeel Butt 2019-01-30 19:23 ` Johannes Weiner 2019-01-30 20:05 ` Michal Hocko 2019-01-30 21:31 ` Johannes Weiner 2019-01-31 8:58 ` Michal Hocko 2019-01-31 16:22 ` Johannes Weiner 2019-02-01 10:27 ` Michal Hocko 2019-02-01 16:34 ` Johannes Weiner 2019-01-28 15:59 ` Shakeel Butt 2019-01-28 15:59 ` Shakeel Butt 2019-01-28 16:05 ` Tejun Heo 2019-01-28 16:08 ` Shakeel Butt 2019-01-28 16:08 ` Shakeel Butt 2019-01-28 16:12 ` Tejun Heo 2019-01-28 14:30 ` Tejun Heo 2019-02-08 22:43 ` [PATCH v2 1/2] mm: Rename ambiguously named memory.stat counters and functions Chris Down 2019-02-08 22:44 ` [PATCH v2 2/2] mm: Consider subtrees in memory.events Chris Down 2019-02-11 19:01 ` Johannes Weiner 2019-02-11 18:55 ` [PATCH v2 1/2] mm: Rename ambiguously named memory.stat counters and functions Johannes Weiner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190125173713.GD20411@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=chris@chrisdown.name \ --cc=dennis@kernel.org \ --cc=guro@fb.com \ --cc=hannes@cmpxchg.org \ --cc=kernel-team@fb.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.