From: Mark Brown <broonie@kernel.org>
To: Shunli Wang <shunli.wang@mediatek.com>
Cc: alsa-devel@alsa-project.org, garlic.tseng@mediatek.com,
linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com,
kaichieh.chuang@mediatek.com
Subject: Re: [PATCH 3/6] ASoC: mediatek: mt6358: add codec driver
Date: Fri, 25 Jan 2019 18:10:22 +0000 [thread overview]
Message-ID: <20190125181022.GB6939@sirena.org.uk> (raw)
In-Reply-To: <1548139153-18783-4-git-send-email-shunli.wang@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 988 bytes --]
On Tue, Jan 22, 2019 at 02:39:10PM +0800, Shunli Wang wrote:
> add the mt6358 codec driver.
>
> Signed-off-by: Shunli Wang <shunli.wang@mediatek.com>
> ---
> sound/soc/codecs/Kconfig | 7 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/mt6358.c | 2336 +++++++++++++++++++++++++++++++++++++++++++++
> sound/soc/codecs/mt6358.h | 2314 ++++++++++++++++++++++++++++++++++++++++++++
This looks fine but it breaks the build for me:
Applying patch #10781741 using 'git am -3 -s'
Description: [3/6] ASoC: mediatek: mt6358: add codec driver
Applying: ASoC: mediatek: mt6358: add codec driver
scripts/kconfig/conf --oldconfig Kconfig
sound/soc/codecs/Kconfig:1348: syntax error
sound/soc/codecs/Kconfig:1347:warning: ignoring unsupported character '.'
sound/soc/codecs/Kconfig:1347: unknown statement "external"
make[1]: *** [scripts/kconfig/Makefile:69: oldconfig] Error 1
It's the indentation of the help text. I've fixed it up but please take
care!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2019-01-25 18:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 6:39 [PATCH 0/6] ASoC: Mediatek: Add support for MT8183 AoC and MT6358 Codec Shunli Wang
[not found] ` <1548139153-18783-1-git-send-email-shunli.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-01-22 6:39 ` [PATCH 1/6] ASoC: mediatek: mt8183: add platform driver Shunli Wang
[not found] ` <1548139153-18783-2-git-send-email-shunli.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-01-25 18:11 ` Applied "ASoC: mediatek: mt8183: add platform driver" to the asoc tree Mark Brown
2019-01-22 6:39 ` [PATCH 2/6] ASoC: mediatek: mt8183: add audio afe document Shunli Wang
2019-01-25 18:11 ` Applied "ASoC: mediatek: mt8183: add audio afe document" to the asoc tree Mark Brown
2019-01-22 6:39 ` [PATCH 3/6] ASoC: mediatek: mt6358: add codec driver Shunli Wang
2019-01-25 18:10 ` Mark Brown [this message]
2019-01-25 18:11 ` Applied "ASoC: mediatek: mt6358: add codec driver" to the asoc tree Mark Brown
2019-01-22 6:39 ` [PATCH 4/6] ASoC: mediatek: mt6358: add codec document Shunli Wang
2019-01-25 18:11 ` Applied "ASoC: mediatek: mt6358: add codec document" to the asoc tree Mark Brown
2019-01-22 6:39 ` [PATCH 5/6] ASoC: mediatek: mt8183: add mt8183-mt6358 machine driver Shunli Wang
2019-01-25 18:10 ` Mark Brown
2019-01-22 6:39 ` [PATCH 6/6] ASoC: mediatek: add document for mt8183-mt6358 Shunli Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125181022.GB6939@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=garlic.tseng@mediatek.com \
--cc=kaichieh.chuang@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=shunli.wang@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.