From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sat, 26 Jan 2019 22:52:44 -0500 Subject: [U-Boot] [U-Boot, v3, 3/7] dfu: Remove dependency on HUSH parser in SPL In-Reply-To: <20190117194308.29644-4-afd@ti.com> References: <20190117194308.29644-4-afd@ti.com> Message-ID: <20190127035244.GW6906@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Jan 17, 2019 at 01:43:04PM -0600, Andrew F. Davis wrote: > CLI support with the HUSH parser is not currently SPL safe due to it's > use of realloc. That function is not defined for SPLs that use > SYS_MALLOC_SIMPLE. CLI support can be built in to SPL and some functions > do work, but use of some like run_command() will cause build to fail. > When no SPL code calls this function build works as the compiler removes > this unreachable code so the unresolved symbols are ignored. > > If DFU support is enabled in SPL then MMU DFU support may get brought in > also, this code does make a call to run_command() causing build to fail > if the HUSH parser is not built-in. To break this odd and unneeded > dependency chain we use CONFIG_IS_ENABLED where appropriate to prevent > calls into HUSH code from SPL. This also removes our need to pull in the > rather unrelated source file when SPL_DFU is defined. > > Signed-off-by: Andrew F. Davis > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: