From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1go6mk-0005oY-7t for mharc-grub-devel@gnu.org; Mon, 28 Jan 2019 08:17:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go6mi-0005oS-0k for grub-devel@gnu.org; Mon, 28 Jan 2019 08:17:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1go6mh-0006sy-95 for grub-devel@gnu.org; Mon, 28 Jan 2019 08:17:08 -0500 Received: from dibed.net-space.pl ([84.10.22.86]:51733) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.71) (envelope-from ) id 1go6mg-0006qD-VD for grub-devel@gnu.org; Mon, 28 Jan 2019 08:17:07 -0500 Received: from router-fw.i.net-space.pl ([192.168.52.1]:52708 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S904307AbfA1NRE (ORCPT ); Mon, 28 Jan 2019 14:17:04 +0100 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Mon, 28 Jan 2019 14:17:01 +0100 From: Daniel Kiper To: Alexander Graf Cc: grub-devel@gnu.org, Leif Lindholm , Peter Jones , Jon Masters Subject: Re: [PATCH v5 3/3] mkimage: Clarify file alignment in efi case Message-ID: <20190128131701.egpdwdcbqloxvqnb@tomti.i.net-space.pl> References: <20190125114516.12127-1-agraf@suse.de> <20190125114516.12127-4-agraf@suse.de> <20190128122707.vzd3mztl5rjj4jfl@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 84.10.22.86 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2019 13:17:08 -0000 On Mon, Jan 28, 2019 at 01:34:20PM +0100, Alexander Graf wrote: > On 28.01.19 13:27, Daniel Kiper wrote: > > On Fri, Jan 25, 2019 at 12:45:16PM +0100, Alexander Graf wrote: > >> There are a few spots in the PE generation code for EFI binaries that uses > >> the section alignment rather than file alignment, even though the alignment > >> is really only file bound. > >> > >> Replace those cases with the file alignment constant instead. > >> > >> Reported-by: Daniel Kiper > >> Signed-off-by: Alexander Graf > > > > Great! However, this patch misses changes for EFI32_HEADER_SIZE > > and EFI64_HEADER_SIZE macros. In general I think about > > s/GRUB_PE32_SECTION_ALIGNMENT/GRUB_PE32_FILE_ALIGNMENT/ > > I have asked about that in my earlier emails too... > > If you have such a strong opinion, why don't you just simply do the > patch and I review it? The way we're bouncing this back and forth is > unproductive for both of us. Yes, I agree. However, I am asking you about that for quite long time. You do not object and you do not take into account this comment. So, I assume that you are missing it. If you would do one of above things earlier I would not chase you up until now. Just please read my comments more carefully. Daniel