From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v6,3/3] dmaengine: imx-sdma: fix consistent dma test failures From: Angus Ainslie Message-Id: <20190128160323.28170-4-angus@akkea.ca> Date: Mon, 28 Jan 2019 09:03:23 -0700 To: angus@akkea.ca Cc: angus.ainslie@puri.sm, Vinod Koul , dmaengine@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lucas Stach , Daniel Baluta List-ID: V2l0aG91dCB0aGUgY29weSBiZWluZyBhbGlnbmVkIHNkbWExIGZhaWxzIH4xMCUgb2YgdGhlIHRp bWUKClNpZ25lZC1vZmYtYnk6IEFuZ3VzIEFpbnNsaWUgKFB1cmlzbSkgPGFuZ3VzQGFra2VhLmNh PgotLS0KIGRyaXZlcnMvZG1hL2lteC1zZG1hLmMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hL2lteC1zZG1hLmMgYi9kcml2ZXJz L2RtYS9pbXgtc2RtYS5jCmluZGV4IGQyZmFlNTNiZTY4OS4uZTdkNGQ4MzkwODEzIDEwMDY0NAot LS0gYS9kcml2ZXJzL2RtYS9pbXgtc2RtYS5jCisrKyBiL2RyaXZlcnMvZG1hL2lteC1zZG1hLmMK QEAgLTIxMTQsNiArMjExNCw3IEBAIHN0YXRpYyBpbnQgc2RtYV9wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQogCXNkbWEtPmRtYV9kZXZpY2UuZGV2aWNlX3ByZXBfZG1hX21lbWNw eSA9IHNkbWFfcHJlcF9tZW1jcHk7CiAJc2RtYS0+ZG1hX2RldmljZS5kZXZpY2VfaXNzdWVfcGVu ZGluZyA9IHNkbWFfaXNzdWVfcGVuZGluZzsKIAlzZG1hLT5kbWFfZGV2aWNlLmRldi0+ZG1hX3Bh cm1zID0gJnNkbWEtPmRtYV9wYXJtczsKKwlzZG1hLT5kbWFfZGV2aWNlLmNvcHlfYWxpZ24gPSAy OwogCWRtYV9zZXRfbWF4X3NlZ19zaXplKHNkbWEtPmRtYV9kZXZpY2UuZGV2LCBTRE1BX0JEX01B WF9DTlQpOwogCiAJcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgc2RtYSk7Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97609C282C8 for ; Mon, 28 Jan 2019 16:04:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65ED720989 for ; Mon, 28 Jan 2019 16:04:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="Pdi7HOeD"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="Pdi7HOeD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730905AbfA1QEn (ORCPT ); Mon, 28 Jan 2019 11:04:43 -0500 Received: from node.akkea.ca ([192.155.83.177]:48278 "EHLO node.akkea.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731622AbfA1QEi (ORCPT ); Mon, 28 Jan 2019 11:04:38 -0500 Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 82E3F4E2050; Mon, 28 Jan 2019 16:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1548691477; bh=J7FDNerUzu+c8gJAAHJsx3fEWW03ezFNiCXJWstnopY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Pdi7HOeDTff0lwHqmDv1isZrwh2zGigGDmTauCj+xzTkALue16Pxxeunh0YUSuTab pgPSxtacyzurFT+C2ErrLyFqSE8PD1PN1QKDEqLHoDQa/UdX8v8OjAqRbl7oP/KJpo tN/EQIa5rpfNj5XI3LVlYS31B0kC99NhH/48wGUs= X-Virus-Scanned: Debian amavisd-new at mail.akkea.ca Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YivCd2jEN6LV; Mon, 28 Jan 2019 16:04:37 +0000 (UTC) Received: from localhost.localdomain (198-48-167-13.cpe.pppoe.ca [198.48.167.13]) by node.akkea.ca (Postfix) with ESMTPSA id 953DB4E204D; Mon, 28 Jan 2019 16:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1548691477; bh=J7FDNerUzu+c8gJAAHJsx3fEWW03ezFNiCXJWstnopY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Pdi7HOeDTff0lwHqmDv1isZrwh2zGigGDmTauCj+xzTkALue16Pxxeunh0YUSuTab pgPSxtacyzurFT+C2ErrLyFqSE8PD1PN1QKDEqLHoDQa/UdX8v8OjAqRbl7oP/KJpo tN/EQIa5rpfNj5XI3LVlYS31B0kC99NhH/48wGUs= From: "Angus Ainslie (Purism)" To: angus@akkea.ca Cc: angus.ainslie@puri.sm, Vinod Koul , dmaengine@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lucas Stach , Daniel Baluta Subject: [PATCH v6 3/3] dmaengine: imx-sdma: fix consistent dma test failures Date: Mon, 28 Jan 2019 09:03:23 -0700 Message-Id: <20190128160323.28170-4-angus@akkea.ca> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190128160323.28170-1-angus@akkea.ca> References: <20190120023150.17138-1-angus@akkea.ca> <20190128160323.28170-1-angus@akkea.ca> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Without the copy being aligned sdma1 fails ~10% of the time Signed-off-by: Angus Ainslie (Purism) --- drivers/dma/imx-sdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index d2fae53be689..e7d4d8390813 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -2114,6 +2114,7 @@ static int sdma_probe(struct platform_device *pdev) sdma->dma_device.device_prep_dma_memcpy = sdma_prep_memcpy; sdma->dma_device.device_issue_pending = sdma_issue_pending; sdma->dma_device.dev->dma_parms = &sdma->dma_parms; + sdma->dma_device.copy_align = 2; dma_set_max_seg_size(sdma->dma_device.dev, SDMA_BD_MAX_CNT); platform_set_drvdata(pdev, sdma); -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D18C282CF for ; Mon, 28 Jan 2019 16:05:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00A952175B for ; Mon, 28 Jan 2019 16:05:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QiqTKjyg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="Pdi7HOeD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="Pdi7HOeD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00A952175B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=DSYEClYSP7d7MKCdA78V6Y7GkGyDhUH6JSQDA9cuT80=; b=QiqTKjygq/KKprnCV6a99jyS5f iHUEzr8g+ZBpP5Gpa1UGw5RrEPz5dXyXVy6E4Gi8WDlo4AAcqLhx8gfF6MBDW29nVBrG6PevHfz/Z JRqs2xQwxYskTU4bArjy1xFHzb38BY2L0dMpUnDF81cWbV1LTF/azozrbM/fr/Aze2dw/+heoWNLv xoxmkOZbzX5rDMtXEsYmUnW31C5UbWF7qgrduBacxzOz1hDNbIJH6aBT4I9eNl7gRr5Zg15IUv3U2 SOrGwgMw+2G95hihQE5iyfrEou2TRrZ5HeXNOfgHPppprgyBhiVWBCSquATsq+C8CJnQcWXnXLSFA QxQWJu/Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1go9Pf-0005R0-Pi; Mon, 28 Jan 2019 16:05:31 +0000 Received: from node.akkea.ca ([192.155.83.177]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1go9On-0003b0-Kv for linux-arm-kernel@lists.infradead.org; Mon, 28 Jan 2019 16:04:39 +0000 Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 82E3F4E2050; Mon, 28 Jan 2019 16:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1548691477; bh=J7FDNerUzu+c8gJAAHJsx3fEWW03ezFNiCXJWstnopY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Pdi7HOeDTff0lwHqmDv1isZrwh2zGigGDmTauCj+xzTkALue16Pxxeunh0YUSuTab pgPSxtacyzurFT+C2ErrLyFqSE8PD1PN1QKDEqLHoDQa/UdX8v8OjAqRbl7oP/KJpo tN/EQIa5rpfNj5XI3LVlYS31B0kC99NhH/48wGUs= X-Virus-Scanned: Debian amavisd-new at mail.akkea.ca Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YivCd2jEN6LV; Mon, 28 Jan 2019 16:04:37 +0000 (UTC) Received: from localhost.localdomain (198-48-167-13.cpe.pppoe.ca [198.48.167.13]) by node.akkea.ca (Postfix) with ESMTPSA id 953DB4E204D; Mon, 28 Jan 2019 16:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1548691477; bh=J7FDNerUzu+c8gJAAHJsx3fEWW03ezFNiCXJWstnopY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Pdi7HOeDTff0lwHqmDv1isZrwh2zGigGDmTauCj+xzTkALue16Pxxeunh0YUSuTab pgPSxtacyzurFT+C2ErrLyFqSE8PD1PN1QKDEqLHoDQa/UdX8v8OjAqRbl7oP/KJpo tN/EQIa5rpfNj5XI3LVlYS31B0kC99NhH/48wGUs= From: "Angus Ainslie (Purism)" To: angus@akkea.ca Subject: [PATCH v6 3/3] dmaengine: imx-sdma: fix consistent dma test failures Date: Mon, 28 Jan 2019 09:03:23 -0700 Message-Id: <20190128160323.28170-4-angus@akkea.ca> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190128160323.28170-1-angus@akkea.ca> References: <20190120023150.17138-1-angus@akkea.ca> <20190128160323.28170-1-angus@akkea.ca> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190128_080437_834215_0EB488CC X-CRM114-Status: UNSURE ( 8.28 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Baluta , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Vinod Koul , NXP Linux Team , Pengutronix Kernel Team , angus.ainslie@puri.sm, linux-arm-kernel@lists.infradead.org, Lucas Stach MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Without the copy being aligned sdma1 fails ~10% of the time Signed-off-by: Angus Ainslie (Purism) --- drivers/dma/imx-sdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index d2fae53be689..e7d4d8390813 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -2114,6 +2114,7 @@ static int sdma_probe(struct platform_device *pdev) sdma->dma_device.device_prep_dma_memcpy = sdma_prep_memcpy; sdma->dma_device.device_issue_pending = sdma_issue_pending; sdma->dma_device.dev->dma_parms = &sdma->dma_parms; + sdma->dma_device.copy_align = 2; dma_set_max_seg_size(sdma->dma_device.dev, SDMA_BD_MAX_CNT); platform_set_drvdata(pdev, sdma); -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel