All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: davem@davemloft.net
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org,
	jiri@resnulli.us, f.fainelli@gmail.com, andrew@lunn.ch,
	mkubecek@suse.cz, dsahern@gmail.com, simon.horman@netronome.com,
	jesse.brandeburg@intel.com, maciejromanfijalkowski@gmail.com,
	vasundhara-v.volam@broadcom.com, michael.chan@broadcom.com,
	shalomt@mellanox.com, idosch@mellanox.com,
	Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [RFC 02/14] nfp: constify parameter to nfp_port_from_netdev()
Date: Mon, 28 Jan 2019 15:44:55 -0800	[thread overview]
Message-ID: <20190128234507.32028-3-jakub.kicinski@netronome.com> (raw)
In-Reply-To: <20190128234507.32028-1-jakub.kicinski@netronome.com>

Make nfp_port_from_netdev() take a const parameter, otherwise
it can't be used with upcoming stats code.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
---
 drivers/net/ethernet/netronome/nfp/nfp_net.h      | 2 +-
 drivers/net/ethernet/netronome/nfp/nfp_net_repr.h | 2 +-
 drivers/net/ethernet/netronome/nfp/nfp_port.c     | 2 +-
 drivers/net/ethernet/netronome/nfp/nfp_port.h     | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net.h b/drivers/net/ethernet/netronome/nfp/nfp_net.h
index 320ec3900a32..93de25b39bc1 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net.h
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net.h
@@ -839,7 +839,7 @@ extern const char nfp_driver_version[];
 
 extern const struct net_device_ops nfp_net_netdev_ops;
 
-static inline bool nfp_netdev_is_nfp_net(struct net_device *netdev)
+static inline bool nfp_netdev_is_nfp_net(const struct net_device *netdev)
 {
 	return netdev->netdev_ops == &nfp_net_netdev_ops;
 }
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h
index e0f13dfe1f39..7f2df74c2a7f 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h
@@ -75,7 +75,7 @@ enum nfp_repr_type {
 
 extern const struct net_device_ops nfp_repr_netdev_ops;
 
-static inline bool nfp_netdev_is_nfp_repr(struct net_device *netdev)
+static inline bool nfp_netdev_is_nfp_repr(const struct net_device *netdev)
 {
 	return netdev->netdev_ops == &nfp_repr_netdev_ops;
 }
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_port.c b/drivers/net/ethernet/netronome/nfp/nfp_port.c
index 86bc149ca231..81a23f9bdfc0 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_port.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_port.c
@@ -12,7 +12,7 @@
 #include "nfp_net.h"
 #include "nfp_port.h"
 
-struct nfp_port *nfp_port_from_netdev(struct net_device *netdev)
+struct nfp_port *nfp_port_from_netdev(const struct net_device *netdev)
 {
 	if (nfp_netdev_is_nfp_net(netdev)) {
 		struct nfp_net *nn = netdev_priv(netdev);
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_port.h b/drivers/net/ethernet/netronome/nfp/nfp_port.h
index b2479a2a49e5..24de9250d564 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_port.h
+++ b/drivers/net/ethernet/netronome/nfp/nfp_port.h
@@ -105,7 +105,7 @@ static inline bool nfp_port_is_vnic(const struct nfp_port *port)
 int
 nfp_port_set_features(struct net_device *netdev, netdev_features_t features);
 
-struct nfp_port *nfp_port_from_netdev(struct net_device *netdev);
+struct nfp_port *nfp_port_from_netdev(const struct net_device *netdev);
 struct nfp_port *
 nfp_port_from_id(struct nfp_pf *pf, enum nfp_port_type type, unsigned int id);
 struct nfp_eth_table_port *__nfp_port_get_eth_port(struct nfp_port *port);
-- 
2.19.2


  parent reply	other threads:[~2019-01-28 23:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28 23:44 [RFC 00/14] netlink/hierarchical stats Jakub Kicinski
2019-01-28 23:44 ` [RFC 01/14] nfp: remove unused structure Jakub Kicinski
2019-01-28 23:44 ` Jakub Kicinski [this message]
2019-01-28 23:44 ` [RFC 03/14] net: hstats: add basic/core functionality Jakub Kicinski
2019-01-30  4:18   ` David Ahern
2019-01-30 17:44     ` Jakub Kicinski
2019-01-30 22:33       ` David Ahern
2019-01-28 23:44 ` [RFC 04/14] net: hstats: allow hierarchies to be built Jakub Kicinski
2019-01-28 23:44 ` [RFC 05/14] nfp: very basic hstat support Jakub Kicinski
2019-01-28 23:44 ` [RFC 06/14] net: hstats: allow iterators Jakub Kicinski
2019-01-28 23:45 ` [RFC 07/14] net: hstats: help in iteration over directions Jakub Kicinski
2019-01-28 23:45 ` [RFC 08/14] nfp: hstats: make use of iteration for direction Jakub Kicinski
2019-01-28 23:45 ` [RFC 09/14] nfp: hstats: add driver and device per queue statistics Jakub Kicinski
2019-01-28 23:45 ` [RFC 10/14] net: hstats: add IEEE 802.3 and common IETF MIB/RMON stats Jakub Kicinski
2019-01-28 23:45 ` [RFC 11/14] nfp: hstats: add IEEE/RMON ethernet port/MAC stats Jakub Kicinski
2019-01-28 23:45 ` [RFC 12/14] net: hstats: add markers for partial groups Jakub Kicinski
2019-01-28 23:45 ` [RFC 13/14] nfp: hstats: add a partial group of per-8021Q prio stats Jakub Kicinski
2019-01-28 23:45 ` [RFC 14/14] Documentation: networking: describe new hstat API Jakub Kicinski
2019-01-30 22:14 ` [RFC 00/14] netlink/hierarchical stats Roopa Prabhu
2019-01-31  0:24   ` Jakub Kicinski
2019-01-31 16:16     ` Roopa Prabhu
2019-01-31 16:31       ` Roopa Prabhu
2019-01-31 19:30         ` Jakub Kicinski
2019-02-02 23:14           ` Roopa Prabhu
2019-02-06  4:45             ` Jakub Kicinski
2019-02-06 20:12 ` Florian Fainelli
2019-02-07 16:23   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190128234507.32028-3-jakub.kicinski@netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jiri@resnulli.us \
    --cc=maciejromanfijalkowski@gmail.com \
    --cc=michael.chan@broadcom.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=shalomt@mellanox.com \
    --cc=simon.horman@netronome.com \
    --cc=vasundhara-v.volam@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.