From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2 3/9] irq/irq_sim: provide irq_sim_fire_type()
Date: Tue, 29 Jan 2019 10:07:06 +0100 [thread overview]
Message-ID: <20190129090706.33wcxb6d2c64yx7c@pengutronix.de> (raw)
In-Reply-To: <20190129084411.30495-4-brgl@bgdev.pl>
Hello Bartosz,
On Tue, Jan 29, 2019 at 09:44:05AM +0100, Bartosz Golaszewski wrote:
> -void irq_sim_fire(struct irq_sim *sim, unsigned int offset)
> +void irq_sim_fire_type(struct irq_sim *sim,
> + unsigned int offset, unsigned int type)
> {
> struct irq_sim_irq_ctx *ctx = irq_sim_get_ctx(sim, offset);
>
> - if (ctx->enabled) {
> + /* Only care about relevant flags. */
> + type &= IRQ_TYPE_SENSE_MASK;
> +
> + if (ctx->enabled && (ctx->type & type)) {
> set_bit(offset, sim->work_ctx.pending);
> irq_work_queue(&sim->work_ctx.work);
> }
> }
> -EXPORT_SYMBOL_GPL(irq_sim_fire);
> +EXPORT_SYMBOL_GPL(irq_sim_fire_type);
This looks better than the previous variant. I wonder if it would be
still more sensible to have type only in the mockup driver. But I don't
have the complete picture here and it might be easier this way.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-01-29 9:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 8:44 [PATCH v2 0/9] gpio: mockup: improve the user-space testing interface Bartosz Golaszewski
2019-01-29 8:44 ` [PATCH v2 1/9] irq/irq_sim: don't share the irq_chip structure between simulators Bartosz Golaszewski
2019-02-11 22:28 ` Marc Zyngier
2019-02-12 8:29 ` Bartosz Golaszewski
2019-01-29 8:44 ` [PATCH v2 2/9] irq/irq_sim: use irq domain Bartosz Golaszewski
2019-02-11 22:26 ` Marc Zyngier
2019-02-12 8:30 ` Bartosz Golaszewski
2019-02-12 8:53 ` Marc Zyngier
2019-02-12 8:56 ` Bartosz Golaszewski
2019-01-29 8:44 ` [PATCH v2 3/9] irq/irq_sim: provide irq_sim_fire_type() Bartosz Golaszewski
2019-01-29 9:07 ` Uwe Kleine-König [this message]
2019-01-29 11:01 ` Bartosz Golaszewski
2019-01-29 12:55 ` Uwe Kleine-König
2019-02-01 11:02 ` Bartosz Golaszewski
2019-02-12 9:10 ` Marc Zyngier
2019-02-12 9:19 ` Bartosz Golaszewski
2019-02-12 10:06 ` Uwe Kleine-König
2019-02-12 10:15 ` Bartosz Golaszewski
2019-02-12 10:27 ` Marc Zyngier
2019-02-12 10:37 ` Bartosz Golaszewski
2019-02-12 10:52 ` Marc Zyngier
2019-02-12 11:05 ` Uwe Kleine-König
2019-02-12 11:09 ` Bartosz Golaszewski
2019-02-12 11:35 ` Marc Zyngier
2019-01-29 8:44 ` [PATCH v2 4/9] gpio: mockup: add locking Bartosz Golaszewski
2019-01-29 8:44 ` [PATCH v2 5/9] gpio: mockup: implement get_multiple() Bartosz Golaszewski
2019-01-29 8:44 ` [PATCH v2 6/9] gpio: mockup: don't create the debugfs link named after the label Bartosz Golaszewski
2019-01-29 8:44 ` [PATCH v2 7/9] gpio: mockup: change the type of 'offset' to unsigned int Bartosz Golaszewski
2019-01-29 8:44 ` [PATCH v2 8/9] gpio: mockup: change the signature of unlocked get/set helpers Bartosz Golaszewski
2019-01-29 8:44 ` [PATCH v2 9/9] gpio: mockup: rework debugfs interface Bartosz Golaszewski
2019-02-06 10:23 ` [PATCH v2 0/9] gpio: mockup: improve the user-space testing interface Bartosz Golaszewski
2019-02-11 22:33 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129090706.33wcxb6d2c64yx7c@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.