From: Peter Zijlstra <peterz@infradead.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: gregkh@linuxfoundation.org, tj@kernel.org, lizefan@huawei.com,
hannes@cmpxchg.org, axboe@kernel.dk, dennis@kernel.org,
dennisszhou@gmail.com, mingo@redhat.com,
akpm@linux-foundation.org, corbet@lwn.net,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v3 5/5] psi: introduce psi monitor
Date: Tue, 29 Jan 2019 13:38:44 +0100 [thread overview]
Message-ID: <20190129123843.GK28467@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190124211518.244221-6-surenb@google.com>
On Thu, Jan 24, 2019 at 01:15:18PM -0800, Suren Baghdasaryan wrote:
> + atomic_set(&group->polling, polling);
> + /*
> + * Memory barrier is needed to order group->polling
> + * write before times[] read in collect_percpu_times()
> + */
> + smp_mb__after_atomic();
That's broken, smp_mb__{before,after}_atomic() can only be used on
atomic RmW operations, something atomic_set() is _not_.
next prev parent reply other threads:[~2019-01-29 12:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 21:15 [PATCH v3 0/5] psi: pressure stall monitors v3 Suren Baghdasaryan
2019-01-24 21:15 ` [PATCH v3 1/5] fs: kernfs: add poll file operation Suren Baghdasaryan
2019-01-24 21:15 ` [PATCH v3 2/5] kernel: cgroup: " Suren Baghdasaryan
2019-01-24 21:15 ` [PATCH v3 3/5] psi: introduce state_mask to represent stalled psi states Suren Baghdasaryan
2019-01-28 21:22 ` Johannes Weiner
2019-01-24 21:15 ` [PATCH v3 4/5] psi: rename psi fields in preparation for psi trigger addition Suren Baghdasaryan
2019-01-28 21:23 ` Johannes Weiner
2019-01-24 21:15 ` [PATCH v3 5/5] psi: introduce psi monitor Suren Baghdasaryan
2019-01-28 21:26 ` Johannes Weiner
2019-01-28 23:53 ` Minchan Kim
2019-01-29 1:52 ` Suren Baghdasaryan
2019-01-29 1:52 ` Suren Baghdasaryan
2019-01-29 18:35 ` Johannes Weiner
2019-01-29 10:44 ` Peter Zijlstra
2019-01-29 18:05 ` Suren Baghdasaryan
2019-01-29 18:05 ` Suren Baghdasaryan
2019-01-29 12:38 ` Peter Zijlstra [this message]
2019-01-29 15:16 ` Peter Zijlstra
2019-01-29 18:25 ` Suren Baghdasaryan
2019-01-29 18:25 ` Suren Baghdasaryan
2019-01-29 18:18 ` Suren Baghdasaryan
2019-01-29 18:18 ` Suren Baghdasaryan
2019-01-29 18:31 ` Suren Baghdasaryan
2019-01-29 18:31 ` Suren Baghdasaryan
2019-01-29 19:08 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129123843.GK28467@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dennis@kernel.org \
--cc=dennisszhou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.