From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D08C169C4 for ; Tue, 29 Jan 2019 15:11:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F333C2175B for ; Tue, 29 Jan 2019 15:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728032AbfA2PLU (ORCPT ); Tue, 29 Jan 2019 10:11:20 -0500 Received: from mslow2.mail.gandi.net ([217.70.178.242]:45022 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbfA2PLT (ORCPT ); Tue, 29 Jan 2019 10:11:19 -0500 Received: from relay12.mail.gandi.net (unknown [217.70.178.232]) by mslow2.mail.gandi.net (Postfix) with ESMTP id F39913A69A0; Tue, 29 Jan 2019 15:54:11 +0100 (CET) Received: from localhost (aaubervilliers-681-1-27-226.w90-88.abo.wanadoo.fr [90.88.147.226]) (Authenticated sender: maxime.ripard@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 8B1FC200012; Tue, 29 Jan 2019 14:54:07 +0000 (UTC) Date: Tue, 29 Jan 2019 15:54:03 +0100 From: Maxime Ripard To: Jagan Teki Cc: Jagan Teki , David Airlie , Daniel Vetter , Chen-Yu Tsai , Michael Turquette , Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] Re: [PATCH v6 14/22] dt-bindings: sun6i-dsi: Add A64 DSI compatible (w/ A31 fallback) Message-ID: <20190129145402.d6athskmfydqodvn@flea> References: <20190124195900.22620-1-jagan@amarulasolutions.com> <20190124195900.22620-15-jagan@amarulasolutions.com> <20190125155236.agxwkxvyefmrbvym@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yiit6eh4xmxsxmgp" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yiit6eh4xmxsxmgp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 26, 2019 at 09:39:00PM +0530, Jagan Teki wrote: > On 25/01/19 9:22 PM, Maxime Ripard wrote: > > On Fri, Jan 25, 2019 at 01:28:52AM +0530, Jagan Teki wrote: > > > The MIPI DSI controller in Allwinner A64 is similar to A33. > > >=20 > > > But unlike A33, A64 doesn't have DSI_SCLK gating which eventually > > > set the mod clock rate for the controller. > > >=20 > > > So, use the DSI_DPHY gating for the similar purpose of mod clock > > > so-that the controller can operate properly. > > >=20 > > > Signed-off-by: Jagan Teki > > > Reviewed-by: Rob Herring > > > --- > > > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + > > > 1 file changed, 1 insertion(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-ds= i.txt b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > index 69e233e8fad1..dbda2e567760 100644 > > > --- a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > @@ -12,6 +12,7 @@ The DSI Encoder generates the DSI signal from the T= CON's. > > > Required properties: > > > - compatible: value must be one of: > > > * allwinner,sun6i-a31-mipi-dsi > > > + * "allwinner,sun50i-a64-mipi-dsi", "allwinner,sun6i-a31-mipi-dsi" > >=20 > > The other line doesn't have quotes, we should be consistent >=20 > You mean to say, remove quotes like this >=20 > allwinner,sun50i-a64-mipi-dsi, allwinner,sun6i-a31-mipi-dsi Yep > This make confusion with comma with allwinner vs next compatible string > isn't it? (In fact I did follow the similar like TCON in sun4i-drm.txt) There's no really clear consensus here, andd i don't really have a strong opinion on the matter either. Since the YAML schemas are going to have it without double quotes, I guess we should use that convention as well, but we want to remain consistent at least. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --yiit6eh4xmxsxmgp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXFBpCgAKCRDj7w1vZxhR xV5KAP4uQCiSzyiLpf20SSf+LVg0ilVvXVaAyKZ8286iXnkfGgD+LuvzUttfKIvE cXwtCc2cOoI9IQGGyPCJguGgsMTX3wc= =fwZS -----END PGP SIGNATURE----- --yiit6eh4xmxsxmgp-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: Re: [PATCH v6 14/22] dt-bindings: sun6i-dsi: Add A64 DSI compatible (w/ A31 fallback) Date: Tue, 29 Jan 2019 15:54:03 +0100 Message-ID: <20190129145402.d6athskmfydqodvn@flea> References: <20190124195900.22620-1-jagan@amarulasolutions.com> <20190124195900.22620-15-jagan@amarulasolutions.com> <20190125155236.agxwkxvyefmrbvym@flea> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yiit6eh4xmxsxmgp" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jagan Teki Cc: Jagan Teki , David Airlie , Daniel Vetter , Chen-Yu Tsai , Michael Turquette , Rob Herring , Mark Rutland , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michael Trimarchi , linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --yiit6eh4xmxsxmgp Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Sat, Jan 26, 2019 at 09:39:00PM +0530, Jagan Teki wrote: > On 25/01/19 9:22 PM, Maxime Ripard wrote: > > On Fri, Jan 25, 2019 at 01:28:52AM +0530, Jagan Teki wrote: > > > The MIPI DSI controller in Allwinner A64 is similar to A33. > > > > > > But unlike A33, A64 doesn't have DSI_SCLK gating which eventually > > > set the mod clock rate for the controller. > > > > > > So, use the DSI_DPHY gating for the similar purpose of mod clock > > > so-that the controller can operate properly. > > > > > > Signed-off-by: Jagan Teki > > > Reviewed-by: Rob Herring > > > --- > > > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > index 69e233e8fad1..dbda2e567760 100644 > > > --- a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > @@ -12,6 +12,7 @@ The DSI Encoder generates the DSI signal from the TCON's. > > > Required properties: > > > - compatible: value must be one of: > > > * allwinner,sun6i-a31-mipi-dsi > > > + * "allwinner,sun50i-a64-mipi-dsi", "allwinner,sun6i-a31-mipi-dsi" > > > > The other line doesn't have quotes, we should be consistent > > You mean to say, remove quotes like this > > allwinner,sun50i-a64-mipi-dsi, allwinner,sun6i-a31-mipi-dsi Yep > This make confusion with comma with allwinner vs next compatible string > isn't it? (In fact I did follow the similar like TCON in sun4i-drm.txt) There's no really clear consensus here, andd i don't really have a strong opinion on the matter either. Since the YAML schemas are going to have it without double quotes, I guess we should use that convention as well, but we want to remain consistent at least. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --yiit6eh4xmxsxmgp-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EEACC169C4 for ; Tue, 29 Jan 2019 14:54:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48C9320989 for ; Tue, 29 Jan 2019 14:54:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uoqbGOMt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48C9320989 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tDfg0ZTFDV2hdFH2O+anC9GQ4i3R6b2Dt6ZAvniZI0A=; b=uoqbGOMt5pMig/M58fB8LSyzo oNWt9/oUO8ixH3U365v/vdsm13l4J/uW9x/WjN+u1ek1sjtRSmbeYTfUmwINDkcmFdLww5orEhXm+ Lk7oVT9XFIdpd8xkWPwlZ5jGOYcsX3kcx0Z/DRDV7Nrgb2BibH/eNgA7ydHnOiIefMfhnfH+kC0Gj WnI0jPOgVcxv07lWHhZxS5DVajTxJWYwZ92Y3KO8G7hNJDO0pdW9DE8FxzXfxYEqCjoaK6FDI7PrA anArXZu+EjN+PzrmdgYr3HnyQ9uGPvfOUx26Ccn9cPhPrQTjpeefd2D4B9TNFvL88dwtXKm04P7/U RTUYuLF4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goUmQ-0007NX-Ov; Tue, 29 Jan 2019 14:54:26 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1goUmM-0007N6-VM for linux-arm-kernel@lists.infradead.org; Tue, 29 Jan 2019 14:54:25 +0000 Received: from localhost (aaubervilliers-681-1-27-226.w90-88.abo.wanadoo.fr [90.88.147.226]) (Authenticated sender: maxime.ripard@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 8B1FC200012; Tue, 29 Jan 2019 14:54:07 +0000 (UTC) Date: Tue, 29 Jan 2019 15:54:03 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [linux-sunxi] Re: [PATCH v6 14/22] dt-bindings: sun6i-dsi: Add A64 DSI compatible (w/ A31 fallback) Message-ID: <20190129145402.d6athskmfydqodvn@flea> References: <20190124195900.22620-1-jagan@amarulasolutions.com> <20190124195900.22620-15-jagan@amarulasolutions.com> <20190125155236.agxwkxvyefmrbvym@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190129_065423_387349_2B113A12 X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , Michael Turquette , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Rob Herring , Jagan Teki , Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0186278894145609805==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0186278894145609805== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yiit6eh4xmxsxmgp" Content-Disposition: inline --yiit6eh4xmxsxmgp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 26, 2019 at 09:39:00PM +0530, Jagan Teki wrote: > On 25/01/19 9:22 PM, Maxime Ripard wrote: > > On Fri, Jan 25, 2019 at 01:28:52AM +0530, Jagan Teki wrote: > > > The MIPI DSI controller in Allwinner A64 is similar to A33. > > >=20 > > > But unlike A33, A64 doesn't have DSI_SCLK gating which eventually > > > set the mod clock rate for the controller. > > >=20 > > > So, use the DSI_DPHY gating for the similar purpose of mod clock > > > so-that the controller can operate properly. > > >=20 > > > Signed-off-by: Jagan Teki > > > Reviewed-by: Rob Herring > > > --- > > > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + > > > 1 file changed, 1 insertion(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-ds= i.txt b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > index 69e233e8fad1..dbda2e567760 100644 > > > --- a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > @@ -12,6 +12,7 @@ The DSI Encoder generates the DSI signal from the T= CON's. > > > Required properties: > > > - compatible: value must be one of: > > > * allwinner,sun6i-a31-mipi-dsi > > > + * "allwinner,sun50i-a64-mipi-dsi", "allwinner,sun6i-a31-mipi-dsi" > >=20 > > The other line doesn't have quotes, we should be consistent >=20 > You mean to say, remove quotes like this >=20 > allwinner,sun50i-a64-mipi-dsi, allwinner,sun6i-a31-mipi-dsi Yep > This make confusion with comma with allwinner vs next compatible string > isn't it? (In fact I did follow the similar like TCON in sun4i-drm.txt) There's no really clear consensus here, andd i don't really have a strong opinion on the matter either. Since the YAML schemas are going to have it without double quotes, I guess we should use that convention as well, but we want to remain consistent at least. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --yiit6eh4xmxsxmgp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXFBpCgAKCRDj7w1vZxhR xV5KAP4uQCiSzyiLpf20SSf+LVg0ilVvXVaAyKZ8286iXnkfGgD+LuvzUttfKIvE cXwtCc2cOoI9IQGGyPCJguGgsMTX3wc= =fwZS -----END PGP SIGNATURE----- --yiit6eh4xmxsxmgp-- --===============0186278894145609805== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0186278894145609805==--