From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21205C169C4 for ; Tue, 29 Jan 2019 17:41:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEFA020857 for ; Tue, 29 Jan 2019 17:41:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729193AbfA2Rlr (ORCPT ); Tue, 29 Jan 2019 12:41:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726852AbfA2Rlr (ORCPT ); Tue, 29 Jan 2019 12:41:47 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 961B113363; Tue, 29 Jan 2019 17:41:47 +0000 (UTC) Received: from cantor.redhat.com (ovpn-116-77.phx2.redhat.com [10.3.116.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65FE991B36; Tue, 29 Jan 2019 17:41:47 +0000 (UTC) From: Jerry Snitselaar To: Jarkko Sakkinen , linux-integrity@vger.kernel.org Subject: [RFC PATCH 0/1] tpm: don't return bool from update_timeouts Date: Tue, 29 Jan 2019 10:41:44 -0700 Message-Id: <20190129174145.1482-1-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 29 Jan 2019 17:41:47 +0000 (UTC) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Sorry, I've been tied up tracking down some iommu issues. I just took a quick stab at this. It looks like the only failure case is the tpm read of the did/vid failing for the spi driver. My question is do we want to fail the probe in that case, spit out a message, or just continue on? Thoughts? Regards, Jerry