From: Igor Mammedov <imammedo@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument
Date: Wed, 30 Jan 2019 09:16:50 +0100 [thread overview]
Message-ID: <20190130091650.5c7b5f7e@Igors-MacBook-Pro.local> (raw)
In-Reply-To: <20190130030207.6770-1-richardw.yang@linux.intel.com>
On Wed, 30 Jan 2019 11:02:07 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:
> The second argument of build_facs() is not used, just remove it.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/i386/acpi-build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 236a20eaa8..023729c1f2 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)
>
> /* FACS */
> static void
> -build_facs(GArray *table_data, BIOSLinker *linker)
> +build_facs(GArray *table_data)
> {
> AcpiFacsDescriptorRev1 *facs = acpi_data_push(table_data, sizeof *facs);
> memcpy(&facs->signature, "FACS", 4);
> @@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
> * requirements.
> */
> facs = tables_blob->len;
> - build_facs(tables_blob, tables->linker);
> + build_facs(tables_blob);
>
> /* DSDT is pointed to by FADT */
> dsdt = tables_blob->len;
next prev parent reply other threads:[~2019-01-30 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 3:02 [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument Wei Yang
2019-01-30 8:16 ` Igor Mammedov [this message]
2019-01-30 8:54 ` Wei Yang
2019-01-30 11:15 ` Philippe Mathieu-Daudé
2019-01-30 12:59 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130091650.5c7b5f7e@Igors-MacBook-Pro.local \
--to=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.