From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gomNc-0001Lg-IZ for qemu-devel@nongnu.org; Wed, 30 Jan 2019 04:42:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gomNb-0003pr-RI for qemu-devel@nongnu.org; Wed, 30 Jan 2019 04:42:00 -0500 Date: Wed, 30 Jan 2019 10:41:55 +0100 From: Cornelia Huck Message-ID: <20190130104155.08cc0ac9.cohuck@redhat.com> In-Reply-To: <1548834906-133241-1-git-send-email-imammedo@redhat.com> References: <1548834906-133241-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] s390x: remove direct reference to mem_path global from s390x code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, david@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, rth@twiddle.net On Wed, 30 Jan 2019 08:55:06 +0100 Igor Mammedov wrote: > I plan to deprecate -mem-path option and replace it with memory-backend, > for that it's necessary to get rid of mem_path global variable. > Do it for s390x case, replacing it with alternative way to enable > 1Mb hugepages capability. > > Todo that replace qemu_mempath_getpagesize() with qemu_getrampagesize() > which also checks for -mem-path provided RAM. > > Signed-off-by: Igor Mammedov > --- > v4: > * fix typos in commit message > * add include "exec/ram_addr.h" to make sure it compiles on ppc host > v2: > * s/qemu_mempath_getpagesize/qemu_getrampagesiz/ and drop the rest of changes > David Hildenbrand Something odd happened here -- I presume you did not want to drop David's R-b? [I can re-add while applying, no need to resend.] > --- > target/s390x/kvm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)