From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] devtools: check commit log fixes syntax
Date: Wed, 30 Jan 2019 11:31:59 +0000
Message-ID: <20190130113159.GC157424@bricha3-MOBL.ger.corp.intel.com>
References: <20190129153052.38634-1-ferruh.yigit@intel.com>
 <CAJFAV8zw9BfDn+eFMHdEnjzSdhWKPRdGDnao+sJMwvMX31Y9LQ@mail.gmail.com>
 <7d48eede-61eb-9dc0-ea1b-799489850eb0@intel.com>
 <6481538.UeMWjqPEGc@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
 David Marchand <david.marchand@redhat.com>, dev@dpdk.org,
 Qi Zhang <qi.z.zhang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 00EA21B2B3
 for <dev@dpdk.org>; Wed, 30 Jan 2019 12:32:03 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <6481538.UeMWjqPEGc@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jan 30, 2019 at 12:27:58PM +0100, Thomas Monjalon wrote:
> 30/01/2019 12:17, Ferruh Yigit:
> > On 1/30/2019 9:58 AM, David Marchand wrote:
> > > The contributing guide does indicate you are supposed to run both
> > > checkpatches.sh and check-git-log.sh.
> > > I am pretty sure I missed this second step in the past..
> > > 
> > > How about calling check-git-log.sh from checkpatches.sh ?
> > > check-git-log.sh does not support patch files as input, so it would need
> > > support for it.
> > 
> > That sounds good idea to have single script to run.
> 
> It will never be only one script to run.
> There are more scripts in devtools and I plan to add more.
> Some checks can be done only once for a group of commits,
> and will be really too slow if run for each patch when merging a branch.
> 
> About check-git-log, some tests cannot be possible outside of a git tree.
> Do you want to run it when checkpatches is run on git tree?
> Wouldn't it be confusing?
> 
Possibly, but we can print out a warning when not run, saying
"check-git-log skipped because we are not running on git tree". I think the
benefit of having all checks done by one script is greater than the
downside of a little confusion.

/Bruce