From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE63C282D7 for ; Wed, 30 Jan 2019 23:27:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC946218D2 for ; Wed, 30 Jan 2019 23:27:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="N1DRTbyf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730278AbfA3X1h (ORCPT ); Wed, 30 Jan 2019 18:27:37 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:34504 "EHLO mail-qt1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725768AbfA3X1h (ORCPT ); Wed, 30 Jan 2019 18:27:37 -0500 Received: by mail-qt1-f176.google.com with SMTP id r14so1626185qtp.1 for ; Wed, 30 Jan 2019 15:27:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=oOdQV936ZDm4vi1mWluKi6h/zR4Et4eET5m5zxryOFo=; b=N1DRTbyflMHSo/b9O+umuJf4J4j8yuS+8+sCmTb6GWgtatrlaV6QPWnZZ2zTLZUvol R5BV0yXzplhfTbDgXI7OZwHX5IqUIVhvdmMB3iughC55LSKHeIy5rKzCI3FZnq8q6QID FyVthlD8rTUFDLe0PeeyZzKmTDA1bePT4YMQ6P2KXApjNYfPmNllMuXrDrLk2hkpqqRz o5l3oafzMFWz+F9GZbB/HGj8b9cow/cwHYcLp7a1m5GzLMo7+yyUDY04BtRoebT5YHZo tGJ/QKjnqWBi4FK5Yt856P3ELBbZEZ8CTPIcjGYYAkBdC3GJ4NIQPim93d97gjdAJUmm 3JGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=oOdQV936ZDm4vi1mWluKi6h/zR4Et4eET5m5zxryOFo=; b=LBjnFncc5ZNoT5/xBERAD2SDYkonqRn6deIQooPKrxrh1CB5q3KYZdR6wtAYMxkyrj 77pgA82sIefHiBcgDaokbudFD963lOIME8gHAkPmR4r+dPRJenQJoGlNUfroPYIGi7FN Yy32NIzWWELLNWOkQgJTENG7CqT9sUV0ZjJnpa2Dn4RR2esegJOkQ/QH3LUrO9oR76xH L8fZrqD1FYybUM5WBMvzmaGrDIKBhK1ElXx+DbHO1uwtTdbsdAHBSa5J1kwP3XRrynPJ JlPX+th3ldAU6GWgxM4BG2mwSR7C/G+dzThV96P2P4ZvjqUKTXQWclzkqJ7kqE/9No+w ZgxQ== X-Gm-Message-State: AJcUukf2EU7S3ABjQWRZNmzj1kCVTK4QDHhQWaku/QILvo7QLJ7ogHrO hJmVBwjxOGK/hcaFMuVsq66Hz3Yzf1g= X-Google-Smtp-Source: ALg8bN5GpRwHMkfQId/Tq+KCaYREFUwTnKMuNorDOg2/x9ezKZPq504HZnoDDNwmPTryjGhbfrYMiQ== X-Received: by 2002:a0c:8936:: with SMTP id 51mr30468587qvp.220.1548886928528; Wed, 30 Jan 2019 14:22:08 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id g23sm3302534qta.24.2019.01.30.14.22.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 14:22:08 -0800 (PST) Date: Wed, 30 Jan 2019 14:21:58 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com, andrew@lunn.ch, f.fainelli@gmail.com, mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com Subject: Re: [PATCH net-next v2 6/7] nfp: devlink: report the running and flashed versions Message-ID: <20190130142158.433af0ce@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190130215752.GD349@nanopsycho.orion> References: <20190130190513.25718-1-jakub.kicinski@netronome.com> <20190130190513.25718-7-jakub.kicinski@netronome.com> <20190130215752.GD349@nanopsycho.orion> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 30 Jan 2019 22:57:52 +0100, Jiri Pirko wrote: > >+/* Control processor FW version, FW is responsible for house keeping tasks, > >+ * PHY control etc. > >+ */ > >+#define DEVLINK_VERSION_GENERIC_FW_MGMT "fw.mgmt" > >+/* Data path microcode controlling high-speed packet processing */ > >+#define DEVLINK_VERSION_GENERIC_FW_APP "fw.app" > >+/* UNDI software version */ > >+#define DEVLINK_VERSION_GENERIC_FW_UNDI "fw.undi" > >+/* NCSI support/handler version */ > >+#define DEVLINK_VERSION_GENERIC_FW_NCSI "fw.ncsi" > > Same here. Also, please put "INFO" in the names to respect the namespacing Ack on all, and thanks for the reviews! Do you also think I should add a doc with them? I was going back and forth on that..