From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Starkey Subject: Re: [PATCH 5/5] drm/i2c: tda998x: improve correctness of quantisation range Date: Wed, 30 Jan 2019 15:53:04 +0000 Message-ID: <20190130155303.t6agzcwz3wk2bk5d@DESKTOP-E1NTVVP.localdomain> References: <20190125094038.ohrj6fhm7c7bdtee@e5254000004ec.dyn.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on060d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe09::60d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A9046E610 for ; Wed, 30 Jan 2019 15:53:07 +0000 (UTC) In-Reply-To: Content-Language: en-US Content-ID: <9BB8EA7767BED240891487EC1A92EC76@eurprd08.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King Cc: David Airlie , nd , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org SGkgUnVzc2VsbCwKCk9uIEZyaSwgSmFuIDI1LCAyMDE5IGF0IDA5OjQzOjI5QU0gKzAwMDAsIFJ1 c3NlbGwgS2luZyB3cm90ZToKPiBDRUEtODYxIHNheXM6ICJBIFNvdXJjZSBzaGFsbCBub3Qgc2Vu ZCBhIG5vbi16ZXJvIFEgdmFsdWUgdGhhdCBkb2VzCj4gbm90IGNvcnJlc3BvbmQgdG8gdGhlIGRl ZmF1bHQgUkdCIFF1YW50aXphdGlvbiBSYW5nZSBmb3IgdGhlCj4gdHJhbnNtaXR0ZWQgUGljdHVy ZSB1bmxlc3MgdGhlIFNpbmsgaW5kaWNhdGVzIHN1cHBvcnQgZm9yIHRoZSBRIGJpdAo+IGluIGEg VmlkZW8gQ2FwYWJpbGl0aWVzIERhdGEgQmxvY2suIgo+IAo+IE1ha2UgVERBOTk4eCBjb21wbGlh bnQgYnkgdXNpbmcgdGhlIGhlbHBlciB0byBzZXQgdGhlIHF1YW50aXNhdGlvbgo+IHJhbmdlIGlu IHRoZSBpbmZvZnJhbWUsIGFuZCB1c2luZyB0aGUgVERBOTk4eCdzIGNvbG91ciBzY2FsaW5nIHRv Cj4gYXBwcm9wcmlhdGVseSBhZGp1c3QgdGhlIFJHQiB2YWx1ZXMgc2VudCB0byB0aGUgbW9uaXRv ci4KPiAKPiBUaGlzIGVuc3VyZXMgdGhhdCBtb25pdG9ycyB0aGF0IGRvIG5vdCBzdXBwb3J0IHRo ZSBRIGJpdCBhcmUgc2VudAo+IFJHQiB2YWx1ZXMgdGhhdCBhcmUgd2l0aGluIHRoZSBleHBlY3Rl ZCByYW5nZS4gIE1vbml0b3JzIHdpdGgKPiBzdXBwb3J0IGZvciB0aGUgUSBiaXQgd2lsbCBiZSBz ZW50IGZ1bGwtcmFuZ2UgUkdCLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFJ1c3NlbGwgS2luZyA8cm1r K2tlcm5lbEBhcm1saW51eC5vcmcudWs+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pMmMvdGRh OTk4eF9kcnYuYyB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jIGIvZHJpdmVycy9n cHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jCj4gaW5kZXggYjBlZDJlZjQ5YzYyLi43ZDlhZWE3OWFm ZjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jCj4gQEAgLTUwLDYgKzUwLDggQEAg c3RydWN0IHRkYTk5OHhfcHJpdiB7Cj4gIAlib29sIGlzX29uOwo+ICAJYm9vbCBzdXBwb3J0c19p bmZvZnJhbWVzOwo+ICAJYm9vbCBzaW5rX2hhc19hdWRpbzsKPiArCWJvb2wgaGFzX3JnYl9xdWFu dDsKPiArCWVudW0gaGRtaV9xdWFudGl6YXRpb25fcmFuZ2UgcmdiX3F1YW50X3JhbmdlOwo+ICAJ dTggdmlwX2NudHJsXzA7Cj4gIAl1OCB2aXBfY250cmxfMTsKPiAgCXU4IHZpcF9jbnRybF8yOwo+ IEBAIC04NjksNyArODcxLDkgQEAgdGRhOTk4eF93cml0ZV9hdmkoc3RydWN0IHRkYTk5OHhfcHJp diAqcHJpdiwgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUKPiAgCj4gIAlkcm1f aGRtaV9hdmlfaW5mb2ZyYW1lX2Zyb21fZGlzcGxheV9tb2RlKCZmcmFtZS5hdmksCj4gIAkJCQkJ CSAmcHJpdi0+Y29ubmVjdG9yLCBtb2RlKTsKPiAtCWZyYW1lLmF2aS5xdWFudGl6YXRpb25fcmFu Z2UgPSBIRE1JX1FVQU5USVpBVElPTl9SQU5HRV9GVUxMOwo+ICsJZHJtX2hkbWlfYXZpX2luZm9m cmFtZV9xdWFudF9yYW5nZSgmZnJhbWUuYXZpLCBtb2RlLAo+ICsJCQkJCSAgIHByaXYtPnJnYl9x dWFudF9yYW5nZSwKPiArCQkJCQkgICBwcml2LT5oYXNfcmdiX3F1YW50LCBmYWxzZSk7Cj4gIAo+ ICAJdGRhOTk4eF93cml0ZV9pZihwcml2LCBESVBfSUZfRkxBR1NfSUYyLCBSRUdfSUYyX0hCMCwg JmZyYW1lKTsKPiAgfQo+IEBAIC0xMjU5LDYgKzEyNjMsNyBAQCBzdGF0aWMgaW50IHRkYTk5OHhf Y29ubmVjdG9yX2dldF9tb2RlcyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJ bXV0ZXhfbG9jaygmcHJpdi0+YXVkaW9fbXV0ZXgpOwo+ICAJbiA9IGRybV9hZGRfZWRpZF9tb2Rl cyhjb25uZWN0b3IsIGVkaWQpOwo+ICAJcHJpdi0+c2lua19oYXNfYXVkaW8gPSBkcm1fZGV0ZWN0 X21vbml0b3JfYXVkaW8oZWRpZCk7Cj4gKwlwcml2LT5oYXNfcmdiX3F1YW50ID0gZHJtX3JnYl9x dWFudF9yYW5nZV9zZWxlY3RhYmxlKGVkaWQpOwo+ICAJbXV0ZXhfdW5sb2NrKCZwcml2LT5hdWRp b19tdXRleCk7Cj4gIAo+ICAJa2ZyZWUoZWRpZCk7Cj4gQEAgLTEzODUsNiArMTM5MCwxNSBAQCBz dGF0aWMgdm9pZCB0ZGE5OTh4X2JyaWRnZV9tb2RlX3NldChzdHJ1Y3QgZHJtX2JyaWRnZSAqYnJp ZGdlLAo+ICAJdTggcmVnLCBkaXYsIHJlcCwgc2VsX2NsazsKPiAgCj4gIAkvKgo+ICsJICogU2lu Y2Ugd2UgYXJlICJjb21wdXRlciIgbGlrZSwgb3VyIHNvdXJjZSBpbnZhcmlhYmx5IHByb2R1Y2Vz Cj4gKwkgKiBmdWxsLXJhbmdlIFJHQi4gIElmIHRoZSBtb25pdG9yIHN1cHBvcnRzIGZ1bGwtcmFu Z2UsIHRoZW4gdXNlCj4gKwkgKiBpdCwgb3RoZXJ3aXNlIHJlZHVjZSB0byBsaW1pdGVkLXJhbmdl Lgo+ICsJICovCj4gKwlwcml2LT5yZ2JfcXVhbnRfcmFuZ2UgPSBwcml2LT5oYXNfcmdiX3F1YW50 ID8KPiArCQlIRE1JX1FVQU5USVpBVElPTl9SQU5HRV9GVUxMIDoKPiArCQlkcm1fZGVmYXVsdF9y Z2JfcXVhbnRfcmFuZ2UoYWRqdXN0ZWRfbW9kZSk7Cj4gKwo+ICsJLyoKPiAgCSAqIEludGVybmFs bHkgVERBOTk4eCBpcyB1c2luZyBJVFUtUiBCVC42NTYgc3R5bGUgc3luYyBidXQKPiAgCSAqIHdl IGdldCBWRVNBIHN0eWxlIHN5bmMuIFREQTk5OHggaXMgdXNpbmcgYSByZWZlcmVuY2UgcGl4ZWwK PiAgCSAqIHJlbGF0aXZlIHRvIElUVSB0byBzeW5jIHRvIHRoZSBpbnB1dCBmcmFtZSBhbmQgZm9y IG91dHB1dAo+IEBAIC0xNDk5LDEwICsxNTEzLDI1IEBAIHN0YXRpYyB2b2lkIHRkYTk5OHhfYnJp ZGdlX21vZGVfc2V0KHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UsCj4gIAlyZWdfd3JpdGUocHJp diwgUkVHX1BMTF9TRVJJQUxfMiwgUExMX1NFUklBTF8yX1NSTF9OT1NDKGRpdikgfAo+ICAJCQlQ TExfU0VSSUFMXzJfU1JMX1BSKHJlcCkpOwo+ICAKPiAtCS8qIHNldCBjb2xvciBtYXRyaXggYnlw YXNzIGZsYWc6ICovCj4gLQlyZWdfd3JpdGUocHJpdiwgUkVHX01BVF9DT05UUkwsIE1BVF9DT05U UkxfTUFUX0JQIHwKPiAtCQkJCU1BVF9DT05UUkxfTUFUX1NDKDEpKTsKPiAtCXJlZ19zZXQocHJp diwgUkVHX0ZFQVRfUE9XRVJET1dOLCBGRUFUX1BPV0VSRE9XTl9DU0MpOwo+ICsJLyogc2V0IGNv bG9yIG1hdHJpeCBhY2NvcmRpbmcgdG8gb3V0cHV0IHJnYiBxdWFudCByYW5nZSAqLwo+ICsJaWYg KHByaXYtPnJnYl9xdWFudF9yYW5nZSA9PSBIRE1JX1FVQU5USVpBVElPTl9SQU5HRV9MSU1JVEVE KSB7Cj4gKwkJc3RhdGljIHU4IHRkYTk5OHhfZnVsbF90b19saW1pdGVkX3JhbmdlW10gPSB7Cj4g KwkJCU1BVF9DT05UUkxfTUFUX1NDKDIpLAo+ICsJCQkweDAwLCAweDAwLCAweDAwLCAweDAwLCAw eDAwLCAweDAwLAo+ICsJCQkweDAzLCAweDZmLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAo+ICsJ CQkweDAwLCAweDAwLCAweDAzLCAweDZmLCAweDAwLCAweDAwLAo+ICsJCQkweDAwLCAweDAwLCAw eDAwLCAweDAwLCAweDAzLCAweDZmLAo+ICsJCQkweDAwLCAweDQwLCAweDAwLCAweDQwLCAweDAw LCAweDQwCj4gKwkJfTsKCkkgY291bGRuJ3QgZmlndXJlIG91dCBmcm9tIHRoZSBkYXRhc2hlZXQg SSBoYXZlIHdoYXQgdGhlIGV4cGVjdGVkIGRhdGEKYml0LWRlcHRoIGlzIGhlcmUsIGJ1dCBJIGFz c3VtZSBmcm9tIHRoaXMgb2Zmc2V0IHRoYXQgaXQncyAxMi1iaXQ/CgpTaG91bGQgeW91IGFsc28g c2V0IEhWRl9DTlRSTF8xX1ZRUiB0byAwYjAxIHdoZW4gdXNpbmcgbGltaXRlZCByYW5nZT8KCkNo ZWVycywKLUJyaWFuCgo+ICsJCXJlZ19jbGVhcihwcml2LCBSRUdfRkVBVF9QT1dFUkRPV04sIEZF QVRfUE9XRVJET1dOX0NTQyk7Cj4gKwkJcmVnX3dyaXRlX3JhbmdlKHByaXYsIFJFR19NQVRfQ09O VFJMLAo+ICsJCQkJdGRhOTk4eF9mdWxsX3RvX2xpbWl0ZWRfcmFuZ2UsCj4gKwkJCQlzaXplb2Yo dGRhOTk4eF9mdWxsX3RvX2xpbWl0ZWRfcmFuZ2UpKTsKPiArCX0gZWxzZSB7Cj4gKwkJcmVnX3dy aXRlKHByaXYsIFJFR19NQVRfQ09OVFJMLCBNQVRfQ09OVFJMX01BVF9CUCB8Cj4gKwkJCQkJTUFU X0NPTlRSTF9NQVRfU0MoMSkpOwo+ICsJCXJlZ19zZXQocHJpdiwgUkVHX0ZFQVRfUE9XRVJET1dO LCBGRUFUX1BPV0VSRE9XTl9DU0MpOwo+ICsJfQo+ICAKPiAgCS8qIHNldCBCSUFTIHRtZHMgdmFs dWU6ICovCj4gIAlyZWdfd3JpdGUocHJpdiwgUkVHX0FOQV9HRU5FUkFMLCAweDA5KTsKPiAtLSAK PiAyLjcuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK