All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
	jiri@resnulli.us, andrew@lunn.ch, f.fainelli@gmail.com,
	mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com,
	Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCH net-next v2 3/7] nfp: devlink: report driver name and serial number
Date: Wed, 30 Jan 2019 11:05:09 -0800	[thread overview]
Message-ID: <20190130190513.25718-4-jakub.kicinski@netronome.com> (raw)
In-Reply-To: <20190130190513.25718-1-jakub.kicinski@netronome.com>

Report the basic info through new devlink info API.

RFCv2:
 - add driver name;
 - align serial to core changes.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
---
 .../net/ethernet/netronome/nfp/nfp_devlink.c  | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
index 808647ec3573..cb3ef7e46614 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
@@ -4,6 +4,7 @@
 #include <linux/rtnetlink.h>
 #include <net/devlink.h>
 
+#include "nfpcore/nfp.h"
 #include "nfpcore/nfp_nsp.h"
 #include "nfp_app.h"
 #include "nfp_main.h"
@@ -171,6 +172,28 @@ static int nfp_devlink_eswitch_mode_set(struct devlink *devlink, u16 mode,
 	return ret;
 }
 
+static int
+nfp_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
+		     struct netlink_ext_ack *extack)
+{
+	struct nfp_pf *pf = devlink_priv(devlink);
+	const char *sn;
+	int err;
+
+	err = devlink_info_report_driver_name(req, "nfp");
+	if (err)
+		return err;
+
+	sn = nfp_hwinfo_lookup(pf->hwinfo, "assembly.serial");
+	if (sn) {
+		err = devlink_info_report_serial_number(req, sn);
+		if (err)
+			return err;
+	}
+
+	return 0;
+}
+
 const struct devlink_ops nfp_devlink_ops = {
 	.port_split		= nfp_devlink_port_split,
 	.port_unsplit		= nfp_devlink_port_unsplit,
@@ -178,6 +201,7 @@ const struct devlink_ops nfp_devlink_ops = {
 	.sb_pool_set		= nfp_devlink_sb_pool_set,
 	.eswitch_mode_get	= nfp_devlink_eswitch_mode_get,
 	.eswitch_mode_set	= nfp_devlink_eswitch_mode_set,
+	.info_get		= nfp_devlink_info_get,
 };
 
 int nfp_devlink_port_register(struct nfp_app *app, struct nfp_port *port)
-- 
2.19.2


  parent reply	other threads:[~2019-01-30 19:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30 19:05 [PATCH net-next v2 0/7] devlink: add device (driver) information API Jakub Kicinski
2019-01-30 19:05 ` [PATCH net-next v2 1/7] devlink: add device " Jakub Kicinski
2019-01-30 21:16   ` Jiri Pirko
2019-01-30 19:05 ` [PATCH net-next v2 2/7] devlink: add version reporting to devlink info API Jakub Kicinski
2019-01-30 21:54   ` Jiri Pirko
2019-01-30 19:05 ` Jakub Kicinski [this message]
2019-01-30 19:05 ` [PATCH net-next v2 4/7] nfp: devlink: report fixed versions Jakub Kicinski
2019-01-30 21:56   ` Jiri Pirko
2019-01-30 19:05 ` [PATCH net-next v2 5/7] nfp: nsp: add support for versions command Jakub Kicinski
2019-01-30 19:05 ` [PATCH net-next v2 6/7] nfp: devlink: report the running and flashed versions Jakub Kicinski
2019-01-30 21:57   ` Jiri Pirko
2019-01-30 22:21     ` Jakub Kicinski
2019-01-30 22:19       ` Jiri Pirko
2019-01-30 19:05 ` [PATCH net-next v2 7/7] ethtool: add compat for devlink info Jakub Kicinski
2019-01-30 22:12   ` Jiri Pirko
2019-01-31 19:05   ` kbuild test robot
2019-02-01  4:06   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130190513.25718-4-jakub.kicinski@netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=eugenem@fb.com \
    --cc=f.fainelli@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=jonathan.lemon@gmail.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.