* [Qemu-devel] [PATCH] MAINTAINERS: Merge the two e500 sections
@ 2019-01-30 16:22 Thomas Huth
2019-01-30 16:28 ` Philippe Mathieu-Daudé
2019-01-30 22:40 ` David Gibson
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2019-01-30 16:22 UTC (permalink / raw)
To: qemu-ppc, David Gibson; +Cc: qemu-devel
There is currently a "e500" machine section and a "ppce500" device
section in the maintainers file - with some oddities: The wildcard
in the device section also covers the files from the machine section.
And hw/pci-host/ppce500.c is in the device section, while its header
is in the machine section.
This is really quite confusing, and I don't see a reason why we really
need two sections here, so let's simply merge them.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
MAINTAINERS | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index eac36b6..30dbe37 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -957,9 +957,10 @@ e500
M: David Gibson <david@gibson.dropbear.id.au>
L: qemu-ppc@nongnu.org
S: Odd Fixes
-F: hw/ppc/e500.[hc]
-F: hw/ppc/e500plat.c
+F: hw/ppc/e500*
F: hw/gpio/mpc8xxx.c
+F: hw/net/fsl_etsec/
+F: hw/pci-host/ppce500.c
F: include/hw/ppc/ppc_e500.h
F: include/hw/pci-host/ppce500.h
F: pc-bios/u-boot.e500
@@ -1316,14 +1317,6 @@ F: hw/i2c/ppc4xx_i2c.c
F: include/hw/ppc/ppc4xx.h
F: include/hw/i2c/ppc4xx_i2c.h
-ppce500
-M: David Gibson <david@gibson.dropbear.id.au>
-L: qemu-ppc@nongnu.org
-S: Odd Fixes
-F: hw/ppc/e500*
-F: hw/pci-host/ppce500.c
-F: hw/net/fsl_etsec/
-
Character devices
M: Marc-André Lureau <marcandre.lureau@redhat.com>
R: Paolo Bonzini <pbonzini@redhat.com>
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Merge the two e500 sections
2019-01-30 16:22 [Qemu-devel] [PATCH] MAINTAINERS: Merge the two e500 sections Thomas Huth
@ 2019-01-30 16:28 ` Philippe Mathieu-Daudé
2019-01-30 22:40 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-30 16:28 UTC (permalink / raw)
To: Thomas Huth, qemu-ppc, David Gibson; +Cc: qemu-devel
On 1/30/19 5:22 PM, Thomas Huth wrote:
> There is currently a "e500" machine section and a "ppce500" device
> section in the maintainers file - with some oddities: The wildcard
> in the device section also covers the files from the machine section.
> And hw/pci-host/ppce500.c is in the device section, while its header
> is in the machine section.
> This is really quite confusing, and I don't see a reason why we really
> need two sections here, so let's simply merge them.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> MAINTAINERS | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index eac36b6..30dbe37 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -957,9 +957,10 @@ e500
> M: David Gibson <david@gibson.dropbear.id.au>
> L: qemu-ppc@nongnu.org
> S: Odd Fixes
> -F: hw/ppc/e500.[hc]
> -F: hw/ppc/e500plat.c
> +F: hw/ppc/e500*
> F: hw/gpio/mpc8xxx.c
> +F: hw/net/fsl_etsec/
> +F: hw/pci-host/ppce500.c
> F: include/hw/ppc/ppc_e500.h
> F: include/hw/pci-host/ppce500.h
> F: pc-bios/u-boot.e500
> @@ -1316,14 +1317,6 @@ F: hw/i2c/ppc4xx_i2c.c
> F: include/hw/ppc/ppc4xx.h
> F: include/hw/i2c/ppc4xx_i2c.h
>
> -ppce500
> -M: David Gibson <david@gibson.dropbear.id.au>
> -L: qemu-ppc@nongnu.org
> -S: Odd Fixes
> -F: hw/ppc/e500*
> -F: hw/pci-host/ppce500.c
> -F: hw/net/fsl_etsec/
> -
> Character devices
> M: Marc-André Lureau <marcandre.lureau@redhat.com>
> R: Paolo Bonzini <pbonzini@redhat.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Merge the two e500 sections
2019-01-30 16:22 [Qemu-devel] [PATCH] MAINTAINERS: Merge the two e500 sections Thomas Huth
2019-01-30 16:28 ` Philippe Mathieu-Daudé
@ 2019-01-30 22:40 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2019-01-30 22:40 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-ppc, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]
On Wed, Jan 30, 2019 at 05:22:25PM +0100, Thomas Huth wrote:
> There is currently a "e500" machine section and a "ppce500" device
> section in the maintainers file - with some oddities: The wildcard
> in the device section also covers the files from the machine section.
> And hw/pci-host/ppce500.c is in the device section, while its header
> is in the machine section.
> This is really quite confusing, and I don't see a reason why we really
> need two sections here, so let's simply merge them.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Applied to ppc-for-4.0, thanks.
> ---
> MAINTAINERS | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index eac36b6..30dbe37 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -957,9 +957,10 @@ e500
> M: David Gibson <david@gibson.dropbear.id.au>
> L: qemu-ppc@nongnu.org
> S: Odd Fixes
> -F: hw/ppc/e500.[hc]
> -F: hw/ppc/e500plat.c
> +F: hw/ppc/e500*
> F: hw/gpio/mpc8xxx.c
> +F: hw/net/fsl_etsec/
> +F: hw/pci-host/ppce500.c
> F: include/hw/ppc/ppc_e500.h
> F: include/hw/pci-host/ppce500.h
> F: pc-bios/u-boot.e500
> @@ -1316,14 +1317,6 @@ F: hw/i2c/ppc4xx_i2c.c
> F: include/hw/ppc/ppc4xx.h
> F: include/hw/i2c/ppc4xx_i2c.h
>
> -ppce500
> -M: David Gibson <david@gibson.dropbear.id.au>
> -L: qemu-ppc@nongnu.org
> -S: Odd Fixes
> -F: hw/ppc/e500*
> -F: hw/pci-host/ppce500.c
> -F: hw/net/fsl_etsec/
> -
> Character devices
> M: Marc-André Lureau <marcandre.lureau@redhat.com>
> R: Paolo Bonzini <pbonzini@redhat.com>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-30 22:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-30 16:22 [Qemu-devel] [PATCH] MAINTAINERS: Merge the two e500 sections Thomas Huth
2019-01-30 16:28 ` Philippe Mathieu-Daudé
2019-01-30 22:40 ` David Gibson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.