From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD Date: Wed, 30 Jan 2019 17:32:44 -0800 Message-ID: <20190131013244.GC27190@builder> References: <20190118044801.7312-1-rnayak@codeaurora.org> <154783318835.169631.6614930101893188915@swboyd.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <154783318835.169631.6614930101893188915@swboyd.mtv.corp.google.com> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd , Rob Herring , Alexander Graf Cc: Rajendra Nayak , andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux@roeck-us.net List-Id: linux-arm-msm@vger.kernel.org On Fri 18 Jan 09:39 PST 2019, Stephen Boyd wrote: > Quoting Rajendra Nayak (2019-01-17 20:48:01) > > drivers/soc/qcom/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > > index a5d5167c3f16..1ee298f6bf17 100644 > > --- a/drivers/soc/qcom/Kconfig > > +++ b/drivers/soc/qcom/Kconfig > > @@ -109,7 +109,7 @@ config QCOM_RPMHPD > > > > config QCOM_RPMPD > > bool "Qualcomm RPM Power domain driver" > > Just curious, does it need to be bool for some reason? > It's unfortunately not possible to have any genpd, iommu or pinctrl drivers compiled as modules, because once you pass lateinit probe deferral is purposefully broken. See driver_deferred_probe_check_state(). This also means that if you're unlucky and your kernel reached lateinit before the SMD communication with RPM is established and has brought up the rpmpd, you are left with a completely broken system. Unfortunately this isn't that hard to reproduce with a minimal defconfig. Regards, Bjorn