From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpEBM-0006tm-E7 for qemu-devel@nongnu.org; Thu, 31 Jan 2019 10:23:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpEBL-0001Ad-OT for qemu-devel@nongnu.org; Thu, 31 Jan 2019 10:23:12 -0500 Date: Thu, 31 Jan 2019 15:20:42 +0000 From: Anthony PERARD Message-ID: <20190131152042.GF2306@perard.uk.xensource.com> References: <20190130161948.15888-1-paul.durrant@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190130161948.15888-1-paul.durrant@citrix.com> Subject: Re: [Qemu-devel] [PATCH v2] xen-block: handle resize callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, xen-devel@lists.xenproject.org, Stefan Hajnoczi , Stefano Stabellini , Kevin Wolf , Max Reitz On Wed, Jan 30, 2019 at 04:19:48PM +0000, Paul Durrant wrote: > Some frontend drivers will handle dynamic resizing of PV disks, so set up > the BlockDevOps resize_cb() method during xen_block_realize() to allow > this to be done. > > Signed-off-by: Paul Durrant > --- > + /* > + * Mimic the behaviour of Linux xen-blkback and re-write the state > + * to trigger the frontend watch. > + */ > + xen_device_backend_set_state(xendev, backend_state); :(, that function doesn't write the state again if it hasn't changed. So in my testing, Linux never did anything. -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH v2] xen-block: handle resize callback Date: Thu, 31 Jan 2019 15:20:42 +0000 Message-ID: <20190131152042.GF2306@perard.uk.xensource.com> References: <20190130161948.15888-1-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gpEBJ-0007XG-7K for xen-devel@lists.xenproject.org; Thu, 31 Jan 2019 15:23:09 +0000 Content-Disposition: inline In-Reply-To: <20190130161948.15888-1-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKYW4gMzAsIDIwMTkgYXQgMDQ6MTk6NDhQTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+IFNvbWUgZnJvbnRlbmQgZHJpdmVycyB3aWxsIGhhbmRsZSBkeW5hbWljIHJlc2l6aW5n IG9mIFBWIGRpc2tzLCBzbyBzZXQgdXAKPiB0aGUgQmxvY2tEZXZPcHMgcmVzaXplX2NiKCkgbWV0 aG9kIGR1cmluZyB4ZW5fYmxvY2tfcmVhbGl6ZSgpIHRvIGFsbG93Cj4gdGhpcyB0byBiZSBkb25l Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5j b20+Cj4gLS0tCgoKPiArICAgIC8qCj4gKyAgICAgKiBNaW1pYyB0aGUgYmVoYXZpb3VyIG9mIExp bnV4IHhlbi1ibGtiYWNrIGFuZCByZS13cml0ZSB0aGUgc3RhdGUKPiArICAgICAqIHRvIHRyaWdn ZXIgdGhlIGZyb250ZW5kIHdhdGNoLgo+ICsgICAgICovCj4gKyAgICB4ZW5fZGV2aWNlX2JhY2tl bmRfc2V0X3N0YXRlKHhlbmRldiwgYmFja2VuZF9zdGF0ZSk7Cgo6KCwgdGhhdCBmdW5jdGlvbiBk b2Vzbid0IHdyaXRlIHRoZSBzdGF0ZSBhZ2FpbiBpZiBpdCBoYXNuJ3QgY2hhbmdlZC4KU28gaW4g bXkgdGVzdGluZywgTGludXggbmV2ZXIgZGlkIGFueXRoaW5nLgoKLS0gCkFudGhvbnkgUEVSQVJE CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2 ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xp c3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs