All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
	Johannes Berg <johannes.berg@intel.com>,
	Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 02/21] iwlwifi: mvm: remove redundant condition
Date: Thu, 31 Jan 2019 22:21:47 +0200	[thread overview]
Message-ID: <20190131202206.15903-3-luca@coelho.fi> (raw)
In-Reply-To: <20190131202206.15903-1-luca@coelho.fi>

From: Johannes Berg <johannes.berg@intel.com>

In iwl_mvm_sta_alloc_queue_tvqm(), we know that we have a
station, so no need to check it.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
index 3ea39bb533e8..27839c10d5e3 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
@@ -791,11 +791,9 @@ static int iwl_mvm_sta_alloc_queue_tvqm(struct iwl_mvm *mvm,
 	if (queue < 0)
 		return queue;
 
-	if (sta) {
-		mvmtxq->txq_id = queue;
-		mvm->tvqm_info[queue].txq_tid = tid;
-		mvm->tvqm_info[queue].sta_id = mvmsta->sta_id;
-	}
+	mvmtxq->txq_id = queue;
+	mvm->tvqm_info[queue].txq_tid = tid;
+	mvm->tvqm_info[queue].sta_id = mvmsta->sta_id;
 
 	IWL_DEBUG_TX_QUEUES(mvm, "Allocated queue is %d\n", queue);
 
-- 
2.20.1


  parent reply	other threads:[~2019-01-31 20:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31 20:21 [PATCH 00/21] iwlwifi: updates intended for v5.1 2019-01-31 Luca Coelho
2019-01-31 20:21 ` [PATCH 01/21] iwlwifi: mvm: limit AMSDU size to 8K Luca Coelho
2019-01-31 20:21 ` Luca Coelho [this message]
2019-01-31 20:21 ` [PATCH 03/21] iwlwifi: mvm: add tlc command name to output Luca Coelho
2019-01-31 20:21 ` [PATCH 04/21] iwlwifi: mvm: config mac ctxt to HE before TLC Luca Coelho
2019-01-31 20:21 ` [PATCH 05/21] iwlwifi: dvm: use %u for sscanf() into unsigned variable Luca Coelho
2019-01-31 20:21 ` [PATCH 06/21] iwlwifi: dbg_ini: remove redundant dram buffer allocation Luca Coelho
2019-01-31 20:21 ` [PATCH 07/21] iwlwifi: mvm: add HE TB PPDU SIG-A BW to radiotap Luca Coelho
2019-02-06 18:11   ` Kalle Valo
2019-02-06 19:05     ` Johannes Berg
2019-02-07  9:33       ` Kalle Valo
2019-01-31 20:21 ` [PATCH 08/21] iwlwifi: move config structs to C file Luca Coelho
2019-01-31 20:21 ` [PATCH 09/21] iwlwifi: mvm: add description to second BAD_COMMAND assert number Luca Coelho
2019-01-31 20:21 ` [PATCH 10/21] iwlwifi: mvm: don't hide HE radiotap data in SKB Luca Coelho
2019-01-31 20:21 ` [PATCH 11/21] iwlwifi: mvm: support absolute thresholds in bf configuration Luca Coelho
2019-01-31 20:21 ` [PATCH 12/21] iwlwifi: mvm: fix RSS config command Luca Coelho
2019-01-31 20:21 ` [PATCH 13/21] iwlwifi: dbg_ini: align struct iwl_fw_ini_region_cfg to the FW Luca Coelho
2019-01-31 20:21 ` [PATCH 14/21] iwlwifi: dbg_ini: create new dump flow and implement prph dump Luca Coelho
2019-01-31 20:22 ` [PATCH 15/21] iwlwifi: dbg_ini: implement csr memory dump Luca Coelho
2019-01-31 20:22 ` [PATCH 16/21] iwlwifi: dbg_ini: implement device internal " Luca Coelho
2019-01-31 20:22 ` [PATCH 17/21] iwlwifi: dbg_ini: implement paging " Luca Coelho
2019-01-31 20:22 ` [PATCH 18/21] iwlwifi: fix send hcmd timeout recovery flow Luca Coelho
2019-01-31 20:22 ` [PATCH 19/21] iwlwifi: refactor NIC init sequence Luca Coelho
2019-01-31 20:22 ` [PATCH 20/21] iwlwifi: mvm: fix RFH config command with >=10 CPUs Luca Coelho
2019-01-31 20:22 ` [PATCH 21/21] iwlwifi: implement BISR HW workaround for 22260 devices Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190131202206.15903-3-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=johannes.berg@intel.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.