All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: "Tobin C. Harding" <tobin@kernel.org>
Cc: Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab: Increase width of first /proc/slabinfo column
Date: Thu, 31 Jan 2019 18:43:10 -0800	[thread overview]
Message-ID: <20190201024310.GC26359@bombadil.infradead.org> (raw)
In-Reply-To: <20190201004242.7659-1-tobin@kernel.org>

On Fri, Feb 01, 2019 at 11:42:42AM +1100, Tobin C. Harding wrote:
> Currently when displaying /proc/slabinfo if any cache names are too long
> then the output columns are not aligned.  We could do something fancy to
> get the maximum length of any cache name in the system or we could just
> increase the hardcoded width.  Currently it is 17 characters.  Monitors
> are wide these days so lets just increase it to 30 characters.

I had a proposal some time ago to turn the slab name from being kmalloced
to being an inline 16 bytes (with some fun hacks for cgroups).  I think
that's a better approach than permitting such long names.  For example,
ext4_allocation_context could be shortened to ext4_alloc_ctx without
losing any expressivity.

Let me know if you can't find that and I'll try to dig it up.

  parent reply	other threads:[~2019-02-01  2:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01  0:42 [PATCH] mm/slab: Increase width of first /proc/slabinfo column Tobin C. Harding
2019-02-01  0:58 ` Tobin C. Harding
2019-02-01  1:13   ` Andrew Morton
2019-02-01  2:56     ` Tobin C. Harding
2019-02-01  2:34 ` Christopher Lameter
2019-02-01  2:34   ` Christopher Lameter
2019-02-02  6:47   ` Pekka Enberg
2019-02-01  2:43 ` Matthew Wilcox [this message]
2019-02-01  2:58   ` Tobin C. Harding
2019-02-01 22:03   ` Andrew Morton
2019-02-04  5:55     ` Tobin C. Harding
2019-02-04  1:35   ` Tobin C. Harding
2019-02-02  3:27 ` Joe Perches
2019-02-02  3:27   ` Joe Perches
2019-02-03 23:34   ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190201024310.GC26359@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=tobin@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.