From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF28C282D8 for ; Fri, 1 Feb 2019 06:51:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6630F20870 for ; Fri, 1 Feb 2019 06:51:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728273AbfBAGvT (ORCPT ); Fri, 1 Feb 2019 01:51:19 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:57048 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbfBAGvT (ORCPT ); Fri, 1 Feb 2019 01:51:19 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gpSfT-0000DF-PE; Fri, 01 Feb 2019 14:51:15 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gpSfT-0005o8-Li; Fri, 01 Feb 2019 14:51:15 +0800 Date: Fri, 1 Feb 2019 14:51:15 +0800 From: Herbert Xu To: Masahiro Yamada Cc: linux-crypto@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: bcm: remove -I. header search path and unused macro define Message-ID: <20190201065115.kt5pd3aj64jax2zg@gondor.apana.org.au> References: <1548396469-13395-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548396469-13395-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jan 25, 2019 at 03:07:48PM +0900, Masahiro Yamada wrote: > The header search path -I. in kernel Makefiles is very suspicious; > it allows the compiler to search for headers in the top of $(srctree), > where obviously no header file exists. > > 'git grep BCMDRIVER' has no hit. So, this macro is not referenced. > > I was able to build this driver without the extra compiler options. > > Signed-off-by: Masahiro Yamada > --- > > drivers/crypto/bcm/Makefile | 2 -- > 1 file changed, 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt