From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE50FC282D8 for ; Sat, 2 Feb 2019 00:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C34E21872 for ; Sat, 2 Feb 2019 00:15:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="EwXys90F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726490AbfBBAPY (ORCPT ); Fri, 1 Feb 2019 19:15:24 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:41892 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725915AbfBBAPY (ORCPT ); Fri, 1 Feb 2019 19:15:24 -0500 Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.16.0.27/8.16.0.27) with SMTP id x1204uEF009641 for ; Fri, 1 Feb 2019 16:15:22 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=facebook; bh=ry6zFIK8ilpMy5w53YdQ45wPpPDi9F7Ri8LhggxSTFY=; b=EwXys90FSZRBd8jJWGfvYBSA5b1bF0ZlCplbYKtujiaWm782lXnOhq4WbHxYb2TUpue5 zMOFw2bQAUQfAiX8ZPQysH53YMJ5NoSjHYMQtu8La++utTR0nBvObzCMtjhJwhnt4GDI OIE8U4rPwBUrFuRaGCCaIh34juypBn1MA7Q= Received: from mail.thefacebook.com ([199.201.64.23]) by m0001303.ppops.net with ESMTP id 2qcue48x74-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Fri, 01 Feb 2019 16:14:36 -0800 Received: from mx-out.facebook.com (2620:10d:c081:10::13) by mail.thefacebook.com (2620:10d:c081:35::130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.1.1531.3; Fri, 1 Feb 2019 16:14:17 -0800 Received: by devbig003.ftw2.facebook.com (Postfix, from userid 128203) id B3C083702AB9; Fri, 1 Feb 2019 16:14:13 -0800 (PST) Smtp-Origin-Hostprefix: devbig From: Yonghong Song Smtp-Origin-Hostname: devbig003.ftw2.facebook.com To: Arnaldo Carvalho de Melo , Magnus Karlsson , CC: Alexei Starovoitov , Daniel Borkmann , , Yonghong Song Smtp-Origin-Cluster: ftw2c04 Subject: [PATCH bpf-next v4 0/3] tools/bpf: changes of libbpf debug interfaces Date: Fri, 1 Feb 2019 16:14:13 -0800 Message-ID: <20190202001413.3178000-1-yhs@fb.com> X-Mailer: git-send-email 2.17.1 X-FB-Internal: Safe MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-01_18:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org These are patches responding to my comments for Magnus's patch (https://patchwork.ozlabs.org/patch/1032848/). The goal is to make pr_* macros available to other C files than libbpf.c, and to simplify API function libbpf_set_print(). Specifically, Patch #1 used global functions to facilitate pr_* macros in the header files so they are available in different C files. Patch #2 removes the global function libbpf_print_level_available() which is added in Patch 1. Patch #3 simplified libbpf_set_print() which takes only one print function with a debug level argument among others. Changelogs: v3 -> v4: . rename libbpf internal header util.h to libbpf_util.h . rename libbpf internal function libbpf_debug_print() to libbpf_print() v2 -> v3: . bailed out earlier in libbpf_debug_print() if __libbpf_pr is NULL . added missing LIBBPF_DEBUG level check in libbpf.c __base_pr(). v1 -> v2: . Renamed global function libbpf_dprint() to libbpf_debug_print() to be more expressive. . Removed libbpf_dprint_level_available() as it is used only once in btf.c and we can remove it by optimizing for common cases. Yonghong Song (3): tools/bpf: move libbpf pr_* debug print functions to headers tools/bpf: print out btf log at LIBBPF_WARN level tools/bpf: simplify libbpf API function libbpf_set_print() tools/lib/bpf/btf.c | 110 +++++++++--------- tools/lib/bpf/btf.h | 7 +- tools/lib/bpf/libbpf.c | 47 ++++---- tools/lib/bpf/libbpf.h | 20 ++-- tools/lib/bpf/libbpf_util.h | 30 +++++ tools/lib/bpf/test_libbpf.cpp | 4 +- tools/perf/util/bpf-loader.c | 32 ++--- tools/testing/selftests/bpf/test_btf.c | 7 +- .../testing/selftests/bpf/test_libbpf_open.c | 36 +++--- tools/testing/selftests/bpf/test_progs.c | 20 +++- 10 files changed, 171 insertions(+), 142 deletions(-) create mode 100644 tools/lib/bpf/libbpf_util.h -- 2.17.1