From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06BF8C282DA for ; Sun, 3 Feb 2019 14:16:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C925B2084A for ; Sun, 3 Feb 2019 14:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549203392; bh=fqlKxu6hC/LlcgpY7oFMpeGGedZGIO72wvaf6VO46aA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=W59Yu7iBxC/C85nOx/nqRN+rU3TEyo1iks80Q4XqB22Fihg2su+7V/LhljWrZ5nbp pLISDg/f/hvlWMMMl7serIlM7u2f/63VF66SxnHG5XDuMZ078l47OJx0DTFRdngytw xRtWDqpla5suGAtICLhdEFhN5XycS34fTYBD+eck= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728117AbfBCOQS (ORCPT ); Sun, 3 Feb 2019 09:16:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:45754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726709AbfBCOQR (ORCPT ); Sun, 3 Feb 2019 09:16:17 -0500 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C9342084A; Sun, 3 Feb 2019 14:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549203376; bh=fqlKxu6hC/LlcgpY7oFMpeGGedZGIO72wvaf6VO46aA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nc1vYNH2aiPeOvUIMecerWMyQFFu2HFGF4st653jxRukQ+zYIXWHYS/cwGAN0LduS VOTfAAQ0Ub4IriSrxnVCP5BClu0iZ42xGibKkjrBHVFlvxVSqlGUqH5gsNPHdKqubJ 7Mexw2WmFGqOPUDf5LiInN5OqnLhyt/ZSkNnmuhE= Date: Sun, 3 Feb 2019 15:16:04 +0100 From: Boris Brezillon To: Paul Cercueil Cc: David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Rob Herring , Mark Rutland , Miquel Raynal , Harvey Hunt , Mathieu Malaterre , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 9/9] mtd: rawnand: jz4780-bch: Add support for the JZ4740 Message-ID: <20190203151604.23061e2a@bbrezillon> In-Reply-To: <1549202293.1950.2@crapouillou.net> References: <20190202231926.2444-1-paul@crapouillou.net> <20190202231926.2444-10-paul@crapouillou.net> <20190203083505.4dc52278@bbrezillon> <1549202293.1950.2@crapouillou.net> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 03 Feb 2019 10:58:13 -0300 Paul Cercueil wrote: > Le dim. 3 f=C3=A9vr. 2019 =C3=A0 4:35, Boris Brezillon =20 > a =C3=A9crit : > > On Sat, 2 Feb 2019 20:19:26 -0300 > > Paul Cercueil wrote: > > =20 > >> Add the backend code for the jz4780-bch driver to support the JZ4740 > >> SoC from Ingenic. > >>=20 > >> Signed-off-by: Paul Cercueil > >> --- > >>=20 > >> Changes: > >>=20 > >> v2: New patch > >>=20 > >> drivers/mtd/nand/raw/ingenic/Makefile | 2 +- > >> drivers/mtd/nand/raw/ingenic/jz4740_bch.c | 173=20 > >> ++++++++++++++++++ > >> .../mtd/nand/raw/ingenic/jz4780_bch_common.c | 1 + > >> .../nand/raw/ingenic/jz4780_bch_internal.h | 1 + > >> 4 files changed, 176 insertions(+), 1 deletion(-) > >> create mode 100644 drivers/mtd/nand/raw/ingenic/jz4740_bch.c > >>=20 > >> diff --git a/drivers/mtd/nand/raw/ingenic/Makefile=20 > >> b/drivers/mtd/nand/raw/ingenic/Makefile > >> index f38b467490cf..d16c96113a93 100644 > >> --- a/drivers/mtd/nand/raw/ingenic/Makefile > >> +++ b/drivers/mtd/nand/raw/ingenic/Makefile > >> @@ -1,3 +1,3 @@ > >> obj-$(CONFIG_MTD_NAND_JZ4740) +=3D jz4740_nand.o > >> obj-$(CONFIG_MTD_NAND_JZ4780) +=3D jz4780_nand.o jz4780_bch_common.o= =20 > >> \ > >> - jz4780_bch.o jz4725b_bch.o > >> + jz4780_bch.o jz4725b_bch.o jz4740_bch.o =20 > >=20 > > I still don't see the point of the jz4780_bch_common/jz47xxx_bch > > separation. You seem to always embed all objects anyway, so you can > > just put the code for both engines in the same source file and decide > > which one to use based on the compat (which you already do anyway). =20 >=20 > Each SoC has a different set of registers for the BCH hardware. I can=20 > try to > cram everything into one file, but it won't be that much cleaner. Then maybe they deserve separate drivers/modules. BTW, didn't you say that one IP uses Reed-Salomon instead of BCH. I'd suggest prefixing structs and functions with jz47xx_ecc instead of jz47xx_bch and naming the common part jz47xx_ecc.c to reflect that. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 9/9] mtd: rawnand: jz4780-bch: Add support for the JZ4740 Date: Sun, 3 Feb 2019 15:16:04 +0100 Message-ID: <20190203151604.23061e2a@bbrezillon> References: <20190202231926.2444-1-paul@crapouillou.net> <20190202231926.2444-10-paul@crapouillou.net> <20190203083505.4dc52278@bbrezillon> <1549202293.1950.2@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1549202293.1950.2@crapouillou.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Paul Cercueil Cc: Mark Rutland , devicetree@vger.kernel.org, Mathieu Malaterre , Richard Weinberger , linux-kernel@vger.kernel.org, Marek Vasut , Rob Herring , linux-mtd@lists.infradead.org, Harvey Hunt , Miquel Raynal , Brian Norris , David Woodhouse List-Id: devicetree@vger.kernel.org T24gU3VuLCAwMyBGZWIgMjAxOSAxMDo1ODoxMyAtMDMwMApQYXVsIENlcmN1ZWlsIDxwYXVsQGNy YXBvdWlsbG91Lm5ldD4gd3JvdGU6Cgo+IExlIGRpbS4gMyBmw6l2ci4gMjAxOSDDoCA0OjM1LCBC b3JpcyBCcmV6aWxsb24gPGJicmV6aWxsb25Aa2VybmVsLm9yZz4gCj4gYSDDqWNyaXQgOgo+ID4g T24gU2F0LCAgMiBGZWIgMjAxOSAyMDoxOToyNiAtMDMwMAo+ID4gUGF1bCBDZXJjdWVpbCA8cGF1 bEBjcmFwb3VpbGxvdS5uZXQ+IHdyb3RlOgo+ID4gICAKPiA+PiAgQWRkIHRoZSBiYWNrZW5kIGNv ZGUgZm9yIHRoZSBqejQ3ODAtYmNoIGRyaXZlciB0byBzdXBwb3J0IHRoZSBKWjQ3NDAKPiA+PiAg U29DIGZyb20gSW5nZW5pYy4KPiA+PiAKPiA+PiAgU2lnbmVkLW9mZi1ieTogUGF1bCBDZXJjdWVp bCA8cGF1bEBjcmFwb3VpbGxvdS5uZXQ+Cj4gPj4gIC0tLQo+ID4+IAo+ID4+ICBDaGFuZ2VzOgo+ ID4+IAo+ID4+ICB2MjogTmV3IHBhdGNoCj4gPj4gCj4gPj4gICBkcml2ZXJzL210ZC9uYW5kL3Jh dy9pbmdlbmljL01ha2VmaWxlICAgICAgICAgfCAgIDIgKy0KPiA+PiAgIGRyaXZlcnMvbXRkL25h bmQvcmF3L2luZ2VuaWMvano0NzQwX2JjaC5jICAgICB8IDE3MyAKPiA+PiArKysrKysrKysrKysr KysrKysKPiA+PiAgIC4uLi9tdGQvbmFuZC9yYXcvaW5nZW5pYy9qejQ3ODBfYmNoX2NvbW1vbi5j ICB8ICAgMSArCj4gPj4gICAuLi4vbmFuZC9yYXcvaW5nZW5pYy9qejQ3ODBfYmNoX2ludGVybmFs LmggICAgfCAgIDEgKwo+ID4+ICAgNCBmaWxlcyBjaGFuZ2VkLCAxNzYgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQo+ID4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbXRkL25hbmQv cmF3L2luZ2VuaWMvano0NzQwX2JjaC5jCj4gPj4gCj4gPj4gIGRpZmYgLS1naXQgYS9kcml2ZXJz L210ZC9uYW5kL3Jhdy9pbmdlbmljL01ha2VmaWxlIAo+ID4+IGIvZHJpdmVycy9tdGQvbmFuZC9y YXcvaW5nZW5pYy9NYWtlZmlsZQo+ID4+ICBpbmRleCBmMzhiNDY3NDkwY2YuLmQxNmM5NjExM2E5 MyAxMDA2NDQKPiA+PiAgLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvaW5nZW5pYy9NYWtlZmls ZQo+ID4+ICArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9pbmdlbmljL01ha2VmaWxlCj4gPj4g IEBAIC0xLDMgKzEsMyBAQAo+ID4+ICAgb2JqLSQoQ09ORklHX01URF9OQU5EX0paNDc0MCkgKz0g ano0NzQwX25hbmQubwo+ID4+ICAgb2JqLSQoQ09ORklHX01URF9OQU5EX0paNDc4MCkgKz0gano0 NzgwX25hbmQubyBqejQ3ODBfYmNoX2NvbW1vbi5vIAo+ID4+IFwKPiA+PiAgLQkJCQkgano0Nzgw X2JjaC5vIGp6NDcyNWJfYmNoLm8KPiA+PiAgKwkJCQkgano0NzgwX2JjaC5vIGp6NDcyNWJfYmNo Lm8gano0NzQwX2JjaC5vICAKPiA+IAo+ID4gSSBzdGlsbCBkb24ndCBzZWUgdGhlIHBvaW50IG9m IHRoZSBqejQ3ODBfYmNoX2NvbW1vbi9qejQ3eHh4X2JjaAo+ID4gc2VwYXJhdGlvbi4gWW91IHNl ZW0gdG8gYWx3YXlzIGVtYmVkIGFsbCBvYmplY3RzIGFueXdheSwgc28geW91IGNhbgo+ID4ganVz dCBwdXQgdGhlIGNvZGUgZm9yIGJvdGggZW5naW5lcyBpbiB0aGUgc2FtZSBzb3VyY2UgZmlsZSBh bmQgZGVjaWRlCj4gPiB3aGljaCBvbmUgdG8gdXNlIGJhc2VkIG9uIHRoZSBjb21wYXQgKHdoaWNo IHlvdSBhbHJlYWR5IGRvIGFueXdheSkuICAKPiAKPiBFYWNoIFNvQyBoYXMgYSBkaWZmZXJlbnQg c2V0IG9mIHJlZ2lzdGVycyBmb3IgdGhlIEJDSCBoYXJkd2FyZS4gSSBjYW4gCj4gdHJ5IHRvCj4g Y3JhbSBldmVyeXRoaW5nIGludG8gb25lIGZpbGUsIGJ1dCBpdCB3b24ndCBiZSB0aGF0IG11Y2gg Y2xlYW5lci4KClRoZW4gbWF5YmUgdGhleSBkZXNlcnZlIHNlcGFyYXRlIGRyaXZlcnMvbW9kdWxl cy4KCkJUVywgZGlkbid0IHlvdSBzYXkgdGhhdCBvbmUgSVAgdXNlcyBSZWVkLVNhbG9tb24gaW5z dGVhZCBvZiBCQ0guIEknZApzdWdnZXN0IHByZWZpeGluZyBzdHJ1Y3RzIGFuZCBmdW5jdGlvbnMg d2l0aCBqejQ3eHhfZWNjIGluc3RlYWQgb2YKano0N3h4X2JjaCBhbmQgbmFtaW5nIHRoZSBjb21t b24gcGFydCBqejQ3eHhfZWNjLmMgdG8gcmVmbGVjdCB0aGF0LgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9u IG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LW10ZC8K