From: David Miller <davem@davemloft.net>
To: thierry.reding@gmail.com
Cc: hkallweit1@gmail.com, andrew@lunn.ch, nic_swsd@realtek.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing
Date: Mon, 04 Feb 2019 19:20:40 -0800 (PST) [thread overview]
Message-ID: <20190204.192040.1074738183781998611.davem@davemloft.net> (raw)
In-Reply-To: <20190204164213.30727-2-thierry.reding@gmail.com>
From: Thierry Reding <thierry.reding@gmail.com>
Date: Mon, 4 Feb 2019 17:42:13 +0100
> @@ -7316,7 +7325,7 @@ static int rtl_get_ether_clk(struct rtl8169_private *tp)
> static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> {
> const struct rtl_cfg_info *cfg = rtl_cfg_infos + ent->driver_data;
> - u8 mac_addr[ETH_ALEN] __aligned(4) = {};
> + u8 mac_addr[ETH_ALEN] = {};
> struct rtl8169_private *tp;
I agree with Heiner, you have to provide at least 2 byte alignment for this
buffer due to the reasons he stated.
next prev parent reply other threads:[~2019-02-05 18:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 16:42 [PATCH v2 1/2] r8169: Load MAC address from device tree if present Thierry Reding
2019-02-04 16:42 ` [PATCH v2 2/2] r8169: Avoid pointer aliasing Thierry Reding
2019-02-04 16:59 ` Andrew Lunn
2019-02-04 18:44 ` Heiner Kallweit
2019-02-05 3:20 ` David Miller [this message]
2019-02-05 18:42 ` Joe Perches
2019-02-05 19:14 ` David Miller
2019-02-05 19:19 ` Joe Perches
2019-02-06 7:25 ` Michal Kubecek
2019-02-05 20:04 ` Eric Dumazet
2019-02-05 20:18 ` Joe Perches
2019-02-05 20:23 ` Eric Dumazet
2019-02-05 20:23 ` Heiner Kallweit
2019-02-04 19:30 ` [PATCH v2 1/2] r8169: Load MAC address from device tree if present Heiner Kallweit
2019-02-06 2:27 [PATCH v2 2/2] r8169: Avoid pointer aliasing Paul Zimmerman
2019-02-06 2:52 ` Joe Perches
2019-02-06 3:25 ` Paul Zimmerman
2019-02-06 3:49 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204.192040.1074738183781998611.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.