All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/3] slub: Do trivial comments fixes
@ 2019-02-04  0:57 Tobin C. Harding
  2019-02-04  0:57 ` [PATCH v2 1/3] slub: Capitialize comment string Tobin C. Harding
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Tobin C. Harding @ 2019-02-04  0:57 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Tobin C. Harding, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Christopher Lameter, William Kucharski, linux-mm, linux-kernel

Hi,

Here is v2 of the comments fixes [to single SLUB header file].


thanks,
Tobin.


Changes since v1:

 - Re-order patches (put the easy acceptable ones from v1 first).
 - Do grammar/punctuation fixes thoroughly (thanks William).
 - Send the set to Andrew instead of Christopher since we are going in
   through his tree.

Tobin C. Harding (3):
  slub: Capitialize comment string
  slub: Use C89 comment style
  slub: Correct grammar/punctuation in comments

 include/linux/slub_def.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 1/3] slub: Capitialize comment string
  2019-02-04  0:57 [PATCH v2 0/3] slub: Do trivial comments fixes Tobin C. Harding
@ 2019-02-04  0:57 ` Tobin C. Harding
  2019-02-04  0:57 ` [PATCH v2 2/3] slub: Use C89 comment style Tobin C. Harding
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Tobin C. Harding @ 2019-02-04  0:57 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Tobin C. Harding, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Christopher Lameter, William Kucharski, linux-mm, linux-kernel

SLUB include file has particularly clean comments, one comment string is
holding us back.

Capitialize comment string.

Signed-off-by: Tobin C. Harding <tobin@kernel.org>
---
 include/linux/slub_def.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h
index 3a1a1dbc6f49..541b082ffcaf 100644
--- a/include/linux/slub_def.h
+++ b/include/linux/slub_def.h
@@ -110,7 +110,7 @@ struct kmem_cache {
 #endif
 #ifdef CONFIG_MEMCG
 	struct memcg_cache_params memcg_params;
-	/* for propagation, maximum size of a stored attr */
+	/* For propagation, maximum size of a stored attr */
 	unsigned int max_attr_size;
 #ifdef CONFIG_SYSFS
 	struct kset *memcg_kset;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 2/3] slub: Use C89 comment style
  2019-02-04  0:57 [PATCH v2 0/3] slub: Do trivial comments fixes Tobin C. Harding
  2019-02-04  0:57 ` [PATCH v2 1/3] slub: Capitialize comment string Tobin C. Harding
@ 2019-02-04  0:57 ` Tobin C. Harding
  2019-02-04  0:57 ` [PATCH v2 3/3] slub: Correct grammar/punctuation in comments Tobin C. Harding
  2019-02-04 23:04 ` [PATCH v2 0/3] slub: Do trivial comments fixes Andrew Morton
  3 siblings, 0 replies; 7+ messages in thread
From: Tobin C. Harding @ 2019-02-04  0:57 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Tobin C. Harding, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Christopher Lameter, William Kucharski, linux-mm, linux-kernel

SLUB include file uses a c99 comment style.  In line with the rest of
the kernel lets use c89 comment style.

Use C89 comment style.

Signed-off-by: Tobin C. Harding <tobin@kernel.org>
---
 include/linux/slub_def.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h
index 541b082ffcaf..a3f1fc7e52a6 100644
--- a/include/linux/slub_def.h
+++ b/include/linux/slub_def.h
@@ -151,7 +151,7 @@ struct kmem_cache {
 #else
 #define slub_cpu_partial(s)		(0)
 #define slub_set_cpu_partial(s, n)
-#endif // CONFIG_SLUB_CPU_PARTIAL
+#endif /* CONFIG_SLUB_CPU_PARTIAL */
 
 #ifdef CONFIG_SYSFS
 #define SLAB_SUPPORTS_SYSFS
-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 3/3] slub: Correct grammar/punctuation in comments
  2019-02-04  0:57 [PATCH v2 0/3] slub: Do trivial comments fixes Tobin C. Harding
  2019-02-04  0:57 ` [PATCH v2 1/3] slub: Capitialize comment string Tobin C. Harding
  2019-02-04  0:57 ` [PATCH v2 2/3] slub: Use C89 comment style Tobin C. Harding
@ 2019-02-04  0:57 ` Tobin C. Harding
  2019-02-04 23:04 ` [PATCH v2 0/3] slub: Do trivial comments fixes Andrew Morton
  3 siblings, 0 replies; 7+ messages in thread
From: Tobin C. Harding @ 2019-02-04  0:57 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Tobin C. Harding, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Christopher Lameter, William Kucharski, linux-mm, linux-kernel

Currently there are a few minor grammatical errors in the comments.
While we are at it we can fix punctuation to be correct and uniform
also.

Correct grammar/punctuation in comments.

Signed-off-by: Tobin C. Harding <tobin@kernel.org>
---
 include/linux/slub_def.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h
index a3f1fc7e52a6..d2153789bd9f 100644
--- a/include/linux/slub_def.h
+++ b/include/linux/slub_def.h
@@ -81,12 +81,12 @@ struct kmem_cache_order_objects {
  */
 struct kmem_cache {
 	struct kmem_cache_cpu __percpu *cpu_slab;
-	/* Used for retriving partial slabs etc */
+	/* Used for retrieving partial slabs, etc. */
 	slab_flags_t flags;
 	unsigned long min_partial;
-	unsigned int size;	/* The size of an object including meta data */
-	unsigned int object_size;/* The size of an object without meta data */
-	unsigned int offset;	/* Free pointer offset. */
+	unsigned int size;	/* The size of an object including metadata */
+	unsigned int object_size;/* The size of an object without metadata */
+	unsigned int offset;	/* Free pointer offset */
 #ifdef CONFIG_SLUB_CPU_PARTIAL
 	/* Number of per cpu partial objects to keep around */
 	unsigned int cpu_partial;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 0/3] slub: Do trivial comments fixes
  2019-02-04  0:57 [PATCH v2 0/3] slub: Do trivial comments fixes Tobin C. Harding
                   ` (2 preceding siblings ...)
  2019-02-04  0:57 ` [PATCH v2 3/3] slub: Correct grammar/punctuation in comments Tobin C. Harding
@ 2019-02-04 23:04 ` Andrew Morton
  2019-02-05  4:05   ` Tobin C. Harding
  3 siblings, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2019-02-04 23:04 UTC (permalink / raw)
  To: Tobin C. Harding
  Cc: Pekka Enberg, David Rientjes, Joonsoo Kim, Christopher Lameter,
	William Kucharski, linux-mm, linux-kernel

On Mon,  4 Feb 2019 11:57:10 +1100 "Tobin C. Harding" <tobin@kernel.org> wrote:

> Here is v2 of the comments fixes [to single SLUB header file]

Thanks. I think I'll put these into a single patch.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 0/3] slub: Do trivial comments fixes
  2019-02-04 23:04 ` [PATCH v2 0/3] slub: Do trivial comments fixes Andrew Morton
@ 2019-02-05  4:05   ` Tobin C. Harding
  2019-02-06 22:48     ` William Kucharski
  0 siblings, 1 reply; 7+ messages in thread
From: Tobin C. Harding @ 2019-02-05  4:05 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Tobin C. Harding, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Christopher Lameter, William Kucharski, linux-mm, linux-kernel

On Mon, Feb 04, 2019 at 03:04:10PM -0800, Andrew Morton wrote:
> On Mon,  4 Feb 2019 11:57:10 +1100 "Tobin C. Harding" <tobin@kernel.org> wrote:
> 
> > Here is v2 of the comments fixes [to single SLUB header file]
> 
> Thanks. I think I'll put these into a single patch.

Awesome, thank you.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 0/3] slub: Do trivial comments fixes
  2019-02-05  4:05   ` Tobin C. Harding
@ 2019-02-06 22:48     ` William Kucharski
  0 siblings, 0 replies; 7+ messages in thread
From: William Kucharski @ 2019-02-06 22:48 UTC (permalink / raw)
  To: Tobin C. Harding
  Cc: Andrew Morton, Tobin C. Harding, Pekka Enberg, David Rientjes,
	Joonsoo Kim, Christopher Lameter, linux-mm, linux-kernel


If you need it:

Reviewed-by: William Kucharski <william.kucharski@oracle.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-02-06 22:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-04  0:57 [PATCH v2 0/3] slub: Do trivial comments fixes Tobin C. Harding
2019-02-04  0:57 ` [PATCH v2 1/3] slub: Capitialize comment string Tobin C. Harding
2019-02-04  0:57 ` [PATCH v2 2/3] slub: Use C89 comment style Tobin C. Harding
2019-02-04  0:57 ` [PATCH v2 3/3] slub: Correct grammar/punctuation in comments Tobin C. Harding
2019-02-04 23:04 ` [PATCH v2 0/3] slub: Do trivial comments fixes Andrew Morton
2019-02-05  4:05   ` Tobin C. Harding
2019-02-06 22:48     ` William Kucharski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.