From: Katarzyna Dec <katarzyna.dec@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f
Date: Mon, 4 Feb 2019 10:48:07 +0100 [thread overview]
Message-ID: <20190204094807.GA10822@kdec5-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190202223630.15471-1-chris@chris-wilson.co.uk>
On Sat, Feb 02, 2019 at 10:36:30PM +0000, Chris Wilson wrote:
> A missing newline at the end of an assert, so add it for clarity in the
> error message.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
Have a nice day!
Kasia :)
> ---
> tests/i915/perf_pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
> index 391378139..c3993c417 100644
> --- a/tests/i915/perf_pmu.c
> +++ b/tests/i915/perf_pmu.c
> @@ -707,7 +707,7 @@ sema_wait(int gem_fd, const struct intel_execution_engine2 *e,
> } while (!obj_ptr[1]);
>
> igt_assert_f(igt_wait(pmu_read_single(fd) != val[0], 10, 1),
> - "sampling failed to start withing 10ms");
> + "sampling failed to start withing 10ms\n");
>
> val[0] = __pmu_read_single(fd, &ts[0]);
> slept = measured_usleep(batch_duration_ns / 1000);
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-02-04 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 22:36 [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f Chris Wilson
2019-02-02 22:36 ` [igt-dev] " Chris Wilson
2019-02-04 9:14 ` Tvrtko Ursulin
2019-02-04 9:14 ` [Intel-gfx] " Tvrtko Ursulin
2019-02-04 9:48 ` Katarzyna Dec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204094807.GA10822@kdec5-desk.ger.corp.intel.com \
--to=katarzyna.dec@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.