From mboxrd@z Thu Jan 1 00:00:00 1970 From: Abel Vesa Date: Mon, 4 Feb 2019 09:55:36 +0000 Subject: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support In-Reply-To: References: <1549039198-16674-1-git-send-email-abel.vesa@nxp.com> Message-ID: <20190204095535.zvpcvlvfi4uvd2mo@fsr-ub1664-175> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 19-02-02 07:50:28, Fabio Estevam wrote: > Hi Abel, > > On Fri, Feb 1, 2019 at 2:43 PM Abel Vesa wrote: > > > > The third version is here: > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.denx.de%2Fpipermail%2Fu-boot%2F2019-January%2F356903.html&data=02%7C01%7Cabel.vesa%40nxp.com%7Ca93c33315b5b492ca15308d688f3e275%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636846978387908349&sdata=wQrrLoMyouM5vdUlfXI325wqZYt4tTa5WTRJsgwMEz0%3D&reserved=0 > > > > So, this time I hope I got it right. Before, I was stupidly trying > > to put a fit in another fit without a really good reason. To my > > excuse, that was working even with the spl_image->os set to 0, > > bug which I (hope) I fixed in the first patch (a new one) > > of this series. > > I am happy with the entire series. > > One more question: do we get build error when the SPL gets larger than 64kB? If the SPL size (without the dtb appended) is larger then yes, the build fails. Trouble is if the SPL (without the dtb appended) is, lets say, 63kB and then the dtb is larger than 1kB. Then there is no mechanism in place to check that and it will just fail to boot without giving any clues why. But this is a totally unrelated problem from this patchset's point of view and I think it impacts all the platforms that support SPL with DM.