All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [RFC/PATCH 00/14] perf record: Add support to store data in directory
Date: Mon, 4 Feb 2019 12:41:44 +0100	[thread overview]
Message-ID: <20190204114144.GC18141@krava> (raw)
In-Reply-To: <6bf24b7d-2bd3-8091-cf49-363c91e4e864@linux.intel.com>

On Mon, Feb 04, 2019 at 02:29:56PM +0300, Alexey Budankov wrote:
> On 04.02.2019 13:36, Jiri Olsa wrote:
> > On Mon, Feb 04, 2019 at 01:12:11PM +0300, Alexey Budankov wrote:
> >>
> >> Hi,
> >>
> >> On 03.02.2019 18:30, Jiri Olsa wrote:
> >>> hi,
> >>> this patchset adds the --dir option to record command (and all
> >>> the other record command that overload cmd_record) that allows
> >>> the data to be stored in directory with multiple data files.
> >>>
> >>> It's next step for multiple threads implementation in record.
> >>> It's now possible to make directory data via --dir option, like:
> >>>
> >>>   $ perf record --dir perf bench sched messaging
> >>
> >> Is it possible to name data directory differently from perf.data 
> >> e.g. using --output option, like this?
> >>
> >>   $ perf record --output result_1 --dir perf bench sched messaging
> > 
> > 
> > yep, it's taken into account:
> > 
> > [jolsa@krava perf]$ ./perf record --output result_1 --dir ./perf bench sched messaging
> > Couldn't synthesize bpf events.
> > # Running 'sched/messaging' benchmark:
> > # 20 sender and receiver processes per group
> > # 10 groups == 400 processes run
> > 
> >      Total time: 0.177 [sec]
> > [ perf record: Woken up 1 times to write data ]
> > [ perf record: Captured and wrote 0.316 MB result_1 (7225 samples) ]
> > 
> > [jolsa@krava perf]$ ll result_1/
> > total 348
> > -rw-------. 1 jolsa jolsa 27624 Feb  4 11:35 data.0
> > -rw-------. 1 jolsa jolsa 56672 Feb  4 11:35 data.1
> > -rw-------. 1 jolsa jolsa 30824 Feb  4 11:35 data.2
> > -rw-------. 1 jolsa jolsa 49136 Feb  4 11:35 data.3
> > -rw-------. 1 jolsa jolsa 22712 Feb  4 11:35 data.4
> > -rw-------. 1 jolsa jolsa 53392 Feb  4 11:35 data.5
> > -rw-------. 1 jolsa jolsa 43352 Feb  4 11:35 data.6
> > -rw-------. 1 jolsa jolsa 46688 Feb  4 11:35 data.7
> > -rw-------. 1 jolsa jolsa  9068 Feb  4 11:35 header
> 
> Awesome. What do you think about having it like this:
> 
>   $ perf record --output result_1.data ... - writes data to a file
> 
>   $ perf record --dir result_1 ... - or even
>   $ perf record --output_dir result_1 ... - writes data into a directory
> 
> IMHO, this interface is simpler for a user.

yep, seems more convenient.. I'll add it

thanks,
jirka

  reply	other threads:[~2019-02-04 11:41 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-03 15:30 [RFC/PATCH 00/14] perf record: Add support to store data in directory Jiri Olsa
2019-02-03 15:30 ` [PATCH 01/14] perf tools: Make rm_rf to remove single file Jiri Olsa
2019-02-05 11:33   ` Alexey Budankov
2019-02-05 13:38     ` Jiri Olsa
2019-02-03 15:30 ` [PATCH 02/14] perf session: Add process callback to reader object Jiri Olsa
2019-02-03 15:30 ` [PATCH 03/14] perf data: Move size to struct perf_data_file Jiri Olsa
2019-02-03 15:30 ` [PATCH 04/14] perf data: Add global path holder Jiri Olsa
2019-02-03 15:30 ` [PATCH 05/14] perf data: Make check_backup work over directories Jiri Olsa
2019-02-03 15:30 ` [PATCH 06/14] perf data: Add perf_data__(create_dir|free_dir) functions Jiri Olsa
2019-02-05 11:52   ` Alexey Budankov
2019-02-05 13:42     ` Jiri Olsa
2019-02-05 13:46   ` Arnaldo Carvalho de Melo
2019-02-05 13:53     ` Jiri Olsa
2019-02-03 15:30 ` [PATCH 07/14] perf data: Add perf_data__open_dir_data function Jiri Olsa
2019-02-03 15:30 ` [PATCH 08/14] perf data: Add directory support Jiri Olsa
2019-02-03 15:30 ` [PATCH 09/14] perf data: Don't store auxtrace index for directory data file Jiri Olsa
2019-02-03 15:30 ` [PATCH 10/14] perf data: Add perf_data__update_dir function Jiri Olsa
2019-02-03 15:30 ` [PATCH 11/14] perf data: Make perf_data__size to work over directory Jiri Olsa
2019-02-03 15:30 ` [PATCH 12/14] perf session: Add __perf_session__process_dir_events function Jiri Olsa
2019-02-03 15:30 ` [PATCH 13/14] perf session: Add path to reader object Jiri Olsa
2019-02-03 15:30 ` [PATCH 14/14] perf record: Add --dir option to store data in directory Jiri Olsa
2019-02-05 12:36   ` Alexey Budankov
2019-02-05 13:51     ` Jiri Olsa
2019-02-04 10:12 ` [RFC/PATCH 00/14] perf record: Add support " Alexey Budankov
2019-02-04 10:36   ` Jiri Olsa
2019-02-04 11:29     ` Alexey Budankov
2019-02-04 11:41       ` Jiri Olsa [this message]
2019-02-04 18:56         ` Stephane Eranian
2019-02-04 19:27           ` Arnaldo Carvalho de Melo
2019-02-04 19:56             ` Alexey Budankov
2019-02-04 20:05             ` Stephane Eranian
2019-02-04 20:28               ` Jiri Olsa
2019-02-04 22:44                 ` Stephane Eranian
2019-02-05 13:37                   ` Jiri Olsa
2019-02-11 10:19                     ` Jiri Olsa
2019-02-11 18:34                       ` Stephane Eranian
2019-02-11 18:53                         ` Jiri Olsa
2019-02-11 19:32                           ` Arnaldo Carvalho de Melo
2019-02-11 20:18                             ` Jiri Olsa
2019-02-11 20:43                               ` Stephane Eranian
2019-02-14 11:34                                 ` Jiri Olsa
2019-02-14 12:57                                   ` Arnaldo Carvalho de Melo
2019-02-14 13:26                                     ` Jiri Olsa
2019-02-14 13:59                                       ` Arnaldo Carvalho de Melo
2019-02-14 21:30                                         ` Stephane Eranian
     [not found]                                           ` <CA+JHD90ssKi3CJ7yfCFTkrS8xwUsZhvd0t7cSCy1MF7TJ2XLYw@mail.gmail.com>
2019-02-14 21:39                                             ` Stephane Eranian
2019-02-11 18:55                         ` Arnaldo Carvalho de Melo
2019-02-11 19:30                           ` Stephane Eranian
2019-02-11 20:30                             ` Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190204114144.GC18141@krava \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexey.budankov@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.