From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A7D7C282C4 for ; Mon, 4 Feb 2019 17:44:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 502B520818 for ; Mon, 4 Feb 2019 17:44:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EZxTQ/YI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729012AbfBDRoT (ORCPT ); Mon, 4 Feb 2019 12:44:19 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:37040 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728963AbfBDRoT (ORCPT ); Mon, 4 Feb 2019 12:44:19 -0500 Received: by mail-pg1-f193.google.com with SMTP id c25so235758pgb.4 for ; Mon, 04 Feb 2019 09:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rVphieNMMj5hFtYUWqJfdDQMbOVjQl9e47IvU8JhfFA=; b=EZxTQ/YIux3RucPGF/NS4SnPUWgGgJXLMY4fjA71Xu4d07/3mInbKrTVI7wIBd9073 1mJ612d7InS2YuNH2e7LoCN3z52O8Scn3xM/t41MKwvfKI5peEKdQiZ5fdSc6V/hjplT mHK0f6oZ1D8pk7Z6U3uoHTqVmoS8Pm9aD3aPytn18BqnJONwjD/OuL2zCOypLE41QZLu hWXllGTufoTcm1thlqZCMKon+QH97wvRwf7pMFYvVTcL8T8mSpKelybKi9WdPzOVprkh xCHv2FsJLYMe0litHAivDAEgzU9UjSlJNGgm6x1atORwX3BlD+zMfRxl0jVBMqG8l39g dd6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rVphieNMMj5hFtYUWqJfdDQMbOVjQl9e47IvU8JhfFA=; b=PnFrifGjSYvQTvXh6GVrl5Ma2xTzsMnamoxA3pMFuYscT67aRAPE6JbdSiTqH2y6s4 VHJigECqKYq8doQUmjmbnBmpgTtf2gMfL4FGwrXihK79XLg5PHjWT7341h6TG00sZg1H xbXK6QKXwSC4k80yLI3FCYNHwCHGA429uxWQwjl33LlDKgwqXjqCa3BPbGEQFPSMegIe SMaIsaJD0oV7WCcvds3tSejt4yxmVbFF1L9eGIljjoCsbqpa7lH2i4lJp5XPqhoxIGEm I6/KQ2hhiqWwsWfanef216vhyOfoffXMZjzO/ZHukJUK4sMx87fh+QtowMhMQacAcCCn ZDkg== X-Gm-Message-State: AHQUAuZS5Ir/zGeJwzEiDpUg5oE5ig/4ySY2eM3LcKsZfBK6LmJWbWn1 MKH7ODiz+anwwzGDNJJK9NI= X-Google-Smtp-Source: AHgI3IY0z4ab72Ue7/ICNAd5zMAC7VjCqIs/BcJFA0MAIEuYxBkOBXPjFMrQc1fCzusrU4IRXA5qmg== X-Received: by 2002:a62:62c5:: with SMTP id w188mr544672pfb.160.1549302258369; Mon, 04 Feb 2019 09:44:18 -0800 (PST) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:180::1:6d17]) by smtp.gmail.com with ESMTPSA id p2sm1066028pfb.28.2019.02.04.09.44.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 09:44:17 -0800 (PST) Date: Mon, 4 Feb 2019 09:44:15 -0800 From: Alexei Starovoitov To: Arnaldo Carvalho de Melo Cc: Yonghong Song , Magnus Karlsson , netdev@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , kernel-team@fb.com, Arnaldo Carvalho de Melo Subject: Re: [PATCH bpf-next v4 0/3] tools/bpf: changes of libbpf debug interfaces Message-ID: <20190204174414.jcpw6umiof623anw@ast-mbp.dhcp.thefacebook.com> References: <20190202001413.3178000-1-yhs@fb.com> <20190202165228.jrcghbvro4st4thd@ast-mbp> <20190204145134.GA4290@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204145134.GA4290@redhat.com> User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 04, 2019 at 12:51:34PM -0200, Arnaldo Carvalho de Melo wrote: > Em Sat, Feb 02, 2019 at 08:52:30AM -0800, Alexei Starovoitov escreveu: > > On Fri, Feb 01, 2019 at 04:14:13PM -0800, Yonghong Song wrote: > > > These are patches responding to my comments for > > > Magnus's patch (https://patchwork.ozlabs.org/patch/1032848/). > > > The goal is to make pr_* macros available to other C files > > > than libbpf.c, and to simplify API function libbpf_set_print(). > > > > > > Specifically, Patch #1 used global functions > > > to facilitate pr_* macros in the header files so they > > > are available in different C files. > > > Patch #2 removes the global function libbpf_print_level_available() > > > which is added in Patch 1. > > > Patch #3 simplified libbpf_set_print() which takes only one print > > > function with a debug level argument among others. > > > > > > Changelogs: > > > v3 -> v4: > > > . rename libbpf internal header util.h to libbpf_util.h > > > . rename libbpf internal function libbpf_debug_print() to libbpf_print() > > > v2 -> v3: > > > . bailed out earlier in libbpf_debug_print() if __libbpf_pr is NULL > > > . added missing LIBBPF_DEBUG level check in libbpf.c __base_pr(). > > > v1 -> v2: > > > . Renamed global function libbpf_dprint() to libbpf_debug_print() > > > to be more expressive. > > > . Removed libbpf_dprint_level_available() as it is used only > > > once in btf.c and we can remove it by optimizing for common cases. > > > > > > Yonghong Song (3): > > > tools/bpf: move libbpf pr_* debug print functions to headers > > > tools/bpf: print out btf log at LIBBPF_WARN level > > > tools/bpf: simplify libbpf API function libbpf_set_print() > > > > > > tools/lib/bpf/btf.c | 110 +++++++++--------- > > > tools/lib/bpf/btf.h | 7 +- > > > tools/lib/bpf/libbpf.c | 47 ++++---- > > > tools/lib/bpf/libbpf.h | 20 ++-- > > > tools/lib/bpf/libbpf_util.h | 30 +++++ > > > tools/lib/bpf/test_libbpf.cpp | 4 +- > > > tools/perf/util/bpf-loader.c | 32 ++--- > > > > Overall looks good to me. > > Arnaldo, could you ack the set, so we can take it into bpf-next? > > LGTM > > Acked-by: Arnaldo Carvalho de Melo Applied to bpf-next. Thanks!