From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73EEAC282C4 for ; Tue, 5 Feb 2019 02:56:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DD072081B for ; Tue, 5 Feb 2019 02:56:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="Huug0YvW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727327AbfBEC4i (ORCPT ); Mon, 4 Feb 2019 21:56:38 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:36701 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbfBEC4i (ORCPT ); Mon, 4 Feb 2019 21:56:38 -0500 Received: by mail-pf1-f194.google.com with SMTP id b85so857083pfc.3 for ; Mon, 04 Feb 2019 18:56:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=iYfttfQCcMf7B1EAaZLQR0/Iw2MR/LI6ZtZEDnB9ILg=; b=Huug0YvWsaQgDXL0Kmhl/sp5a5tQC6QV+BqbWg2UMmS5TrE+jHhMdHND6aOHCSImLV 7cK2zZ3omK5veA3kH+e3dNU8rSA+NDG1qjfqgnaf+pRVppAFJbqeIUXyFPci+HYfgW7z jQe3LA1Hp/1dTWBPn1GaSmihEJjGZIL7RhK81MB3o54YupG6QPfKzLkHzRnwZT0PTec0 GKqokicUvW7M3yvENtSZbCZtEdQnXbR6EtFBqaMg9dQvC/NBX8bbDrYTbPuiw5fFI3DO 8jw07/Qub6Xce91dkyNuPlqnJxM8pgrz589P0OIqxHd1Yd4g3qu1Frzbc8C43TdrPzR5 O6NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=iYfttfQCcMf7B1EAaZLQR0/Iw2MR/LI6ZtZEDnB9ILg=; b=mwAS7qYKSoyoMcV4BNwZjmF299R/WF4cFo9of5puSzjh7A++OeFZSoQOFvlRT/9Llx Ckg1yJQLzlE4s1OHpE18yNSyBfse6ul0zvV8bTMO62VgsBN7RPqGecwEehVEpvfyDq1U c/GmmA4dOyZmQjxOZhrZhYhgdrBtUot3Eqz5ToybXL9jLn7/T81YoRnroSmhuTdKn4df EqX0AfAL7GLKLkWXaS+rc1UkLwtEI7tjMOf9b4IheLfRhbl8LAOS2WiCaGylGGzEVkgl FWHr2VulQA19f1YbMY58gFsg86W2bifqKzV+dqOyx5HtO2zbkgL9yNSJErAnXygybD7W uK4A== X-Gm-Message-State: AHQUAuax3n+uBP8GZuXVBzWvETVY9eLQWr9WgrhDQIq4Cokcoa/o8mOW F7Y5cXO6GcPkNocDNR7HIA05mQ== X-Google-Smtp-Source: AHgI3IYTLKCCcz7TAziDHxZQ4zkB+8ttXCjCRgoXY35yOtZA9J7WAEczxoxau+vFW/MGZQcuQy/8wg== X-Received: by 2002:a65:4784:: with SMTP id e4mr2452085pgs.12.1549335397884; Mon, 04 Feb 2019 18:56:37 -0800 (PST) Received: from cakuba.netronome.com ([50.225.197.140]) by smtp.gmail.com with ESMTPSA id p7sm2138529pfa.22.2019.02.04.18.56.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 18:56:37 -0800 (PST) Date: Mon, 4 Feb 2019 18:56:26 -0800 From: Jakub Kicinski To: Vasundhara Volam Cc: Michal Kubecek , Netdev , David Miller , "michael.chan@broadcom.com" , Jiri Pirko Subject: Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port Message-ID: <20190204185626.3c7a162b@cakuba.netronome.com> In-Reply-To: References: <1547795385-12354-1-git-send-email-vasundhara-v.volam@broadcom.com> <20190118143319.GG26670@unicorn.suse.cz> <20190122141842.26908b27@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 4 Feb 2019 12:25:13 +0530, Vasundhara Volam wrote: > > > IMHO this is not really a problem. We can either use an additional flag > > > telling kernel/driver if we are setting runtime or persistent WoL mask > > > or we can pass (up to) two bitmaps. > Jakub, I will add another two bitmask parameters for WoL named as > wake_on_lan_runtime > and wake_on_lan_persistent. This will give information about what > types are runtime and > what types are persistent, does the device support for any given WoL types. > > Does that sound good? No? We were talking about using the soon-too-come ethtool netlink API with additional indication that given configuration request is supposed to be persisted. Adding more devlink parameters is exactly the opposite of what you should be doing.